From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11330C2BA83 for ; Wed, 12 Feb 2020 17:47:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8B3C2073C for ; Wed, 12 Feb 2020 17:47:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8B3C2073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B5A96E0D6; Wed, 12 Feb 2020 17:47:32 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 851896E0D6 for ; Wed, 12 Feb 2020 17:47:31 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 09:47:31 -0800 X-IronPort-AV: E=Sophos;i="5.70,433,1574150400"; d="scan'208";a="226939975" Received: from schmidyv-mobl2.ger.corp.intel.com (HELO localhost) ([10.249.38.234]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 09:47:29 -0800 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org In-Reply-To: <20200212161738.28141-3-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200212161738.28141-1-ville.syrjala@linux.intel.com> <20200212161738.28141-3-ville.syrjala@linux.intel.com> Date: Wed, 12 Feb 2020 19:47:52 +0200 Message-ID: <87imkbvgs7.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2 2/8] drm/i915: Use intel_de_write_fw() for skl+ scaler registers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gV2VkLCAxMiBGZWIgMjAyMCwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBXZSBoYXZlIHRvIHdyaXRlIHF1aXRlIGEgZmV3IHJlZ2lzdGVy cyB3aGVuIHByb2dyYW1taW5nIHRoZQo+IHBpcGUgc2NhbGVyLiBMZXQncyB1c2UgaW50ZWxfZGVf d3JpdGVfZncoKSBmb3IgdGhlc2UgdG8gcmVkdWNlCj4gdGhlIGxvY2tkZXAgb3ZlcmhlYWQgYSBi aXQuIEFsbCBwbGFuZSByZWdpc3RlcnMgKGluY2x1ZGluZyBwbGFuZQo+IHNjYWxlcikgYWxyZWFk eSBkbyB0aGlzLgo+Cj4gV2UgYWxyZWFkeSBoYWQgYSBmZXcgYWNjaWRlbnRhbCBpbnRlbF9kZV93 cml0ZV9mdygpIGluIHRoZXJlLgo+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMgfCAyOSArKysrKysrKysrKysrKy0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggNjFiYTFm MjI1NmEwLi5kZTUwYWEwYjA3NmMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv ZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC00NDk0LDEwICs0NDk0LDE1IEBAIHN0YXRpYyB2b2lk IHNrbF9kZXRhY2hfc2NhbGVyKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLCBpbnQgaWQp Cj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9jcnRjLT5iYXNlLmRldjsK PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAr CXVuc2lnbmVkIGxvbmcgaXJxZmxhZ3M7Cj4gKwo+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9w cml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwoKSHJtaCwgSSBkb24ndCBsaWtlIGhvdyB0aGUg dW5jb3JlIGxvY2sgbGVha3MgdGhyb3VnaCB0aGUgaW50ZWxfZGVfKgphYnN0cmFjdGlvbnMuIEJ1 dCBJIGd1ZXNzIEkgZGlzbGlrZSBhZGRpbmcgd3JhcHBlcnMgZm9yIHNwaW4gbG9ja3MgZXZlbgps ZXNzLgoKUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgoK PiAgCj4gLQlpbnRlbF9kZV93cml0ZShkZXZfcHJpdiwgU0tMX1BTX0NUUkwoaW50ZWxfY3J0Yy0+ cGlwZSwgaWQpLCAwKTsKPiAtCWludGVsX2RlX3dyaXRlKGRldl9wcml2LCBTS0xfUFNfV0lOX1BP UyhpbnRlbF9jcnRjLT5waXBlLCBpZCksIDApOwo+IC0JaW50ZWxfZGVfd3JpdGUoZGV2X3ByaXYs IFNLTF9QU19XSU5fU1ooaW50ZWxfY3J0Yy0+cGlwZSwgaWQpLCAwKTsKPiArCWludGVsX2RlX3dy aXRlX2Z3KGRldl9wcml2LCBTS0xfUFNfQ1RSTChpbnRlbF9jcnRjLT5waXBlLCBpZCksIDApOwo+ ICsJaW50ZWxfZGVfd3JpdGVfZncoZGV2X3ByaXYsIFNLTF9QU19XSU5fUE9TKGludGVsX2NydGMt PnBpcGUsIGlkKSwgMCk7Cj4gKwlpbnRlbF9kZV93cml0ZV9mdyhkZXZfcHJpdiwgU0tMX1BTX1dJ Tl9TWihpbnRlbF9jcnRjLT5waXBlLCBpZCksIDApOwo+ICsKPiArCXNwaW5fdW5sb2NrX2lycXJl c3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+ICB9Cj4gIAo+ICAvKgo+ IEBAIC02MjM0LDYgKzYyMzksNyBAQCBzdGF0aWMgdm9pZCBza2xfcGZpdF9lbmFibGUoY29uc3Qg c3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIAlpZiAoY3J0Y19zdGF0ZS0+ cGNoX3BmaXQuZW5hYmxlZCkgewo+ICAJCXUxNiB1dl9yZ2JfaHBoYXNlLCB1dl9yZ2JfdnBoYXNl Owo+ICAJCWludCBwZml0X3csIHBmaXRfaCwgaHNjYWxlLCB2c2NhbGU7Cj4gKwkJdW5zaWduZWQg bG9uZyBpcnFmbGFnczsKPiAgCQlpbnQgaWQ7Cj4gIAo+ICAJCWlmIChXQVJOX09OKGNydGNfc3Rh dGUtPnNjYWxlcl9zdGF0ZS5zY2FsZXJfaWQgPCAwKSkKPiBAQCAtNjI0OSwxNiArNjI1NSwyMSBA QCBzdGF0aWMgdm9pZCBza2xfcGZpdF9lbmFibGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNydGNfc3RhdGUpCj4gIAkJdXZfcmdiX3ZwaGFzZSA9IHNrbF9zY2FsZXJfY2FsY19waGFz ZSgxLCB2c2NhbGUsIGZhbHNlKTsKPiAgCj4gIAkJaWQgPSBzY2FsZXJfc3RhdGUtPnNjYWxlcl9p ZDsKPiAtCQlpbnRlbF9kZV93cml0ZShkZXZfcHJpdiwgU0tMX1BTX0NUUkwocGlwZSwgaWQpLAo+ IC0JCQkgICAgICAgUFNfU0NBTEVSX0VOIHwgUFNfRklMVEVSX01FRElVTSB8IHNjYWxlcl9zdGF0 ZS0+c2NhbGVyc1tpZF0ubW9kZSk7Cj4gKwo+ICsJCXNwaW5fbG9ja19pcnFzYXZlKCZkZXZfcHJp di0+dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsKPiArCj4gKwkJaW50ZWxfZGVfd3JpdGVfZncoZGV2 X3ByaXYsIFNLTF9QU19DVFJMKHBpcGUsIGlkKSwgUFNfU0NBTEVSX0VOIHwKPiArCQkJCSAgUFNf RklMVEVSX01FRElVTSB8IHNjYWxlcl9zdGF0ZS0+c2NhbGVyc1tpZF0ubW9kZSk7Cj4gIAkJaW50 ZWxfZGVfd3JpdGVfZncoZGV2X3ByaXYsIFNLTF9QU19WUEhBU0UocGlwZSwgaWQpLAo+ICAJCQkJ ICBQU19ZX1BIQVNFKDApIHwgUFNfVVZfUkdCX1BIQVNFKHV2X3JnYl92cGhhc2UpKTsKPiAgCQlp bnRlbF9kZV93cml0ZV9mdyhkZXZfcHJpdiwgU0tMX1BTX0hQSEFTRShwaXBlLCBpZCksCj4gIAkJ CQkgIFBTX1lfUEhBU0UoMCkgfCBQU19VVl9SR0JfUEhBU0UodXZfcmdiX2hwaGFzZSkpOwo+IC0J CWludGVsX2RlX3dyaXRlKGRldl9wcml2LCBTS0xfUFNfV0lOX1BPUyhwaXBlLCBpZCksCj4gLQkJ CSAgICAgICBjcnRjX3N0YXRlLT5wY2hfcGZpdC5wb3MpOwo+IC0JCWludGVsX2RlX3dyaXRlKGRl dl9wcml2LCBTS0xfUFNfV0lOX1NaKHBpcGUsIGlkKSwKPiAtCQkJICAgICAgIGNydGNfc3RhdGUt PnBjaF9wZml0LnNpemUpOwo+ICsJCWludGVsX2RlX3dyaXRlX2Z3KGRldl9wcml2LCBTS0xfUFNf V0lOX1BPUyhwaXBlLCBpZCksCj4gKwkJCQkgIGNydGNfc3RhdGUtPnBjaF9wZml0LnBvcyk7Cj4g KwkJaW50ZWxfZGVfd3JpdGVfZncoZGV2X3ByaXYsIFNLTF9QU19XSU5fU1oocGlwZSwgaWQpLAo+ ICsJCQkJICBjcnRjX3N0YXRlLT5wY2hfcGZpdC5zaXplKTsKPiArCj4gKwkJc3Bpbl91bmxvY2tf aXJxcmVzdG9yZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4gIAl9Cj4gIH0K Ci0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=