From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Delay tracking the GEM context until it is registered
Date: Fri, 24 Jul 2020 15:31:00 +0300 [thread overview]
Message-ID: <87lfj914e3.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <159559237550.21069.11909922893997723896@build.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2020-07-24 12:55:39)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>>
>> > Quoting Chris Wilson (2020-07-23 19:33:48)
>> >> Avoid exposing a partially constructed context by deferring the
>> >> list_add() from the initial construction to the end of registration.
>> >> Otherwise, if we peek into the list of contexts from inside debugfs, we
>> >> may see the partially constructed context and change down some dangling
>> >
>> > s/change/chase/
>>
>> that.
>>
>> Are you sure about the fixes as it is not the commit that
>> actually introduces the registration into context.list?
>>
>> For me it looks like it is a4e7ccdac38e.
>
> The one I picked was where we started adding more context setup after
> the final step of list_add in __create_context(). More apropos would be
> 3aa9945a528e ("drm/i915: Separate GEM context construction and registration to userspace")
> in the same kernel.
Ok, thanks for clearing that out.
The i915_perf iteration seems to not get hurt either so,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
> In the other direction, we have
> f6e8aa387171 ("drm/i915: Report the number of closed vma held by each context in debugfs")
> where we start using the contexts.list in debugfs.
>
> In a4e7ccdac38e we are only moving the list_add(&ctx->link) around in
> __create_context().
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-24 12:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 18:33 [Intel-gfx] [PATCH] drm/i915/gem: Delay tracking the GEM context until it is registered Chris Wilson
2020-07-23 18:35 ` Chris Wilson
2020-07-24 11:55 ` Mika Kuoppala
2020-07-24 12:06 ` Chris Wilson
2020-07-24 12:31 ` Mika Kuoppala [this message]
2020-07-23 18:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-07-23 19:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-23 22:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-07-24 12:07 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-07-24 12:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Delay tracking the GEM context until it is registered (rev2) Patchwork
2020-07-24 12:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-07-24 12:56 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfj914e3.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).