From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 24/30] drm/i915: Refactor pwrite/pread to use single copy of get_user_pages Date: Wed, 13 Apr 2011 08:59:55 -0700 Message-ID: <87mxjui1l0.fsf@pollan.anholt.net> References: <1302640318-23165-1-git-send-email-chris@chris-wilson.co.uk> <1302640318-23165-25-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1007872578==" Return-path: In-Reply-To: <1302640318-23165-25-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1007872578== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= On Tue, 12 Apr 2011 21:31:52 +0100, Chris Wilson wrote: > Replace the three nearly identical copies of the code with a single > function. And take advantage of the opportunity to do some > micro-optimisation: avoid the vmalloc if at all possible and also avoid > dropping the lock unless we are forced to acquire the mm semaphore. Could we get some performance numbers in patches that add code for performance? --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk2lyHsACgkQHUdvYGzw6vcgMwCfQJMdGc7q7Q2GXWJR4aX8FzaH iz0An1PJ59D0fbupocKxokP5Whgv3qTM =hkdn -----END PGP SIGNATURE----- --=-=-=-- --===============1007872578== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1007872578==--