From: Jani Nikula <jani.nikula@intel.com>
To: Vivek Kasireddy <vivek.kasireddy@intel.com>,
intel-gfx@lists.freedesktop.org,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsi: Ensure that the ACPI adapter lookup overrides the bus num
Date: Fri, 24 Jan 2020 14:12:01 +0200 [thread overview]
Message-ID: <87sgk5gijy.fsf@intel.com> (raw)
In-Reply-To: <871rrvjj0v.fsf@intel.com>
On Sun, 19 Jan 2020, Jani Nikula <jani.nikula@intel.com> wrote:
> On Fri, 17 Jan 2020, Vivek Kasireddy <vivek.kasireddy@intel.com> wrote:
>> Remove the i2c_bus_num >= 0 check from the adapter lookup function
>> as this would prevent ACPI bus number override. This check was mainly
>> there to return early if the bus number has already been found but we
>> anyway return in the next line if the slave address does not match.
>
> Hans, could I trouble you to check this on your collection of BYT DSI
> devices please?
I went ahead and pushed the patch. Thanks.
BR,
Jani.
>
> BR,
> Jani.
>
>
>>
>> Fixes: 8cbf89db2941 ("drm/i915/dsi: Parse the I2C element from the VBT MIPI sequence block (v3)")
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Cc: Bob Paauwe <bob.j.paauwe@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> index 6ec35d975bd7..04f953ba8f00 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
>> @@ -394,8 +394,7 @@ static int i2c_adapter_lookup(struct acpi_resource *ares, void *data)
>> acpi_handle adapter_handle;
>> acpi_status status;
>>
>> - if (intel_dsi->i2c_bus_num >= 0 ||
>> - !i2c_acpi_get_i2c_resource(ares, &sb))
>> + if (!i2c_acpi_get_i2c_resource(ares, &sb))
>> return 1;
>>
>> if (lookup->slave_addr != sb->slave_address)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-24 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 0:58 [Intel-gfx] [PATCH] drm/i915/dsi: Ensure that the ACPI adapter lookup overrides the bus num Vivek Kasireddy
2020-01-18 4:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-18 4:23 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-19 20:20 ` [Intel-gfx] [PATCH] " Jani Nikula
2020-01-24 12:12 ` Jani Nikula [this message]
2020-01-20 20:33 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgk5gijy.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).