From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Expand bad CS completion event debug
Date: Wed, 12 Feb 2020 14:44:26 +0200 [thread overview]
Message-ID: <87v9oc7z6d.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20200211230944.1203098-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Show the ring/request/context state if we see what we believe is an
> early CS completion.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_context.c | 3 ++-
> drivers/gpu/drm/i915/gt/intel_lrc.c | 31 +++++++++++++++++++++++--
> 2 files changed, 31 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_context.c b/drivers/gpu/drm/i915/gt/intel_context.c
> index 57e8a051ddc2..e4f89341d17c 100644
> --- a/drivers/gpu/drm/i915/gt/intel_context.c
> +++ b/drivers/gpu/drm/i915/gt/intel_context.c
> @@ -116,7 +116,8 @@ int __intel_context_do_pin(struct intel_context *ce)
> if (unlikely(err))
> goto err_active;
>
> - CE_TRACE(ce, "pin ring:{head:%04x, tail:%04x}\n",
> + CE_TRACE(ce, "pin ring:{start:%08x, head:%04x, tail:%04x}\n",
> + i915_ggtt_offset(ce->ring->vma),
> ce->ring->head, ce->ring->tail);
>
> smp_mb__before_atomic(); /* flush pin before it is visible */
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index 902d440ef07d..1e3db37dea2b 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -2328,8 +2328,35 @@ static void process_csb(struct intel_engine_cs *engine)
> * coherent (visible from the CPU) before the
> * user interrupt and CSB is processed.
> */
> - GEM_BUG_ON(!i915_request_completed(*execlists->active) &&
> - !reset_in_progress(execlists));
> + if (GEM_SHOW_DEBUG() &&
> + !i915_request_completed(*execlists->active) &&
> + !reset_in_progress(execlists)) {
> + struct i915_request *rq = *execlists->active;
> + const u32 *regs = rq->context->lrc_reg_state;
> +
> + ENGINE_TRACE(engine,
> + "ring:{start:0x%08x, head:%04x, tail:%04x, ctl:%08x, mode:%08x}\n",
> + ENGINE_READ(engine, RING_START),
> + ENGINE_READ(engine, RING_HEAD) & HEAD_ADDR,
> + ENGINE_READ(engine, RING_TAIL) & TAIL_ADDR,
> + ENGINE_READ(engine, RING_CTL),
> + ENGINE_READ(engine, RING_MI_MODE));
> + ENGINE_TRACE(engine,
> + "rq:{start:%08x, head:%04x, tail:%04x, seqno:%llx:%d, hwsp:%d}, ",
> + i915_ggtt_offset(rq->ring->vma),
> + rq->head, rq->tail,
> + rq->fence.context,
> + lower_32_bits(rq->fence.seqno),
> + hwsp_seqno(rq));
> + ENGINE_TRACE(engine,
> + "ctx:{start:%08x, head:%04x, tail:%04x}, ",
> + regs[CTX_RING_START],
> + regs[CTX_RING_HEAD],
> + regs[CTX_RING_TAIL]);
> +
> + GEM_BUG_ON("context completed before request");
> + }
> +
> execlists_schedule_out(*execlists->active++);
>
> GEM_BUG_ON(execlists->active - execlists->inflight >
> --
> 2.25.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-12 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 23:09 [Intel-gfx] [PATCH] drm/i915/gt: Expand bad CS completion event debug Chris Wilson
2020-02-12 12:44 ` Mika Kuoppala [this message]
2020-02-12 20:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-14 23:16 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9oc7z6d.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).