From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 2/9] intel gen4-5: simplify the bfc copy in
	the sf.
Date: Thu, 26 Jul 2012 10:20:08 -0700
Message-ID: <87zk6mphh3.fsf@eliezer.anholt.net>
References: <1342728024-15055-1-git-send-email-galibert@pobox.com>
	<1342728024-15055-3-git-send-email-galibert@pobox.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0444679885=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <1342728024-15055-3-git-send-email-galibert@pobox.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org, mesa-dev@lists.freedesktop.org
Cc: Olivier Galibert <galibert@pobox.com>
List-Id: intel-gfx@lists.freedesktop.org

--===============0444679885==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

Olivier Galibert <galibert@pobox.com> writes:
> @@ -121,12 +108,15 @@ static void do_twoside_color( struct brw_sf_compile=
 *c )
>     brw_push_insn_state(p);
>     brw_CMP(p, vec4(brw_null_reg()), backface_conditional, c->det, brw_im=
m_f(0));
>     brw_IF(p, BRW_EXECUTE_4);
> -   {
> -      switch (c->nr_verts) {
> -      case 3: copy_bfc(c, c->vert[2]);
> -      case 2: copy_bfc(c, c->vert[1]);
> -      case 1: copy_bfc(c, c->vert[0]);
> -      }
> +   for (i=3D0; i<c->nr_verts; i++) {

We tend to put spaces around our binary operators.

> +      if (need_0)
> +	 brw_MOV(p,=20
> +		 get_vert_result(c, c->vert[i], VERT_RESULT_COL0),
> +		 get_vert_result(c, c->vert[i], VERT_RESULT_BFC0));
> +      if (need_1)
> +	 brw_MOV(p,=20
> +		 get_vert_result(c, c->vert[i], VERT_RESULT_COL1),
> +		 get_vert_result(c, c->vert[i], VERT_RESULT_BFC1));

trim trailing whitespace.

Other than that,

Reviewed-by: Eric Anholt <eric@anholt.net>

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlARfEkACgkQHUdvYGzw6vetbQCfRWF+/PawANyqmiWgtP2uNGyJ
y8UAoJBVFtXxWHXgVx1LvGvhHT6POz2N
=OdnX
-----END PGP SIGNATURE-----
--=-=-=--

--===============0444679885==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============0444679885==--