intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp
@ 2021-07-28 15:50 Matthew Auld
  2021-07-28 16:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Matthew Auld @ 2021-07-28 15:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

Since the object might still be active here, the shrink_all will simply
ignore it, which blows up in the test, since the pages will still be
there. Currently THP is disabled which should result in the test being
skipped, but if we ever re-enable THP we might start seeing the failure.
Fix this by forcing I915_SHRINK_ACTIVE.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
index a094f3ce1a90..7a67e880b562 100644
--- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
+++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
@@ -1575,7 +1575,10 @@ static int igt_shrink_thp(void *arg)
 	 * Now that the pages are *unpinned* shrink-all should invoke
 	 * shmem to truncate our pages.
 	 */
-	i915_gem_shrink_all(i915);
+	i915_gem_shrink(NULL, i915, -1UL, NULL,
+			I915_SHRINK_BOUND |
+			I915_SHRINK_UNBOUND |
+			I915_SHRINK_ACTIVE);
 	if (i915_gem_object_has_pages(obj)) {
 		pr_err("shrink-all didn't truncate the pages\n");
 		err = -EINVAL;
-- 
2.26.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: fixup igt_shrink_thp
  2021-07-28 15:50 [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp Matthew Auld
@ 2021-07-28 16:55 ` Patchwork
  2021-07-28 19:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
  2021-07-29 10:53 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
  2 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-07-28 16:55 UTC (permalink / raw)
  To: Matthew Auld; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 2672 bytes --]

== Series Details ==

Series: drm/i915/selftests: fixup igt_shrink_thp
URL   : https://patchwork.freedesktop.org/series/93128/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10411 -> Patchwork_20725
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/index.html

Known issues
------------

  Here are the changes found in Patchwork_20725 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [PASS][1] -> [FAIL][2] ([i915#1372])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-tgl-u2:          [FAIL][3] ([i915#1888]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html

  * igt@i915_selftest@live@hangcheck:
    - {fi-hsw-gt1}:       [DMESG-WARN][5] ([i915#3303]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
  [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
  [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303


Participating hosts (41 -> 35)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-kbl-8809g fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_10411 -> Patchwork_20725

  CI-20190529: 20190529
  CI_DRM_10411: 2c25ff42a7175b652d93ac3555d4ae13456beb4a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6153: a5dffe7499a2f7189718ddf1ccf49060b7c1529d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_20725: 2f028f0cdb9110c4e093c1b35796181087728ee7 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

2f028f0cdb91 drm/i915/selftests: fixup igt_shrink_thp

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/index.html

[-- Attachment #1.2: Type: text/html, Size: 3338 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: fixup igt_shrink_thp
  2021-07-28 15:50 [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp Matthew Auld
  2021-07-28 16:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-07-28 19:53 ` Patchwork
  2021-07-29 10:53 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
  2 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-07-28 19:53 UTC (permalink / raw)
  To: Matthew Auld; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 30263 bytes --]

== Series Details ==

Series: drm/i915/selftests: fixup igt_shrink_thp
URL   : https://patchwork.freedesktop.org/series/93128/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10411_full -> Patchwork_20725_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_20725_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@kms_busy@extended-modeset-hang-oldfb:
    - {shard-rkl}:        NOTRUN -> [SKIP][1] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-1/igt@kms_busy@extended-modeset-hang-oldfb.html

  * igt@runner@aborted:
    - {shard-rkl}:        ([FAIL][2], [FAIL][3], [FAIL][4], [FAIL][5]) ([i915#2029] / [i915#3002] / [i915#3810] / [i915#3811]) -> ([FAIL][6], [FAIL][7], [FAIL][8]) ([i915#3002] / [i915#3810])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-6/igt@runner@aborted.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-5/igt@runner@aborted.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@runner@aborted.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-2/igt@runner@aborted.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@runner@aborted.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-1/igt@runner@aborted.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-5/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in Patchwork_20725_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_persistence@process:
    - shard-snb:          NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1099]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-snb7/igt@gem_ctx_persistence@process.html

  * igt@gem_ctx_shared@q-in-order:
    - shard-snb:          NOTRUN -> [SKIP][10] ([fdo#109271]) +215 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-snb7/igt@gem_ctx_shared@q-in-order.html

  * igt@gem_eio@unwedge-stress:
    - shard-iclb:         [PASS][11] -> [TIMEOUT][12] ([i915#2369] / [i915#2481] / [i915#3070])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-iclb6/igt@gem_eio@unwedge-stress.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-iclb2/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-kbl:          NOTRUN -> [FAIL][13] ([i915#2846])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl6/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-pace@vcs0:
    - shard-tglb:         [PASS][14] -> [FAIL][15] ([i915#2842])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-tglb3/igt@gem_exec_fair@basic-pace@vcs0.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-tglb5/igt@gem_exec_fair@basic-pace@vcs0.html

  * igt@gem_exec_whisper@basic-contexts-forked-all:
    - shard-glk:          [PASS][16] -> [DMESG-WARN][17] ([i915#118] / [i915#95])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-glk1/igt@gem_exec_whisper@basic-contexts-forked-all.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-glk3/igt@gem_exec_whisper@basic-contexts-forked-all.html

  * igt@gem_huc_copy@huc-copy:
    - shard-kbl:          NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#2190])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl3/igt@gem_huc_copy@huc-copy.html

  * igt@gem_mmap_gtt@cpuset-big-copy-xy:
    - shard-glk:          [PASS][19] -> [FAIL][20] ([i915#1888] / [i915#307]) +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-glk3/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-glk9/igt@gem_mmap_gtt@cpuset-big-copy-xy.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-kbl:          NOTRUN -> [WARN][21] ([i915#2658])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl1/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
    - shard-kbl:          NOTRUN -> [SKIP][22] ([fdo#109271]) +211 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl6/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-kbl:          NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#3323])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl6/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-kbl:          NOTRUN -> [FAIL][24] ([i915#545]) +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl3/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-kbl:          NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#1937])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl4/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@i915_pm_rpm@modeset-pc8-residency-stress:
    - shard-apl:          NOTRUN -> [SKIP][26] ([fdo#109271]) +160 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl3/igt@i915_pm_rpm@modeset-pc8-residency-stress.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][27] -> [DMESG-WARN][28] ([i915#180]) +3 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-apl2/igt@i915_suspend@sysfs-reader.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl7/igt@i915_suspend@sysfs-reader.html
    - shard-kbl:          [PASS][29] -> [DMESG-WARN][30] ([i915#180]) +2 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl6/igt@i915_suspend@sysfs-reader.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl7/igt@i915_suspend@sysfs-reader.html

  * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
    - shard-kbl:          NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#3777])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl3/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
    - shard-apl:          NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3777])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl8/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html

  * igt@kms_chamelium@dp-hpd-storm-disable:
    - shard-apl:          NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +14 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl8/igt@kms_chamelium@dp-hpd-storm-disable.html

  * igt@kms_chamelium@hdmi-crc-multiple:
    - shard-snb:          NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-snb6/igt@kms_chamelium@hdmi-crc-multiple.html

  * igt@kms_color_chamelium@pipe-a-ctm-0-75:
    - shard-kbl:          NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +16 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl3/igt@kms_color_chamelium@pipe-a-ctm-0-75.html

  * igt@kms_color_chamelium@pipe-invalid-gamma-lut-sizes:
    - shard-skl:          NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-skl7/igt@kms_color_chamelium@pipe-invalid-gamma-lut-sizes.html

  * igt@kms_content_protection@atomic-dpms:
    - shard-apl:          NOTRUN -> [TIMEOUT][37] ([i915#1319])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl3/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-skl:          [PASS][38] -> [FAIL][39] ([i915#2346])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
    - shard-skl:          [PASS][40] -> [DMESG-WARN][41] ([i915#1982])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
    - shard-glk:          [PASS][42] -> [FAIL][43] ([i915#79])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-glk2/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
    - shard-apl:          NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#2672])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

  * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
    - shard-kbl:          NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#2672])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][46] ([i915#180]) +1 similar issue
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-apl:          NOTRUN -> [FAIL][47] ([fdo#108145] / [i915#265]) +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html

  * igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant:
    - shard-iclb:         [PASS][48] -> [SKIP][49] ([fdo#109278])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-iclb6/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-iclb2/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
    - shard-apl:          NOTRUN -> [FAIL][50] ([i915#265])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
    - shard-kbl:          NOTRUN -> [FAIL][51] ([i915#265])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html

  * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
    - shard-kbl:          NOTRUN -> [FAIL][52] ([fdo#108145] / [i915#265]) +3 similar issues
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl1/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [PASS][53] -> [FAIL][54] ([fdo#108145] / [i915#265])
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
    - shard-apl:          NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#2733])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl7/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
    - shard-kbl:          NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#658]) +2 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
    - shard-apl:          NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#658])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl3/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][58] -> [SKIP][59] ([fdo#109642] / [fdo#111068] / [i915#658])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-iclb6/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [PASS][60] -> [DMESG-WARN][61] ([i915#180] / [i915#295])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@kms_vblank@pipe-d-query-idle-hang:
    - shard-skl:          NOTRUN -> [SKIP][62] ([fdo#109271]) +5 similar issues
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-skl4/igt@kms_vblank@pipe-d-query-idle-hang.html

  * igt@kms_writeback@writeback-check-output:
    - shard-apl:          NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2437])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl3/igt@kms_writeback@writeback-check-output.html

  * igt@perf@polling-parameterized:
    - shard-glk:          [PASS][64] -> [FAIL][65] ([i915#1542])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-glk6/igt@perf@polling-parameterized.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-glk9/igt@perf@polling-parameterized.html
    - shard-skl:          [PASS][66] -> [FAIL][67] ([i915#1542])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-skl5/igt@perf@polling-parameterized.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-skl9/igt@perf@polling-parameterized.html

  * igt@sysfs_clients@fair-3:
    - shard-kbl:          NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2994]) +4 similar issues
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl1/igt@sysfs_clients@fair-3.html

  * igt@sysfs_clients@fair-7:
    - shard-apl:          NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2994])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl3/igt@sysfs_clients@fair-7.html

  
#### Possible fixes ####

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-iclb:         [FAIL][70] ([i915#2842]) -> [PASS][71]
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
    - shard-apl:          [SKIP][72] ([fdo#109271]) -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl7/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_suspend@basic-s3:
    - shard-skl:          [INCOMPLETE][74] ([i915#146] / [i915#198]) -> [PASS][75] +1 similar issue
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-skl10/igt@gem_exec_suspend@basic-s3.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-skl4/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_exec_whisper@basic-fds-all:
    - shard-glk:          [DMESG-WARN][76] ([i915#118] / [i915#95]) -> [PASS][77] +1 similar issue
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-glk9/igt@gem_exec_whisper@basic-fds-all.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-glk7/igt@gem_exec_whisper@basic-fds-all.html

  * igt@gem_huc_copy@huc-copy:
    - shard-tglb:         [SKIP][78] ([i915#2190]) -> [PASS][79]
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-tglb6/igt@gem_huc_copy@huc-copy.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-tglb7/igt@gem_huc_copy@huc-copy.html

  * igt@gem_workarounds@suspend-resume-fd:
    - {shard-rkl}:        [DMESG-WARN][80] ([i915#3843]) -> [PASS][81] +4 similar issues
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-5/igt@gem_workarounds@suspend-resume-fd.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-5/igt@gem_workarounds@suspend-resume-fd.html

  * igt@i915_pm_rpm@gem-evict-pwrite:
    - {shard-rkl}:        [SKIP][82] ([i915#3842]) -> [PASS][83] +3 similar issues
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-5/igt@i915_pm_rpm@gem-evict-pwrite.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-5/igt@i915_pm_rpm@gem-evict-pwrite.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [DMESG-WARN][84] ([i915#180]) -> [PASS][85]
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_big_fb@linear-8bpp-rotate-180:
    - {shard-rkl}:        [SKIP][86] ([i915#3638]) -> [PASS][87] +2 similar issues
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_big_fb@linear-8bpp-rotate-180.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_big_fb@linear-8bpp-rotate-180.html

  * igt@kms_big_fb@y-tiled-16bpp-rotate-90:
    - {shard-rkl}:        [SKIP][88] ([fdo#111614]) -> [PASS][89]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_big_fb@y-tiled-16bpp-rotate-90.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_big_fb@y-tiled-16bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180:
    - {shard-rkl}:        [SKIP][90] ([i915#3721]) -> [PASS][91] +4 similar issues
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180.html

  * igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
    - {shard-rkl}:        [FAIL][92] ([i915#3678]) -> [PASS][93] +4 similar issues
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_color@pipe-a-ctm-0-75:
    - {shard-rkl}:        [SKIP][94] ([i915#1149] / [i915#1849]) -> [PASS][95] +3 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_color@pipe-a-ctm-0-75.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_color@pipe-a-ctm-0-75.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-random:
    - {shard-rkl}:        [SKIP][96] ([fdo#112022]) -> [PASS][97] +16 similar issues
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-skl:          [FAIL][98] ([i915#2346] / [i915#533]) -> [PASS][99]
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic:
    - {shard-rkl}:        [SKIP][100] ([fdo#111825]) -> [PASS][101] +4 similar issues
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic.html

  * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
    - {shard-rkl}:        [SKIP][102] ([fdo#111314]) -> [PASS][103] +4 similar issues
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
    - {shard-rkl}:        [SKIP][104] ([i915#1849]) -> [PASS][105] +29 similar issues
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html

  * igt@kms_hdr@bpc-switch-dpms:
    - shard-skl:          [FAIL][106] ([i915#1188]) -> [PASS][107] +1 similar issue
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html

  * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
    - shard-kbl:          [DMESG-WARN][108] ([i915#180]) -> [PASS][109] +10 similar issues
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
    - {shard-rkl}:        [SKIP][110] ([i915#3558]) -> [PASS][111] +5 similar issues
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_plane_multiple@atomic-pipe-b-tiling-y.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_plane_multiple@atomic-pipe-b-tiling-y.html

  * igt@kms_psr@cursor_plane_onoff:
    - {shard-rkl}:        [SKIP][112] ([i915#1072]) -> [PASS][113] +2 similar issues
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_psr@cursor_plane_onoff.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_psr@cursor_plane_onoff.html

  * igt@kms_psr@psr2_sprite_render:
    - shard-iclb:         [SKIP][114] ([fdo#109441]) -> [PASS][115]
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-iclb7/igt@kms_psr@psr2_sprite_render.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-iclb2/igt@kms_psr@psr2_sprite_render.html

  * igt@kms_vblank@pipe-a-ts-continuation-modeset:
    - {shard-rkl}:        [SKIP][116] ([i915#1845]) -> [PASS][117] +19 similar issues
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@kms_vblank@pipe-a-ts-continuation-modeset.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-6/igt@kms_vblank@pipe-a-ts-continuation-modeset.html

  * igt@perf_pmu@rc6-runtime-pm-long:
    - {shard-rkl}:        [SKIP][118] ([i915#293]) -> [PASS][119]
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-rkl-1/igt@perf_pmu@rc6-runtime-pm-long.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-rkl-1/igt@perf_pmu@rc6-runtime-pm-long.html

  * igt@sysfs_heartbeat_interval@mixed@vcs0:
    - shard-skl:          [FAIL][120] ([i915#1731]) -> [PASS][121]
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-skl8/igt@sysfs_heartbeat_interval@mixed@vcs0.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-skl1/igt@sysfs_heartbeat_interval@mixed@vcs0.html

  
#### Warnings ####

  * igt@i915_pm_dc@dc3co-vpb-simulation:
    - shard-iclb:         [SKIP][122] ([i915#588]) -> [SKIP][123] ([i915#658])
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-iclb4/igt@i915_pm_dc@dc3co-vpb-simulation.html

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][124] ([i915#1804] / [i915#2684]) -> [WARN][125] ([i915#2684]) +1 similar issue
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-iclb7/igt@i915_pm_rc6_residency@rc6-fence.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
    - shard-iclb:         [SKIP][126] ([i915#2920]) -> [SKIP][127] ([i915#658])
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
    - shard-iclb:         [SKIP][128] ([i915#658]) -> [SKIP][129] ([i915#2920]) +1 similar issue
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2426] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602]) -> ([FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149]) ([i915#180] / [i915#1814] / [i915#2426] / [i915#3002] / [i915#3363] / [i915#602])
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl7/igt@runner@aborted.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl1/igt@runner@aborted.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl4/igt@runner@aborted.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl6/igt@runner@aborted.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl3/igt@runner@aborted.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl7/igt@runner@aborted.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl7/igt@runner@aborted.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl6/igt@runner@aborted.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl1/igt@runner@aborted.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl7/igt@runner@aborted.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl7/igt@runner@aborted.html
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-kbl3/igt@runner@aborted.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl1/igt@runner@aborted.html
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl1/igt@runner@aborted.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl1/igt@runner@aborted.html
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl1/igt@runner@aborted.html
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl4/igt@runner@aborted.html
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl4/igt@runner@aborted.html
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl7/igt@runner@aborted.html
   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-kbl7/igt@runner@aborted.html
    - shard-apl:          ([FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154]) ([i915#180] / [i915#1814] / [i915#2426] / [i915#3002] / [i915#3363]) -> ([FAIL][155], [FAIL][156], [FAIL][157], [FAIL][158], [FAIL][159]) ([i915#180] / [i915#1814] / [i915#2426] / [i915#3363])
   [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-apl8/igt@runner@aborted.html
   [151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-apl7/igt@runner@aborted.html
   [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-apl8/igt@runner@aborted.html
   [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-apl3/igt@runner@aborted.html
   [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10411/shard-apl7/igt@runner@aborted.html
   [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl7/igt@runner@aborted.html
   [156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/shard-apl2/igt@runner@aborted.html
   [157]: https://intel-gfx-ci

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20725/index.html

[-- Attachment #1.2: Type: text/html, Size: 33465 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp
  2021-07-28 15:50 [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp Matthew Auld
  2021-07-28 16:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
  2021-07-28 19:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-07-29 10:53 ` Tvrtko Ursulin
  2021-07-29 10:55   ` Matthew Auld
  2 siblings, 1 reply; 11+ messages in thread
From: Tvrtko Ursulin @ 2021-07-29 10:53 UTC (permalink / raw)
  To: Matthew Auld, intel-gfx; +Cc: dri-devel


Hi Matt,

On 28/07/2021 16:50, Matthew Auld wrote:
> Since the object might still be active here, the shrink_all will simply
> ignore it, which blows up in the test, since the pages will still be
> there. Currently THP is disabled which should result in the test being
> skipped, but if we ever re-enable THP we might start seeing the failure.
> Fix this by forcing I915_SHRINK_ACTIVE.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> index a094f3ce1a90..7a67e880b562 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> @@ -1575,7 +1575,10 @@ static int igt_shrink_thp(void *arg)
>   	 * Now that the pages are *unpinned* shrink-all should invoke
>   	 * shmem to truncate our pages.
>   	 */
> -	i915_gem_shrink_all(i915);
> +	i915_gem_shrink(NULL, i915, -1UL, NULL,
> +			I915_SHRINK_BOUND |
> +			I915_SHRINK_UNBOUND |
> +			I915_SHRINK_ACTIVE);
>   	if (i915_gem_object_has_pages(obj)) {
>   		pr_err("shrink-all didn't truncate the pages\n");
>   		err = -EINVAL;
> 

I did s/shrink-all/shrinking/ locally in the comment above, and in 
pr_err below the call to shrinker. Are you okay if I repost like that 
and with my r-b as part of my series?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp
  2021-07-29 10:53 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
@ 2021-07-29 10:55   ` Matthew Auld
  0 siblings, 0 replies; 11+ messages in thread
From: Matthew Auld @ 2021-07-29 10:55 UTC (permalink / raw)
  To: Tvrtko Ursulin, intel-gfx; +Cc: dri-devel

On 29/07/2021 11:53, Tvrtko Ursulin wrote:
> 
> Hi Matt,
> 
> On 28/07/2021 16:50, Matthew Auld wrote:
>> Since the object might still be active here, the shrink_all will simply
>> ignore it, which blows up in the test, since the pages will still be
>> there. Currently THP is disabled which should result in the test being
>> skipped, but if we ever re-enable THP we might start seeing the failure.
>> Fix this by forcing I915_SHRINK_ACTIVE.
>>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> ---
>>   drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c 
>> b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>> index a094f3ce1a90..7a67e880b562 100644
>> --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>> +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>> @@ -1575,7 +1575,10 @@ static int igt_shrink_thp(void *arg)
>>        * Now that the pages are *unpinned* shrink-all should invoke
>>        * shmem to truncate our pages.
>>        */
>> -    i915_gem_shrink_all(i915);
>> +    i915_gem_shrink(NULL, i915, -1UL, NULL,
>> +            I915_SHRINK_BOUND |
>> +            I915_SHRINK_UNBOUND |
>> +            I915_SHRINK_ACTIVE);
>>       if (i915_gem_object_has_pages(obj)) {
>>           pr_err("shrink-all didn't truncate the pages\n");
>>           err = -EINVAL;
>>
> 
> I did s/shrink-all/shrinking/ locally in the comment above, and in 
> pr_err below the call to shrinker. Are you okay if I repost like that 
> and with my r-b as part of my series?

Sure.

> 
> Regards,
> 
> Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp
  2021-09-06 13:48       ` Matthew Auld
@ 2021-09-06 15:52         ` Tvrtko Ursulin
  0 siblings, 0 replies; 11+ messages in thread
From: Tvrtko Ursulin @ 2021-09-06 15:52 UTC (permalink / raw)
  To: Matthew Auld, intel-gfx; +Cc: dri-devel, Tvrtko Ursulin, Thomas Hellström


On 06/09/2021 14:48, Matthew Auld wrote:
> On 06/09/2021 13:53, Tvrtko Ursulin wrote:
>>
>> On 06/09/2021 13:30, Matthew Auld wrote:
>>> On 06/09/2021 13:19, Tvrtko Ursulin wrote:
>>>>
>>>> On 06/09/2021 10:17, Matthew Auld wrote:
>>>>> Since the object might still be active here, the shrink_all will 
>>>>> simply
>>>>> ignore it, which blows up in the test, since the pages will still be
>>>>> there. Currently THP is disabled which should result in the test being
>>>>> skipped, but if we ever re-enable THP we might start seeing the 
>>>>> failure.
>>>>> Fix this by forcing I915_SHRINK_ACTIVE.
>>>>>
>>>>> v2: Some machine in the shard runs doesn't seem to have any available
>>>>> swap when running this test. Try to handle this.
>>>>>
>>>>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>>>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>>>>> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> #v1
>>>>> ---
>>>>>   .../gpu/drm/i915/gem/selftests/huge_pages.c   | 31 
>>>>> ++++++++++++++-----
>>>>>   1 file changed, 24 insertions(+), 7 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c 
>>>>> b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>>>>> index a094f3ce1a90..46ea1997c114 100644
>>>>> --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>>>>> +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>>>>> @@ -1519,6 +1519,7 @@ static int igt_shrink_thp(void *arg)
>>>>>       struct i915_vma *vma;
>>>>>       unsigned int flags = PIN_USER;
>>>>>       unsigned int n;
>>>>> +    bool should_swap;
>>>>>       int err = 0;
>>>>>       /*
>>>>> @@ -1567,23 +1568,39 @@ static int igt_shrink_thp(void *arg)
>>>>>               break;
>>>>>       }
>>>>>       i915_gem_context_unlock_engines(ctx);
>>>>> +    /*
>>>>> +     * Nuke everything *before* we unpin the pages so we can be 
>>>>> reasonably
>>>>> +     * sure that when later checking get_nr_swap_pages() that some 
>>>>> random
>>>>> +     * leftover object doesn't steal the remaining swap space.
>>>>> +     */
>>>>> +    i915_gem_shrink(NULL, i915, -1UL, NULL,
>>>>> +            I915_SHRINK_BOUND |
>>>>> +            I915_SHRINK_UNBOUND |
>>>>> +            I915_SHRINK_ACTIVE);
>>>>>       i915_vma_unpin(vma);
>>>>>       if (err)
>>>>>           goto out_put;
>>>>> +
>>>>>       /*
>>>>> -     * Now that the pages are *unpinned* shrink-all should invoke
>>>>> -     * shmem to truncate our pages.
>>>>> +     * Now that the pages are *unpinned* shrinking should invoke
>>>>> +     * shmem to truncate our pages, if we have available swap.
>>>>>        */
>>>>> -    i915_gem_shrink_all(i915);
>>>>> -    if (i915_gem_object_has_pages(obj)) {
>>>>> -        pr_err("shrink-all didn't truncate the pages\n");
>>>>> +    should_swap = get_nr_swap_pages() > 0;
>>>>> +    i915_gem_shrink(NULL, i915, -1UL, NULL,
>>>>> +            I915_SHRINK_BOUND |
>>>>> +            I915_SHRINK_UNBOUND |
>>>>> +            I915_SHRINK_ACTIVE);
>>>>> +    if (should_swap == i915_gem_object_has_pages(obj)) {
>>>>
>>>> Hmm is there any value running the test if no swap (given objects 
>>>> used by the test are "willneed"), or you could simplify and just do 
>>>> early skip?
>>>
>>> Maybe. My thinking was that this adds some coverage if say the device 
>>> is not configured with swap. i.e assert that the pages don't 
>>> magically disappear, and that their contents still persist etc.
>>>
>>> Happy to make it skip instead though?
>>
>> So reducing it to a basic shrinker test in that case. Hm.. do you know 
>> if we have a non THP specific tests for that already somewhere in 
>> selftests (I can't spot any), or just in IGT?
> 
> Just IGT I think, outside of some cases where we call gem_shrink in very 
> specific places, which would be hard to do from an IGT.
> 
>>
>> If we indeed don't have it in selftests, then I guess question is 
>> whether it is warranted to "hide" such a basic test in the THP 
>> "drawer", or instead adding a generic shrinker test should be 
>> considered. (And one could then follow with a question should a basic 
>> generic test have a THP sub-test.)
> 
> The reason for the selftest vs IGT is mostly because userspace doesn't 
> have any knowledge of the underlying pages, or whether THP is used. IIRC 
> there was some issue with THP + our shmem backend in the past, so also 
> adding some basic coverage for THP + i915-gem shrinker seemed 
> reasonable. Even if we don't have swap space, I think it still makes 
> some sense to call into gem_shrink with our target THP object.

Okay, as you have probably guessed I have no strong feelings either way, 
so you can freely upgrade my r-b to current.

Regards,

Tvrtko

> 
>>
>> It's hard to say where the boundary for selftests-vs-IGT coverage 
>> should be in this case. I mean would it be warranted to add such a 
>> generic shrinker selftest. It is mostly testable from userspace, but 
>> kernel can do a few more introspections and sanity checks at cost of 
>> growing kernel code.
>>
>> Regards,
>>
>> Tvrtko
>>
>>>
>>>>
>>>> Regards,
>>>>
>>>> Tvrtko
>>>>
>>>>> +        pr_err("unexpected pages mismatch, should_swap=%s\n",
>>>>> +               yesno(should_swap));
>>>>>           err = -EINVAL;
>>>>>           goto out_put;
>>>>>       }
>>>>> -    if (obj->mm.page_sizes.sg || obj->mm.page_sizes.phys) {
>>>>> -        pr_err("residual page-size bits left\n");
>>>>> +    if (should_swap == (obj->mm.page_sizes.sg || 
>>>>> obj->mm.page_sizes.phys)) {
>>>>> +        pr_err("unexpected residual page-size bits, 
>>>>> should_swap=%s\n",
>>>>> +               yesno(should_swap));
>>>>>           err = -EINVAL;
>>>>>           goto out_put;
>>>>>       }
>>>>>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp
  2021-09-06 12:53     ` Tvrtko Ursulin
@ 2021-09-06 13:48       ` Matthew Auld
  2021-09-06 15:52         ` Tvrtko Ursulin
  0 siblings, 1 reply; 11+ messages in thread
From: Matthew Auld @ 2021-09-06 13:48 UTC (permalink / raw)
  To: Tvrtko Ursulin, intel-gfx
  Cc: dri-devel, Tvrtko Ursulin, Thomas Hellström

On 06/09/2021 13:53, Tvrtko Ursulin wrote:
> 
> On 06/09/2021 13:30, Matthew Auld wrote:
>> On 06/09/2021 13:19, Tvrtko Ursulin wrote:
>>>
>>> On 06/09/2021 10:17, Matthew Auld wrote:
>>>> Since the object might still be active here, the shrink_all will simply
>>>> ignore it, which blows up in the test, since the pages will still be
>>>> there. Currently THP is disabled which should result in the test being
>>>> skipped, but if we ever re-enable THP we might start seeing the 
>>>> failure.
>>>> Fix this by forcing I915_SHRINK_ACTIVE.
>>>>
>>>> v2: Some machine in the shard runs doesn't seem to have any available
>>>> swap when running this test. Try to handle this.
>>>>
>>>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>>>> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> #v1
>>>> ---
>>>>   .../gpu/drm/i915/gem/selftests/huge_pages.c   | 31 
>>>> ++++++++++++++-----
>>>>   1 file changed, 24 insertions(+), 7 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c 
>>>> b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>>>> index a094f3ce1a90..46ea1997c114 100644
>>>> --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>>>> +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>>>> @@ -1519,6 +1519,7 @@ static int igt_shrink_thp(void *arg)
>>>>       struct i915_vma *vma;
>>>>       unsigned int flags = PIN_USER;
>>>>       unsigned int n;
>>>> +    bool should_swap;
>>>>       int err = 0;
>>>>       /*
>>>> @@ -1567,23 +1568,39 @@ static int igt_shrink_thp(void *arg)
>>>>               break;
>>>>       }
>>>>       i915_gem_context_unlock_engines(ctx);
>>>> +    /*
>>>> +     * Nuke everything *before* we unpin the pages so we can be 
>>>> reasonably
>>>> +     * sure that when later checking get_nr_swap_pages() that some 
>>>> random
>>>> +     * leftover object doesn't steal the remaining swap space.
>>>> +     */
>>>> +    i915_gem_shrink(NULL, i915, -1UL, NULL,
>>>> +            I915_SHRINK_BOUND |
>>>> +            I915_SHRINK_UNBOUND |
>>>> +            I915_SHRINK_ACTIVE);
>>>>       i915_vma_unpin(vma);
>>>>       if (err)
>>>>           goto out_put;
>>>> +
>>>>       /*
>>>> -     * Now that the pages are *unpinned* shrink-all should invoke
>>>> -     * shmem to truncate our pages.
>>>> +     * Now that the pages are *unpinned* shrinking should invoke
>>>> +     * shmem to truncate our pages, if we have available swap.
>>>>        */
>>>> -    i915_gem_shrink_all(i915);
>>>> -    if (i915_gem_object_has_pages(obj)) {
>>>> -        pr_err("shrink-all didn't truncate the pages\n");
>>>> +    should_swap = get_nr_swap_pages() > 0;
>>>> +    i915_gem_shrink(NULL, i915, -1UL, NULL,
>>>> +            I915_SHRINK_BOUND |
>>>> +            I915_SHRINK_UNBOUND |
>>>> +            I915_SHRINK_ACTIVE);
>>>> +    if (should_swap == i915_gem_object_has_pages(obj)) {
>>>
>>> Hmm is there any value running the test if no swap (given objects 
>>> used by the test are "willneed"), or you could simplify and just do 
>>> early skip?
>>
>> Maybe. My thinking was that this adds some coverage if say the device 
>> is not configured with swap. i.e assert that the pages don't magically 
>> disappear, and that their contents still persist etc.
>>
>> Happy to make it skip instead though?
> 
> So reducing it to a basic shrinker test in that case. Hm.. do you know 
> if we have a non THP specific tests for that already somewhere in 
> selftests (I can't spot any), or just in IGT?

Just IGT I think, outside of some cases where we call gem_shrink in very 
specific places, which would be hard to do from an IGT.

> 
> If we indeed don't have it in selftests, then I guess question is 
> whether it is warranted to "hide" such a basic test in the THP "drawer", 
> or instead adding a generic shrinker test should be considered. (And one 
> could then follow with a question should a basic generic test have a THP 
> sub-test.)

The reason for the selftest vs IGT is mostly because userspace doesn't 
have any knowledge of the underlying pages, or whether THP is used. IIRC 
there was some issue with THP + our shmem backend in the past, so also 
adding some basic coverage for THP + i915-gem shrinker seemed 
reasonable. Even if we don't have swap space, I think it still makes 
some sense to call into gem_shrink with our target THP object.

> 
> It's hard to say where the boundary for selftests-vs-IGT coverage should 
> be in this case. I mean would it be warranted to add such a generic 
> shrinker selftest. It is mostly testable from userspace, but kernel can 
> do a few more introspections and sanity checks at cost of growing kernel 
> code.
> 
> Regards,
> 
> Tvrtko
> 
>>
>>>
>>> Regards,
>>>
>>> Tvrtko
>>>
>>>> +        pr_err("unexpected pages mismatch, should_swap=%s\n",
>>>> +               yesno(should_swap));
>>>>           err = -EINVAL;
>>>>           goto out_put;
>>>>       }
>>>> -    if (obj->mm.page_sizes.sg || obj->mm.page_sizes.phys) {
>>>> -        pr_err("residual page-size bits left\n");
>>>> +    if (should_swap == (obj->mm.page_sizes.sg || 
>>>> obj->mm.page_sizes.phys)) {
>>>> +        pr_err("unexpected residual page-size bits, should_swap=%s\n",
>>>> +               yesno(should_swap));
>>>>           err = -EINVAL;
>>>>           goto out_put;
>>>>       }
>>>>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp
  2021-09-06 12:30   ` Matthew Auld
@ 2021-09-06 12:53     ` Tvrtko Ursulin
  2021-09-06 13:48       ` Matthew Auld
  0 siblings, 1 reply; 11+ messages in thread
From: Tvrtko Ursulin @ 2021-09-06 12:53 UTC (permalink / raw)
  To: Matthew Auld, intel-gfx; +Cc: dri-devel, Tvrtko Ursulin, Thomas Hellström


On 06/09/2021 13:30, Matthew Auld wrote:
> On 06/09/2021 13:19, Tvrtko Ursulin wrote:
>>
>> On 06/09/2021 10:17, Matthew Auld wrote:
>>> Since the object might still be active here, the shrink_all will simply
>>> ignore it, which blows up in the test, since the pages will still be
>>> there. Currently THP is disabled which should result in the test being
>>> skipped, but if we ever re-enable THP we might start seeing the failure.
>>> Fix this by forcing I915_SHRINK_ACTIVE.
>>>
>>> v2: Some machine in the shard runs doesn't seem to have any available
>>> swap when running this test. Try to handle this.
>>>
>>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>>> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> #v1
>>> ---
>>>   .../gpu/drm/i915/gem/selftests/huge_pages.c   | 31 ++++++++++++++-----
>>>   1 file changed, 24 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c 
>>> b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>>> index a094f3ce1a90..46ea1997c114 100644
>>> --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>>> +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>>> @@ -1519,6 +1519,7 @@ static int igt_shrink_thp(void *arg)
>>>       struct i915_vma *vma;
>>>       unsigned int flags = PIN_USER;
>>>       unsigned int n;
>>> +    bool should_swap;
>>>       int err = 0;
>>>       /*
>>> @@ -1567,23 +1568,39 @@ static int igt_shrink_thp(void *arg)
>>>               break;
>>>       }
>>>       i915_gem_context_unlock_engines(ctx);
>>> +    /*
>>> +     * Nuke everything *before* we unpin the pages so we can be 
>>> reasonably
>>> +     * sure that when later checking get_nr_swap_pages() that some 
>>> random
>>> +     * leftover object doesn't steal the remaining swap space.
>>> +     */
>>> +    i915_gem_shrink(NULL, i915, -1UL, NULL,
>>> +            I915_SHRINK_BOUND |
>>> +            I915_SHRINK_UNBOUND |
>>> +            I915_SHRINK_ACTIVE);
>>>       i915_vma_unpin(vma);
>>>       if (err)
>>>           goto out_put;
>>> +
>>>       /*
>>> -     * Now that the pages are *unpinned* shrink-all should invoke
>>> -     * shmem to truncate our pages.
>>> +     * Now that the pages are *unpinned* shrinking should invoke
>>> +     * shmem to truncate our pages, if we have available swap.
>>>        */
>>> -    i915_gem_shrink_all(i915);
>>> -    if (i915_gem_object_has_pages(obj)) {
>>> -        pr_err("shrink-all didn't truncate the pages\n");
>>> +    should_swap = get_nr_swap_pages() > 0;
>>> +    i915_gem_shrink(NULL, i915, -1UL, NULL,
>>> +            I915_SHRINK_BOUND |
>>> +            I915_SHRINK_UNBOUND |
>>> +            I915_SHRINK_ACTIVE);
>>> +    if (should_swap == i915_gem_object_has_pages(obj)) {
>>
>> Hmm is there any value running the test if no swap (given objects used 
>> by the test are "willneed"), or you could simplify and just do early 
>> skip?
> 
> Maybe. My thinking was that this adds some coverage if say the device is 
> not configured with swap. i.e assert that the pages don't magically 
> disappear, and that their contents still persist etc.
> 
> Happy to make it skip instead though?

So reducing it to a basic shrinker test in that case. Hm.. do you know 
if we have a non THP specific tests for that already somewhere in 
selftests (I can't spot any), or just in IGT?

If we indeed don't have it in selftests, then I guess question is 
whether it is warranted to "hide" such a basic test in the THP "drawer", 
or instead adding a generic shrinker test should be considered. (And one 
could then follow with a question should a basic generic test have a THP 
sub-test.)

It's hard to say where the boundary for selftests-vs-IGT coverage should 
be in this case. I mean would it be warranted to add such a generic 
shrinker selftest. It is mostly testable from userspace, but kernel can 
do a few more introspections and sanity checks at cost of growing kernel 
code.

Regards,

Tvrtko

> 
>>
>> Regards,
>>
>> Tvrtko
>>
>>> +        pr_err("unexpected pages mismatch, should_swap=%s\n",
>>> +               yesno(should_swap));
>>>           err = -EINVAL;
>>>           goto out_put;
>>>       }
>>> -    if (obj->mm.page_sizes.sg || obj->mm.page_sizes.phys) {
>>> -        pr_err("residual page-size bits left\n");
>>> +    if (should_swap == (obj->mm.page_sizes.sg || 
>>> obj->mm.page_sizes.phys)) {
>>> +        pr_err("unexpected residual page-size bits, should_swap=%s\n",
>>> +               yesno(should_swap));
>>>           err = -EINVAL;
>>>           goto out_put;
>>>       }
>>>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp
  2021-09-06 12:19 ` Tvrtko Ursulin
@ 2021-09-06 12:30   ` Matthew Auld
  2021-09-06 12:53     ` Tvrtko Ursulin
  0 siblings, 1 reply; 11+ messages in thread
From: Matthew Auld @ 2021-09-06 12:30 UTC (permalink / raw)
  To: Tvrtko Ursulin, intel-gfx
  Cc: dri-devel, Tvrtko Ursulin, Thomas Hellström

On 06/09/2021 13:19, Tvrtko Ursulin wrote:
> 
> On 06/09/2021 10:17, Matthew Auld wrote:
>> Since the object might still be active here, the shrink_all will simply
>> ignore it, which blows up in the test, since the pages will still be
>> there. Currently THP is disabled which should result in the test being
>> skipped, but if we ever re-enable THP we might start seeing the failure.
>> Fix this by forcing I915_SHRINK_ACTIVE.
>>
>> v2: Some machine in the shard runs doesn't seem to have any available
>> swap when running this test. Try to handle this.
>>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> #v1
>> ---
>>   .../gpu/drm/i915/gem/selftests/huge_pages.c   | 31 ++++++++++++++-----
>>   1 file changed, 24 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c 
>> b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>> index a094f3ce1a90..46ea1997c114 100644
>> --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>> +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
>> @@ -1519,6 +1519,7 @@ static int igt_shrink_thp(void *arg)
>>       struct i915_vma *vma;
>>       unsigned int flags = PIN_USER;
>>       unsigned int n;
>> +    bool should_swap;
>>       int err = 0;
>>       /*
>> @@ -1567,23 +1568,39 @@ static int igt_shrink_thp(void *arg)
>>               break;
>>       }
>>       i915_gem_context_unlock_engines(ctx);
>> +    /*
>> +     * Nuke everything *before* we unpin the pages so we can be 
>> reasonably
>> +     * sure that when later checking get_nr_swap_pages() that some 
>> random
>> +     * leftover object doesn't steal the remaining swap space.
>> +     */
>> +    i915_gem_shrink(NULL, i915, -1UL, NULL,
>> +            I915_SHRINK_BOUND |
>> +            I915_SHRINK_UNBOUND |
>> +            I915_SHRINK_ACTIVE);
>>       i915_vma_unpin(vma);
>>       if (err)
>>           goto out_put;
>> +
>>       /*
>> -     * Now that the pages are *unpinned* shrink-all should invoke
>> -     * shmem to truncate our pages.
>> +     * Now that the pages are *unpinned* shrinking should invoke
>> +     * shmem to truncate our pages, if we have available swap.
>>        */
>> -    i915_gem_shrink_all(i915);
>> -    if (i915_gem_object_has_pages(obj)) {
>> -        pr_err("shrink-all didn't truncate the pages\n");
>> +    should_swap = get_nr_swap_pages() > 0;
>> +    i915_gem_shrink(NULL, i915, -1UL, NULL,
>> +            I915_SHRINK_BOUND |
>> +            I915_SHRINK_UNBOUND |
>> +            I915_SHRINK_ACTIVE);
>> +    if (should_swap == i915_gem_object_has_pages(obj)) {
> 
> Hmm is there any value running the test if no swap (given objects used 
> by the test are "willneed"), or you could simplify and just do early skip?

Maybe. My thinking was that this adds some coverage if say the device is 
not configured with swap. i.e assert that the pages don't magically 
disappear, and that their contents still persist etc.

Happy to make it skip instead though?

> 
> Regards,
> 
> Tvrtko
> 
>> +        pr_err("unexpected pages mismatch, should_swap=%s\n",
>> +               yesno(should_swap));
>>           err = -EINVAL;
>>           goto out_put;
>>       }
>> -    if (obj->mm.page_sizes.sg || obj->mm.page_sizes.phys) {
>> -        pr_err("residual page-size bits left\n");
>> +    if (should_swap == (obj->mm.page_sizes.sg || 
>> obj->mm.page_sizes.phys)) {
>> +        pr_err("unexpected residual page-size bits, should_swap=%s\n",
>> +               yesno(should_swap));
>>           err = -EINVAL;
>>           goto out_put;
>>       }
>>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp
  2021-09-06  9:17 Matthew Auld
@ 2021-09-06 12:19 ` Tvrtko Ursulin
  2021-09-06 12:30   ` Matthew Auld
  0 siblings, 1 reply; 11+ messages in thread
From: Tvrtko Ursulin @ 2021-09-06 12:19 UTC (permalink / raw)
  To: Matthew Auld, intel-gfx; +Cc: dri-devel, Tvrtko Ursulin, Thomas Hellström


On 06/09/2021 10:17, Matthew Auld wrote:
> Since the object might still be active here, the shrink_all will simply
> ignore it, which blows up in the test, since the pages will still be
> there. Currently THP is disabled which should result in the test being
> skipped, but if we ever re-enable THP we might start seeing the failure.
> Fix this by forcing I915_SHRINK_ACTIVE.
> 
> v2: Some machine in the shard runs doesn't seem to have any available
> swap when running this test. Try to handle this.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> #v1
> ---
>   .../gpu/drm/i915/gem/selftests/huge_pages.c   | 31 ++++++++++++++-----
>   1 file changed, 24 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> index a094f3ce1a90..46ea1997c114 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> @@ -1519,6 +1519,7 @@ static int igt_shrink_thp(void *arg)
>   	struct i915_vma *vma;
>   	unsigned int flags = PIN_USER;
>   	unsigned int n;
> +	bool should_swap;
>   	int err = 0;
>   
>   	/*
> @@ -1567,23 +1568,39 @@ static int igt_shrink_thp(void *arg)
>   			break;
>   	}
>   	i915_gem_context_unlock_engines(ctx);
> +	/*
> +	 * Nuke everything *before* we unpin the pages so we can be reasonably
> +	 * sure that when later checking get_nr_swap_pages() that some random
> +	 * leftover object doesn't steal the remaining swap space.
> +	 */
> +	i915_gem_shrink(NULL, i915, -1UL, NULL,
> +			I915_SHRINK_BOUND |
> +			I915_SHRINK_UNBOUND |
> +			I915_SHRINK_ACTIVE);
>   	i915_vma_unpin(vma);
>   	if (err)
>   		goto out_put;
>   
> +
>   	/*
> -	 * Now that the pages are *unpinned* shrink-all should invoke
> -	 * shmem to truncate our pages.
> +	 * Now that the pages are *unpinned* shrinking should invoke
> +	 * shmem to truncate our pages, if we have available swap.
>   	 */
> -	i915_gem_shrink_all(i915);
> -	if (i915_gem_object_has_pages(obj)) {
> -		pr_err("shrink-all didn't truncate the pages\n");
> +	should_swap = get_nr_swap_pages() > 0;
> +	i915_gem_shrink(NULL, i915, -1UL, NULL,
> +			I915_SHRINK_BOUND |
> +			I915_SHRINK_UNBOUND |
> +			I915_SHRINK_ACTIVE);
> +	if (should_swap == i915_gem_object_has_pages(obj)) {

Hmm is there any value running the test if no swap (given objects used 
by the test are "willneed"), or you could simplify and just do early skip?

Regards,

Tvrtko

> +		pr_err("unexpected pages mismatch, should_swap=%s\n",
> +		       yesno(should_swap));
>   		err = -EINVAL;
>   		goto out_put;
>   	}
>   
> -	if (obj->mm.page_sizes.sg || obj->mm.page_sizes.phys) {
> -		pr_err("residual page-size bits left\n");
> +	if (should_swap == (obj->mm.page_sizes.sg || obj->mm.page_sizes.phys)) {
> +		pr_err("unexpected residual page-size bits, should_swap=%s\n",
> +		       yesno(should_swap));
>   		err = -EINVAL;
>   		goto out_put;
>   	}
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp
@ 2021-09-06  9:17 Matthew Auld
  2021-09-06 12:19 ` Tvrtko Ursulin
  0 siblings, 1 reply; 11+ messages in thread
From: Matthew Auld @ 2021-09-06  9:17 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel, Tvrtko Ursulin, Thomas Hellström

Since the object might still be active here, the shrink_all will simply
ignore it, which blows up in the test, since the pages will still be
there. Currently THP is disabled which should result in the test being
skipped, but if we ever re-enable THP we might start seeing the failure.
Fix this by forcing I915_SHRINK_ACTIVE.

v2: Some machine in the shard runs doesn't seem to have any available
swap when running this test. Try to handle this.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> #v1
---
 .../gpu/drm/i915/gem/selftests/huge_pages.c   | 31 ++++++++++++++-----
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
index a094f3ce1a90..46ea1997c114 100644
--- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
+++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
@@ -1519,6 +1519,7 @@ static int igt_shrink_thp(void *arg)
 	struct i915_vma *vma;
 	unsigned int flags = PIN_USER;
 	unsigned int n;
+	bool should_swap;
 	int err = 0;
 
 	/*
@@ -1567,23 +1568,39 @@ static int igt_shrink_thp(void *arg)
 			break;
 	}
 	i915_gem_context_unlock_engines(ctx);
+	/*
+	 * Nuke everything *before* we unpin the pages so we can be reasonably
+	 * sure that when later checking get_nr_swap_pages() that some random
+	 * leftover object doesn't steal the remaining swap space.
+	 */
+	i915_gem_shrink(NULL, i915, -1UL, NULL,
+			I915_SHRINK_BOUND |
+			I915_SHRINK_UNBOUND |
+			I915_SHRINK_ACTIVE);
 	i915_vma_unpin(vma);
 	if (err)
 		goto out_put;
 
+
 	/*
-	 * Now that the pages are *unpinned* shrink-all should invoke
-	 * shmem to truncate our pages.
+	 * Now that the pages are *unpinned* shrinking should invoke
+	 * shmem to truncate our pages, if we have available swap.
 	 */
-	i915_gem_shrink_all(i915);
-	if (i915_gem_object_has_pages(obj)) {
-		pr_err("shrink-all didn't truncate the pages\n");
+	should_swap = get_nr_swap_pages() > 0;
+	i915_gem_shrink(NULL, i915, -1UL, NULL,
+			I915_SHRINK_BOUND |
+			I915_SHRINK_UNBOUND |
+			I915_SHRINK_ACTIVE);
+	if (should_swap == i915_gem_object_has_pages(obj)) {
+		pr_err("unexpected pages mismatch, should_swap=%s\n",
+		       yesno(should_swap));
 		err = -EINVAL;
 		goto out_put;
 	}
 
-	if (obj->mm.page_sizes.sg || obj->mm.page_sizes.phys) {
-		pr_err("residual page-size bits left\n");
+	if (should_swap == (obj->mm.page_sizes.sg || obj->mm.page_sizes.phys)) {
+		pr_err("unexpected residual page-size bits, should_swap=%s\n",
+		       yesno(should_swap));
 		err = -EINVAL;
 		goto out_put;
 	}
-- 
2.26.3


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-09-06 15:52 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 15:50 [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp Matthew Auld
2021-07-28 16:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-28 19:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-07-29 10:53 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2021-07-29 10:55   ` Matthew Auld
2021-09-06  9:17 Matthew Auld
2021-09-06 12:19 ` Tvrtko Ursulin
2021-09-06 12:30   ` Matthew Auld
2021-09-06 12:53     ` Tvrtko Ursulin
2021-09-06 13:48       ` Matthew Auld
2021-09-06 15:52         ` Tvrtko Ursulin

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox