From: Pekka Enberg <penberg@kernel.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
keith.packard@intel.com, danie.vettel@ffwll.ch
Subject: Re: [PATCH] drm/i915: Disable all outputs early, before KMS takeover
Date: Tue, 5 Apr 2011 18:44:26 +0300 [thread overview]
Message-ID: <BANLkTi=JPoxZAq4YuWJF3P8MULuwTM9Taw@mail.gmail.com> (raw)
In-Reply-To: <b9dded$iivmhh@orsmga002.jf.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2341 bytes --]
On Tue, Apr 5, 2011 at 6:32 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, 5 Apr 2011 18:11:37 +0300, Pekka Enberg <penberg@kernel.org> wrote:
>> Hi Chris,
>>
>> On Tue, Apr 5, 2011 at 5:34 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > If the outputs are active and continuing to access the GATT when we
>> > teardown the PTEs, then there is a potential for us to hang the GPU.
>> > The hang tends to be a PGTBL_ER with either an invalid host access or
>> > an invalid display plane fetch.
>> >
>> > v2: Reorder IRQ initialisation to defer until after GEM is setup.
>> >
>> > Reported-by: Pekka Enberg <penberg@kernel.org>
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > Tested-by: Daniel Vetter <daniel.vetter@ffwll.ch> (855GM)
>>
>> I no longer get a blank screen after boot but flicker got more
>> aggressive during boot (it calms down after I've logged in). I see
>> tons of these in dmesg that don't appear with 2.6.39-rc1:
>
> Well the PGTBL_ER is still there. I'm thinking it might worth a check to
> see if that is asserted even before we start...
>
>> [ 10.175843] [drm:intel_update_fbc],
>> [ 10.183100] [drm:i915_driver_irq_handler], pipe A underrun
>> [ 10.185085] [drm:i915_driver_irq_handler], pipe A underrun
>> [ 10.186082] [drm:i915_driver_irq_handler], pipe A underrun
>> [ 10.187087] [drm:i915_driver_irq_handler], pipe A underrun
>> [ 10.189082] [drm:i915_driver_irq_handler], pipe A underrun
>> [ 10.190085] [drm:i915_driver_irq_handler], pipe A underrun
>
> If I'm understanding the dmesg correctly, then these start even before we
> setup the first crtc.
>
> Whether that means we're not completely disabling all outputs or that we
> set a register incorrectly I don't know. Comparing an intel_reg_dumper
> with and without the patch applied might give a clue if it is a register
> that is set differently due to the reordering.
>
> The other question is of course whether you see those in 2.6.39-rc1 as
> well... Probably not since they will correspond with the increased
> flicker.
Actually, I do. I guess that logging is enabled by 'drm.debug=0xe'?
I've included dmesg from latest Linus master.
As for the v2 of the patch:
Tested-by: Pekka Enberg <penberg@kernel.org> (i915)
Pekka
[-- Attachment #2: dmesg.gz --]
[-- Type: application/x-gzip, Size: 29227 bytes --]
next prev parent reply other threads:[~2011-04-05 15:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTi=VqkYjdiDLJvM-OfmBSGx-EkRkt=4XCDEnvZsU@mail.gmail.com>
2011-03-29 10:46 ` [PATCH] drm/i915: Disable all outputs early, before KMS takeover Chris Wilson
2011-03-29 12:23 ` [PATCH] drm/i915: Move the irq wait queue initialisation into the ring init Chris Wilson
2011-03-29 13:05 ` Pekka Enberg
2011-03-29 13:22 ` Chris Wilson
2011-03-29 13:39 ` Pekka Enberg
2011-03-29 14:22 ` Pekka Enberg
2011-03-29 14:32 ` Chris Wilson
2011-03-29 15:21 ` Pekka Enberg
2011-04-01 11:44 ` [PATCH] drm/i915: Disable all outputs early, before KMS takeover Daniel Vetter
2011-04-01 11:51 ` [Intel-gfx] " Pekka Enberg
2011-04-05 10:21 ` Tomas Winkler
2011-04-05 10:30 ` Chris Wilson
2011-04-05 10:37 ` Pekka Enberg
2011-04-05 11:55 ` Tomas Winkler
2011-04-05 14:11 ` Pekka Enberg
2011-04-05 14:27 ` Chris Wilson
2011-04-05 14:31 ` [Intel-gfx] " Pekka Enberg
2011-04-05 14:34 ` Chris Wilson
2011-04-05 15:11 ` Pekka Enberg
2011-04-05 15:32 ` Chris Wilson
2011-04-05 15:44 ` Pekka Enberg [this message]
2011-04-05 14:42 ` Linus Torvalds
2011-04-05 15:01 ` Keith Packard
2011-04-05 15:12 ` [Intel-gfx] " Chris Wilson
2011-04-05 15:35 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=JPoxZAq4YuWJF3P8MULuwTM9Taw@mail.gmail.com' \
--to=penberg@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=danie.vettel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keith.packard@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).