intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Pandey, Hariom" <hariom.pandey@intel.com>
To: "K, SrinivasX" <srinivasx.k@intel.com>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection
Date: Fri, 9 Oct 2020 18:08:32 +0000	[thread overview]
Message-ID: <BY5PR11MB44341733BF4A7CCB79861322F6080@BY5PR11MB4434.namprd11.prod.outlook.com> (raw)
In-Reply-To: <B6C174E8-161A-43BD-AFDA-21C94F6D56E3@intel.com>

Hi Srinivas,

Take Sunil's help who has recently validated RC6 on EHL DRM tip and found to be passing. If the WA were sporadically failing and if you confirm that RC6 is passing, this patch can be proceeded with. 

Thanks
Hariom Pandey

-----Original Message-----
From: Vivi, Rodrigo <rodrigo.vivi@intel.com> 
Sent: Friday, October 9, 2020 7:09 PM
To: K, SrinivasX <srinivasx.k@intel.com>
Cc: Souza, Jose <jose.souza@intel.com>; chris@chris-wilson.co.uk; Ausmus, James <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Pandey, Hariom <hariom.pandey@intel.com>; Roper, Matthew D <matthew.d.roper@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection



> On Oct 9, 2020, at 1:31 AM, K, SrinivasX <srinivasx.k@intel.com> wrote:
> 
> Hi Rodrigo,
> 
> How do we get W/A and rc6 changes in, do you have any details?

I told based on what I was seeing on https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html?
focusing on the issues that are exclusively for ehl and not happening on other platforms.

It looks like workarounds are fine there now. so I'm not sure if it was sporadic thing that day.

for the rc6 there are a few testcases failing around it:
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_residency@rc6-fence.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_residency@rc6-idle.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_selftest@live@gt_pm.html#dmesg-warnings415

> 
> Thanks,
> Srinivas
> 
> -----Original Message-----
> From: Souza, Jose <jose.souza@intel.com>
> Sent: 06 October 2020 23:33
> To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; chris@chris-wilson.co.uk
> Cc: Ausmus, James <james.ausmus@intel.com>; Nikula, Jani 
> <jani.nikula@intel.com>; Pandey, Hariom <hariom.pandey@intel.com>; 
> Roper, Matthew D <matthew.d.roper@intel.com>; 
> intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; K, 
> SrinivasX <srinivasx.k@intel.com>; Surendrakumar Upadhyay, TejaskumarX 
> <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove 
> require_force_probe protection
> 
> On Tue, 2020-10-06 at 10:55 -0700, Vivi, Rodrigo wrote:
>> 
>>> On Oct 6, 2020, at 10:48 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> 
>>> Quoting Souza, Jose (2020-10-06 18:46:45)
>>>> +Rodrigo and Jani
>>>> 
>>>> On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
>>>>> Removing force probe protection from EHL platform. Did not observe 
>>>>> warnings, errors, flickering or any visual defects while doing 
>>>>> ordinary tasks like browsing and editing documents in a two 
>>>>> monitor setup.
>>>> 
>>>> One of the requirements was also to have CI BAT all green and 
>>>> shards as green is possible but EHL don't show up in CI results, we actually have one single EHL machine in CI but I guess it is not able to run all tests that shards do:
>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html
>>> 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html
>> 
>> we are really close to that point. We just need to fix some w/a and
>> rc6 issues before applying this change.
>> 
>>> -Chris
>> 
> 
> Huum okay we have drm-tip results for EHL but if someone sends a patch that breaks EHL it will not be caught in pre-merge testing.
> 


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-10-09 18:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 14:56 [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection Kamati Srinivas
2020-10-06 15:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-06 17:46 ` [Intel-gfx] [PATCH] " Souza, Jose
2020-10-06 17:48   ` Chris Wilson
2020-10-06 17:55     ` Vivi, Rodrigo
2020-10-06 18:02       ` Souza, Jose
2020-10-09  8:31         ` K, SrinivasX
2020-10-09 13:38           ` Vivi, Rodrigo
2020-10-09 18:08             ` Pandey, Hariom [this message]
2020-10-15  8:41               ` K, SrinivasX
2020-10-19 18:29                 ` Rodrigo Vivi
2020-10-19 18:33                   ` Chris Wilson
     [not found]                     ` <CO1PR11MB50750A169A14FCC84C70C936F61F0@CO1PR11MB5075.namprd11.prod.outlook.com>
     [not found]                       ` <CO1PR11MB5075AAFA3500F4A3A610FC52F6170@CO1PR11MB5075.namprd11.prod.outlook.com>
2020-10-28 11:53                         ` Vivi, Rodrigo
2020-10-28 11:55                           ` Pandey, Hariom
2020-11-27 20:36                             ` Chris Wilson
2020-10-06 20:12 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2021-06-29 10:49 [Intel-gfx] [PATCH] " Tejas Upadhyay
2021-06-29 15:18 ` Rodrigo Vivi
2021-06-29 15:20   ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR11MB44341733BF4A7CCB79861322F6080@BY5PR11MB4434.namprd11.prod.outlook.com \
    --to=hariom.pandey@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=srinivasx.k@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).