From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF969C4338F for ; Wed, 28 Jul 2021 14:40:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F45B6054F for ; Wed, 28 Jul 2021 14:40:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8F45B6054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 42C996E040; Wed, 28 Jul 2021 14:40:17 +0000 (UTC) Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) by gabe.freedesktop.org (Postfix) with ESMTPS id C58816E040; Wed, 28 Jul 2021 14:40:16 +0000 (UTC) Received: by mail-ua1-x92f.google.com with SMTP id v3so1197033uau.3; Wed, 28 Jul 2021 07:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gy/xEIwD/4wzE9AqH6vhN+tSbWlmdiFtY8oiM2gmEG0=; b=TB0d1d+Ax2PLNyC3+GFUdGDreDP3BoBSFSOPGzZ6WZyyFsTPWKeQnv8MMAs6RUDLXr /Vz1+J1ztxg1yM1QxaPR+IOybQqwqnUGwAc5gyc81hraGz6JV6yZailQVB98eJWRvI3+ /hHEWxWpdQd4KUbXceZGbfkHFai0F6L3hZpCAAixyGv8Engvrp7OjjEZsBxGnnb5qHr1 7R/R1TaKnFUBE7mCYF6fN/3rXe85Pr1db9bTxWz1Yepr+5wVtVjj6ieApmjkYf3rbX4w sHzQOhl4nmipVgLoy4MXgY/h48q9KLHpvN1iQclmYrT7C/asLUxK+TW6O2K+tCGdzSor /oQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gy/xEIwD/4wzE9AqH6vhN+tSbWlmdiFtY8oiM2gmEG0=; b=hhtEXmIe2hsE+/tSQQq3ea1o4h+YbJGqGdGUTCFtaxRieZ3M2oVEI3azqbC87zdAma wnxnd6vzMuFNdlPm7g3KOGztTJ9LQ6T5UN+aptHZgpDcHS0Bt6VFNDtE9IP2BFdY+Az4 NqNQHKvudrBdAZx6QYZ48quNC8eM+B4y+CsFL1QUw1g9v1Yn4yMAfRfe8uTf+M1qkg6o 96EbfZ8oad05m4Oba+Ei3kC0km0znOgrvYWMDoYsbyZuHoUXllmn4uM2JcXdgHx7qDsk nc2BCEHZZ5WpLfYcsI/dVwFFX7Bcvq3zXqMjwNqmJe/BPsVZIgWvRa624JAywTMOXcr+ lkTg== X-Gm-Message-State: AOAM5316tZUwCK+i18cGNL+lTBfNyaq8Gqgs3KuHnKsEH+fpgRUhruVR IpRtGIcwWUWY5Tvh0akooj3WQX1dYn9ike5OH7U= X-Google-Smtp-Source: ABdhPJzw76LXfLoDCvAdTGV1bDUpE3FI0q8/Gg59XtoCCOUTfBE/DrFK7SrC+4QcQTNspTl+nQEAlzwlHPd7OT1kG2A= X-Received: by 2002:ab0:6dcb:: with SMTP id r11mr116755uaf.128.1627483215360; Wed, 28 Jul 2021 07:40:15 -0700 (PDT) MIME-Version: 1.0 References: <20210721175526.22020-1-sean@poorly.run> <20210721175526.22020-4-sean@poorly.run> In-Reply-To: <20210721175526.22020-4-sean@poorly.run> From: jim.cromie@gmail.com Date: Wed, 28 Jul 2021 10:39:48 -0400 Message-ID: To: Sean Paul Subject: Re: [Intel-gfx] [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, ppaalanen@gmail.com, Sean Paul , Thomas Zimmermann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jul 21, 2021 at 1:55 PM Sean Paul wrote: > > From: Sean Paul > > Use drm logging helpers to add support for the upcoming tracefs > implementation. > > Signed-off-by: Sean Paul > Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-4-sean@poorly.run #v5 > > Changes in v5: > -Added to the set > Changes in v6: > -None > --- > drivers/gpu/drm/i915/i915_utils.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c > index f9e780dee9de..d858c92c6997 100644 > --- a/drivers/gpu/drm/i915/i915_utils.c > +++ b/drivers/gpu/drm/i915/i915_utils.c > @@ -30,10 +30,9 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level, > vaf.va = &args; > > if (is_error) > - dev_printk(level, kdev, "%pV", &vaf); > + drm_dev_printk(kdev, level, "%pV", &vaf); > else > - dev_printk(level, kdev, "[" DRM_NAME ":%ps] %pV", > - __builtin_return_address(0), &vaf); > + drm_err(&dev_priv->drm, "%pV", &vaf); its slightly jarring to see drm_err() in the !is_err branch. warn or notice seems better. > > va_end(args); > > -- > Sean Paul, Software Engineer, Google / Chromium OS > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx