From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 09/81] drm/i915/lvds: ditch ->prepare special case Date: Sun, 22 Jul 2012 21:20:20 +0200 Message-ID: References: <1342016944-23395-1-git-send-email-daniel.vetter@ffwll.ch> <1342016944-23395-10-git-send-email-daniel.vetter@ffwll.ch> <20120722145254.GB5119@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ob0-f177.google.com (mail-ob0-f177.google.com [209.85.214.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 710AD9E93D for ; Sun, 22 Jul 2012 12:20:21 -0700 (PDT) Received: by obbta17 with SMTP id ta17so8846307obb.36 for ; Sun, 22 Jul 2012 12:20:20 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Takashi Iwai Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Sun, Jul 22, 2012 at 6:32 PM, Takashi Iwai wrote: > At Sun, 22 Jul 2012 16:52:54 +0200, > Daniel Vetter wrote: >> >> On Wed, Jul 11, 2012 at 04:27:52PM +0200, Daniel Vetter wrote: >> > LVDS is the first output where dpms on/off and prepare/commit don't >> > perfectly match. Now the idea behind this special case seems to be >> > that for simple resolution changes on the LVDS we don't need to stop >> > the pipe, because (at least on newer chips) we can adjust the panel >> > fitter on the fly. >> > >> > There are a few problems with the current code though: >> > - We still stop and restart the pipe unconditionally, because the crtc >> > helper code isn't flexible enough. >> > - We show some ugly flickering, especially when changing crtcs (this >> > the crtc helper would actually take into account, but we don't >> > implement the encoder->get_crtc callback required to make this work >> > properly). >> > >> > So it doesn't even work as advertised. I agree that it would be nice >> > to do resolution changes on LVDS (and also eDP) whithout blacking the >> > screen where the panel fitter allows to do that. But imo we should >> > implement this as a special case a few layers up in the mode set code, >> > akin to how we already detect simple framebuffer changes (and only >> > update the required registers with ->mode_set_base). >> > >> > Until this is all in place, make our lives easier and just rip it out. >> > >> > Also note that this seems to fix actual bugs with enabling the lvds >> > output, see: >> > >> > http://lists.freedesktop.org/archives/intel-gfx/2012-July/018614.html >> > >> > Cc: Takashi Iwai >> > Cc: Giacomo Comes >> > Signed-Off-by: Daniel Vetter >> >> I've merged this with Chris' irc-ack (under the condition that the >> modeset-rework leads to reinstated lvds fastpath that actually works >> eventually). I've stalled a bit for tested-bys from Takashi, but he seems >> to be awol atm. > > Sorry, I was too busy for other tasks after vacation. > Tested on a few machines and it worked as expected. > > Tested-by: Takashi Iwai No problem ;-) and thanks for putting the patches through it's paces on a few bothersome machines. Tested-by added to the patch. -Daniel -- Daniel Vetter daniel.vetter@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch