From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/i915: clear up wedged transitions
Date: Wed, 5 Dec 2012 18:14:16 +0100
Message-ID: <CAKMK7uGbuH4pcUt2bhZjQ+bGC5ZS06GZ9cLDyigdNt31Jn8irQ@mail.gmail.com>
References: <1352909648-21514-1-git-send-email-daniel.vetter@ffwll.ch>
	<1352996243-15590-1-git-send-email-daniel.vetter@ffwll.ch>
	<CAPX-8+-xbxDJeh9NrwL=AejuXXph1=e=zk3KTW7Hi8Y92dePOg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com
	[209.85.214.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 9474FE5EBD
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  5 Dec 2012 09:14:17 -0800 (PST)
Received: by mail-bk0-f49.google.com with SMTP id jm19so2258922bkc.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 05 Dec 2012 09:14:16 -0800 (PST)
In-Reply-To: <CAPX-8+-xbxDJeh9NrwL=AejuXXph1=e=zk3KTW7Hi8Y92dePOg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Dec 5, 2012 at 5:38 PM, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Thu, Nov 15, 2012 at 4:17 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -1596,7 +1596,7 @@ i915_wedged_read(struct file *filp,
>>
>>         len = snprintf(buf, sizeof(buf),
>>                        "wedged :  %d\n",
>> -                      atomic_read(&dev_priv->gpu_error.wedged));
>> +                      atomic_read(&dev_priv->gpu_error.reset_counter));
>
> I was wondering if you might want to expose wedge as
> (gpu_error.reset_counter == I915_WEDGED) and have a separate
> reset_counter set to (gpu_error.reset_counter >> 1)

Other interfaces are equally raw in debugfs, so I've figured this is
good enough ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch