From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 869A5C433DF for ; Tue, 28 Jul 2020 18:09:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C7B02070B for ; Tue, 28 Jul 2020 18:09:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="odD2waQe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C7B02070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 00B726E225; Tue, 28 Jul 2020 18:09:04 +0000 (UTC) Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by gabe.freedesktop.org (Postfix) with ESMTPS id CBE326E225 for ; Tue, 28 Jul 2020 18:09:02 +0000 (UTC) Received: by mail-vs1-xe44.google.com with SMTP id w22so6114310vsi.3 for ; Tue, 28 Jul 2020 11:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UlAqnJDu8QlBzQA9UJI8pg/meooLkpX75b3ti+y2Wjk=; b=odD2waQeo1ANhmCVE++WNYQDCXrJg1FWwu017ri789eDQ8cU+MEHR6mtmJFgcewe/6 G4qU2sfutWEQ9FxwgYS34i7n4c4PlpcEAEA6FlJHk5wwr5fGJPUT8d1Vav0jTzAMKEc3 f8gOjZDMyTuItemkaYZKFvfEIS0+E5vaaHyqiPsesJ7Fw134pdMA6O7UdFzu66FX1iXq iGuaAS/iV5SmWj1OfxA5wdlCO5yCGyLXzZIzuS+SkFDJ7oQG4ZJy6GcGCGI3EqNHj/I1 AetdKFkSw/O++MmPgEU4Y3uubbaJi7E8RcO2MVccE345BZDJkqJ06P8HWJ5Pgdkm041l dcTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UlAqnJDu8QlBzQA9UJI8pg/meooLkpX75b3ti+y2Wjk=; b=GzxBzrccFpNH2qkU+yyAN3o/h/HGFG6wQykDXyqcbGAZFeQZd3Mv+e9/vBJRQJmGbQ HGm+ng3cVVnssRSjT5Og4zd6dCZMRZT8FUluapzozTxYRFDFsD1Zp1d2cqveLq/PSmkS Bd8JU3GtSEfzHrEIcfeIyMf7JYZdnmi1DuB9holblY2Ndv6SniJNNRVglv0yzl8FK2wg rb8OQyL7hzeXPW72jdWye4SGZmzlDMRfpmbOcvAYP0klZfLhuVFu0tQ8KuwKcJ1Tg6rf R2slXbluJ2pB72+OcLTa0LmgFmftqxejZPRUxjM6UVsTqVrZxXrzZjpobyrccKb1gMSg 7h6w== X-Gm-Message-State: AOAM533bvvRpTLaLVoaeT+SdlhpLsIBl3glK5EK+urTCVrZWo2XY7b2K S0d5b5bKEv+MSqN5j10y29EfMETXDB1GHwHS5c7BbzX+ X-Google-Smtp-Source: ABdhPJxXXhCfsyWtsd3LCoIPQgOnxjed1Ru4uNceGEn5pNW978u9HJupVyLET4xF1YNOzLQ4l27kxoFYrArDouJEfss= X-Received: by 2002:a67:7d81:: with SMTP id y123mr11790663vsc.178.1595959742016; Tue, 28 Jul 2020 11:09:02 -0700 (PDT) MIME-Version: 1.0 References: <20200728155935.17708-1-chris@chris-wilson.co.uk> In-Reply-To: <20200728155935.17708-1-chris@chris-wilson.co.uk> From: Matthew Auld Date: Tue, 28 Jul 2020 19:08:35 +0100 Message-ID: To: Chris Wilson Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Delay taking the spinlock for grabbing from the buffer pool X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 28 Jul 2020 at 16:59, Chris Wilson wrote: > > Some very low hanging fruit, but contention on the pool->lock is > noticeable between intel_gt_get_buffer_pool() and pool_retire(), with > the majority of the hold time due to the locked list iteration. If we > make the node itself RCU protected, we can perform the search for an > suitable node just under RCU, reserving taking the lock itself for > claiming the node and manipulating the list. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx