From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B4ECC1975A for ; Thu, 12 Mar 2020 17:01:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D7F3206F1 for ; Thu, 12 Mar 2020 17:01:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C3OzjUCm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D7F3206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA46F89801; Thu, 12 Mar 2020 17:01:27 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BEFD89801 for ; Thu, 12 Mar 2020 17:01:27 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id e18so7256306ljn.12 for ; Thu, 12 Mar 2020 10:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=64QWCKeN5lDwHCCMolMW5xu+X9rgWj7+rIyxLsgsIEw=; b=C3OzjUCm91v7Jnt7AJx2P3dnWyATQm7yrDdp9ZnzEWv7hjXeukXigJapd5ODbbx/pl ODujLlNI8onY6uy9Fp83o4H6poEFTycTXc7NjqqJLxbYHAJrN+HFuX8AWAF0m0cPXXFb NLSoEQEsZou3xYMqlm9sr6f3jhVITTkhONGcO3oltYW50QeVV2jlhqZ1MGQ9V5sY2qn5 /8GqDBx0VXdgfk1sGyflArui+iSKn9f9h4OH9Ot+98vSVybEIzrrW25aeCHiCWzUsKo4 ZbQ0murflSTEzTr9Zd2oeLPwliG+A4KImy5K5Uriu/dWh8gLhX61AzbXm6zm0VBJClju SJtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=64QWCKeN5lDwHCCMolMW5xu+X9rgWj7+rIyxLsgsIEw=; b=gw/S7gu+94PuSSjyf3XEvdH3Ua/vls33FOmHI3tlfyV00Lms34yxl8iZW5+uy6AnSt U4V4eTVpkdrUrJb8F2I6cX8bLZufyR8mMIDBxzhzBjZHMwLvMnehB7m8iLO2ld6dcwx7 3JPOTuj2O0HTMimc4xBWIhXcZEulMeiksj7jZQ5vAGL/r3+/p4IsyoDdx87pe0qZNF9k VulZsrKqX86OkmNFW2RUdCu9cOODPfiIHN1Cjdxg1p3fQFLmbioQjhbKJDFbRN7K7cGF dtXoqCWMgmpqAz4w0y5Umg0UxH1DYoS0VxDLdMZDXxJZbBbXNh8690fI/pJTEV8wphEj GydQ== X-Gm-Message-State: ANhLgQ2tZAu+lIpm2RxP6u3CPFdjnhCW2suLtpnspa3AFtu45tjo+69F NsZr6wao+meZDqB25h2NN+9FBOZ5/tOJMP+7DSk= X-Google-Smtp-Source: ADFU+vtFw1wXR4eQyHd1j31pVZNLugy8mr/NTb6hKU3QC2an2rwMWW8JVdlJheaTcveTI4a546Ii0yRCNin4roFRCgc= X-Received: by 2002:a2e:984d:: with SMTP id e13mr5409462ljj.275.1584032485490; Thu, 12 Mar 2020 10:01:25 -0700 (PDT) MIME-Version: 1.0 References: <20200312154708.1720-1-chris@chris-wilson.co.uk> In-Reply-To: <20200312154708.1720-1-chris@chris-wilson.co.uk> From: Matthew Auld Date: Thu, 12 Mar 2020 17:00:58 +0000 Message-ID: To: Chris Wilson Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Use igt_random_offset() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , Matthew Auld Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 12 Mar 2020 at 15:47, Chris Wilson wrote: > > Switch igt_vm_isolation() to using igt_random_offset(). > > Signed-off-by: Chris Wilson > Cc: Matthew Auld > Cc: Akeem G Abodunrin > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c > index 77c7e65de7c3..62157e7567da 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c > @@ -1809,7 +1809,6 @@ static int igt_vm_isolation(void *arg) > > vm_total = ctx_vm(ctx_a)->total; > GEM_BUG_ON(ctx_vm(ctx_b)->total != vm_total); > - vm_total -= I915_GTT_PAGE_SIZE; > > count = 0; > num_engines = 0; > @@ -1828,10 +1827,9 @@ static int igt_vm_isolation(void *arg) > u32 value = 0xc5c5c5c5; > u64 offset; > > - div64_u64_rem(i915_prandom_u64_state(&prng), > - vm_total, &offset); > - offset = round_down(offset, alignof_dword); > - offset += I915_GTT_PAGE_SIZE; > + offset = igt_random_offset(&prng, 0, vm_total, > + I915_GTT_PAGE_SIZE, > + I915_GTT_PAGE_SIZE); Further down is: GEM_BUG_ON(offset < I915_GTT_PAGE_SIZE); Reviewed-by: Matthew Auld _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx