From: Sean Paul <seanpaul@chromium.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "DRM maintainer tools announcements, discussion,
and development" <dim-tools@lists.freedesktop.org>,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniele Castagna <dcastagna@google.com>
Subject: Re: [PULL] drm-misc-next
Date: Mon, 5 Mar 2018 15:20:17 -0800 [thread overview]
Message-ID: <CAOw6vbJr6AiQvR_6uKaLiTt07JrXHp5j7zJr6V5Wc-NNCe=3Uw@mail.gmail.com> (raw)
In-Reply-To: <20180305081005.GE6419@phenom.ffwll.local>
On Mon, Mar 5, 2018 at 12:10 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Mar 02, 2018 at 04:22:15PM -0500, Sean Paul wrote:
>> On Wed, Feb 28, 2018 at 3:34 PM, Sean Paul <seanpaul@chromium.org> wrote:
>> >
>> > Hi Dave,
>> > Here's this weeks pull, relatively small when you pull out the trivial fixes.
>> >
>> > drm-misc-next-2018-02-28:
>> > drm-misc-next for 4.17:
>> >
>> > UAPI Changes:
>> > Fix drm_color_ctm matrix docs to match usage and change the type to
>> > __u64 make it obvious (Ville)
>>
>> Hi Dave,
>> Could you please hold off on pulling this? I'd like to sort out this
>> change a bit more. We're already using the __s64 in chrome, and not
>> explicitly sign-magnitude. I think it would be prudent to hash this
>> out a little more.
>>
>> https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/gpu/drm_device.cc?l=161
>
> That code seems to be doing the exact same fun s.u63 math. This all looks
> consistent to me.
Hmm, yeah, I skimmed too quickly last week.
>
> Now in hindsight ofc we've screwed up the uapi, but well can't fix that
> now again ...
Yeah, I'm not convinced we should be changing the type. It's great to
clarify the documentation to let userspace know it's sign-magnitude,
but changing the type in-flight with users seems wrong.
Sean
> -Daniel
>
>>
>> Sean
>>
>> >
>> > Core Changes:
>> > Check modifier with format when checking if a plane state is supported (Ville)
>> >
>> > Driver Changes:
>> > sun4i: Improve hw plane utilization (Maxime)
>> > simple: Add per-pipe enable/disable vblank functions (Oleksandr)
>> > virtio: Whitespace + checkpatch changes (Rodrigo)
>> >
>> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
>> > Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
>> >
>> > Cheers, Sean
>> >
>> >
>> > The following changes since commit 2b91e3c43b4f3d3cd4d84a31cfbe6b165d89b70e:
>> >
>> > drm/omapdrm: Use of_find_backlight helper (2018-02-20 11:07:22 -0500)
>> >
>> > are available in the Git repository at:
>> >
>> > git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-2018-02-28
>> >
>> > for you to fetch changes up to 7628166d5e2883e4cdd142b99863d29d411a81b2:
>> >
>> > tinydrm: add backlight dependency (2018-02-28 15:08:56 -0500)
>> >
>> > ----------------------------------------------------------------
>> > drm-misc-next for 4.17:
>> >
>> > UAPI Changes:
>> > Fix drm_color_ctm matrix docs to match usage and change the type to
>> > __u64 make it obvious (Ville)
>> >
>> > Core Changes:
>> > Check modifier with format when checking if a plane state is supported (Ville)
>> >
>> > Driver Changes:
>> > sun4i: Improve hw plane utilization (Maxime)
>> > simple: Add per-pipe enable/disable vblank functions (Oleksandr)
>> > virtio: Whitespace + checkpatch changes (Rodrigo)
>> >
>> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
>> > Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
>> >
>> > ----------------------------------------------------------------
>> > Arnd Bergmann (2):
>> > drm: fix drm_get_max_iomem type mismatch
>> > tinydrm: add backlight dependency
>> >
>> > Benjamin Gaignard (1):
>> > drm/stm: check pitch and size calculations even if !CONFIG_MMU
>> >
>> > Chris Wilson (1):
>> > drm/mm: Fix caching of leftmost node in the interval tree
>> >
>> > Linus Walleij (1):
>> > drm/panel: Fix ARM Versatile panel clocks
>> >
>> > Maxime Ripard (4):
>> > drm/sun4i: backend: Assign the pipes automatically
>> > drm/sun4i: Remove the plane description structure
>> > drm/sun4i: backend: Make zpos configurable
>> > drm/sun4i: backend: Remove ARGB spoofing
>> >
>> > Oleksandr Andrushchenko (5):
>> > drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC
>> > drm/simple_kms_helper: Add {enable|disable}_vblank callback support
>> > drm/mxsfb: Do not use deprecated drm_driver.{enable|disable)_vblank
>> > drm/tve200: Do not use deprecated drm_driver.{enable|disable)_vblank
>> > drm/pl111: Do not use deprecated drm_driver.{enable|disable)_vblank
>> >
>> > Rodrigo Siqueira (7):
>> > drm/virtio: Add tabs at the start of a line
>> > drm/virtio: Add blank line after variable declarations
>> > drm/virtio: Add */ in block comments to separate line
>> > drm/virtio: Remove return from void function
>> > drm/virtio: Replace 'unsigned' for 'unsigned int'
>> > drm/virtio: Remove multiple blank lines
>> > drm/virtio: Add spaces around operators
>> >
>> > Thierry Reding (1):
>> > drm/pl111: Remove reverse dependency on DRM_DUMB_VGA_DAC
>> >
>> > Ville Syrjälä (4):
>> > drm: Check that the plane supports the request format+modifier combo
>> > drm/i915: Remove the pipe/plane ID checks from skl_check_ccs_aux_surface()
>> > drm: Include the header with the prototype for drm_get_panel_orientation_quirk()
>> > drm/uapi: The ctm matrix uses sign-magnitude representation
>> >
>> > drivers/gpu/drm/drm_atomic.c | 10 +++--
>> > drivers/gpu/drm/drm_crtc.c | 10 +++--
>> > drivers/gpu/drm/drm_crtc_internal.h | 4 +-
>> > drivers/gpu/drm/drm_memory.c | 2 +-
>> > drivers/gpu/drm/drm_mm.c | 9 +++--
>> > drivers/gpu/drm/drm_panel_orientation_quirks.c | 1 +
>> > drivers/gpu/drm/drm_plane.c | 33 ++++++++++++----
>> > drivers/gpu/drm/drm_simple_kms_helper.c | 34 ++++++++++++----
>> > drivers/gpu/drm/i915/intel_display.c | 8 ----
>> > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 54 +++++++++++++------------
>> > drivers/gpu/drm/panel/panel-arm-versatile.c | 8 ++--
>> > drivers/gpu/drm/pl111/Kconfig | 1 -
>> > drivers/gpu/drm/pl111/pl111_display.c | 15 +++++--
>> > drivers/gpu/drm/pl111/pl111_drm.h | 2 -
>> > drivers/gpu/drm/pl111/pl111_drv.c | 5 ---
>> > drivers/gpu/drm/stm/drv.c | 2 -
>> > drivers/gpu/drm/sun4i/sun4i_backend.c | 52 ++++++++++++++++++------
>> > drivers/gpu/drm/sun4i/sun4i_layer.c | 55 ++++++--------------------
>> > drivers/gpu/drm/sun4i/sun4i_layer.h | 1 +
>> > drivers/gpu/drm/tinydrm/Kconfig | 2 +
>> > drivers/gpu/drm/tve200/tve200_display.c | 10 ++++-
>> > drivers/gpu/drm/tve200/tve200_drm.h | 2 -
>> > drivers/gpu/drm/tve200/tve200_drv.c | 3 --
>> > drivers/gpu/drm/virtio/virtgpu_display.c | 7 ++--
>> > drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +-
>> > drivers/gpu/drm/virtio/virtgpu_drv.h | 8 ++--
>> > drivers/gpu/drm/virtio/virtgpu_fb.c | 6 ++-
>> > drivers/gpu/drm/virtio/virtgpu_gem.c | 1 +
>> > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 23 ++++++-----
>> > drivers/gpu/drm/virtio/virtgpu_prime.c | 4 +-
>> > drivers/gpu/drm/virtio/virtgpu_ttm.c | 4 +-
>> > drivers/gpu/drm/virtio/virtgpu_vq.c | 13 +++---
>> > include/drm/drm_simple_kms_helper.h | 18 +++++++++
>> > include/uapi/drm/drm_mode.h | 7 +++-
>> > 34 files changed, 243 insertions(+), 173 deletions(-)
>> >
>> > --
>> > Sean Paul, Software Engineer, Google / Chromium OS
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-05 23:20 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 20:34 [PULL] drm-misc-next Sean Paul
2018-03-02 21:22 ` Sean Paul
2018-03-05 8:10 ` Daniel Vetter
2018-03-05 23:20 ` Sean Paul [this message]
2018-03-06 6:42 ` Daniel Vetter
2018-03-06 19:01 ` Sean Paul
2018-03-06 19:07 ` Ville Syrjälä
2018-03-06 19:20 ` Sean Paul
2018-03-07 8:19 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2024-04-25 14:39 Maarten Lankhorst
2024-04-19 12:04 Maarten Lankhorst
2024-04-10 14:59 Maarten Lankhorst
2024-04-05 12:36 Maarten Lankhorst
2024-03-28 11:22 Maarten Lankhorst
2024-03-21 13:56 Maarten Lankhorst
2024-02-29 8:48 Thomas Zimmermann
2024-02-22 13:58 Thomas Zimmermann
2024-02-26 9:41 ` Daniel Vetter
2024-02-15 13:26 Thomas Zimmermann
2024-02-09 16:32 Thomas Zimmermann
2024-01-11 15:49 Thomas Zimmermann
2023-12-14 9:34 Maxime Ripard
2019-10-31 19:30 Sean Paul
2019-10-24 15:55 Sean Paul
2019-10-17 19:26 Sean Paul
2019-10-18 13:45 ` Tomi Valkeinen
2019-10-18 20:11 ` Sean Paul
2019-10-21 8:09 ` Tomi Valkeinen
2019-10-21 15:48 ` Sean Paul
2019-10-09 15:08 Sean Paul
2019-08-23 8:35 Maxime Ripard
2019-08-19 14:19 Maxime Ripard
2019-08-16 11:32 Maxime Ripard
2019-08-16 11:47 ` Chris Wilson
2019-08-19 14:19 ` Maxime Ripard
2019-08-08 12:14 Maxime Ripard
2019-08-03 10:47 Maxime Ripard
2019-08-06 0:33 ` Dave Airlie
2019-08-06 7:34 ` Daniel Vetter
2019-08-06 9:40 ` Emil Velikov
2019-08-06 9:49 ` Daniel Vetter
2019-08-06 9:54 ` Emil Velikov
2019-08-06 9:58 ` Daniel Vetter
2019-08-06 10:12 ` Daniel Stone
2019-08-06 10:27 ` Emil Velikov
2019-08-06 10:48 ` Jani Nikula
2019-08-06 9:55 ` Daniel Vetter
2019-08-06 14:25 ` Rob Herring
2019-08-06 14:55 ` Daniel Vetter
2019-08-06 16:01 ` Maxime Ripard
2019-08-06 16:11 ` Daniel Vetter
2019-08-07 12:02 ` Maxime Ripard
2019-08-07 12:30 ` Daniel Vetter
2019-08-08 15:29 ` Maxime Ripard
2019-06-20 15:42 Maarten Lankhorst
2019-06-14 8:57 Maarten Lankhorst
2019-06-14 9:35 ` Daniel Vetter
2019-06-05 9:17 Maarten Lankhorst
2019-05-23 15:47 Maarten Lankhorst
2019-05-23 15:53 ` Sean Paul
2019-05-23 15:55 ` Daniel Vetter
2019-05-23 15:55 ` Daniel Vetter
2019-04-18 9:05 Maarten Lankhorst
2019-04-10 19:49 Sean Paul
2019-04-04 20:10 Sean Paul
2019-03-28 15:33 Sean Paul
2019-03-28 16:03 ` Daniel Vetter
2019-03-21 17:08 Sean Paul
2019-03-25 10:37 ` Daniel Vetter
[not found] <20190211095220.3oeodszr2dgxrwqq@flea>
2019-02-14 13:07 ` Daniel Vetter
2019-02-01 14:47 Maxime Ripard
2019-01-23 11:03 Maxime Ripard
2019-01-16 20:04 Maxime Ripard
2019-01-15 10:56 Maxime Ripard
2019-01-16 9:36 ` Daniel Vetter
2019-01-07 18:03 Maxime Ripard
2018-12-06 9:44 Maarten Lankhorst
2018-11-28 9:36 Maarten Lankhorst
2018-11-21 10:44 Maarten Lankhorst
2018-11-08 16:05 Maarten Lankhorst
2018-11-07 11:58 Maarten Lankhorst
2018-11-07 20:18 ` Daniel Vetter
2018-11-07 20:29 ` Sean Paul
2018-11-07 20:31 ` Daniel Vetter
2018-11-07 20:48 ` Sean Paul
2018-11-08 7:56 ` Christian König
2018-11-08 8:05 ` Daniel Vetter
2018-11-08 8:37 ` Maarten Lankhorst
2018-09-27 9:39 Sean Paul
2018-09-19 20:03 Sean Paul
2018-09-13 13:02 Sean Paul
2018-09-05 20:22 Sean Paul
2018-07-18 20:08 Gustavo Padovan
2018-07-12 1:11 Gustavo Padovan
2018-07-04 23:46 Gustavo Padovan
2018-06-28 1:00 Gustavo Padovan
2018-06-21 10:54 Gustavo Padovan
2018-06-21 0:58 Gustavo Padovan
2018-06-21 10:01 ` Christian König
2018-05-15 8:17 Maarten Lankhorst
2018-05-11 7:43 Maarten Lankhorst
2018-05-11 20:25 ` Eric Anholt
2018-05-04 9:54 Maarten Lankhorst
2018-04-26 10:53 Maarten Lankhorst
2018-06-06 3:37 ` Dave Airlie
2018-06-06 7:49 ` Maarten Lankhorst
2018-03-21 14:49 Sean Paul
2018-03-09 18:04 Sean Paul
2018-02-21 20:36 Sean Paul
2018-01-08 13:45 Gustavo Padovan
2017-12-21 17:04 Gustavo Padovan
2017-12-14 17:46 Gustavo Padovan
2017-12-07 11:06 Gustavo Padovan
2017-10-20 13:39 Daniel Vetter
2017-10-16 9:35 Daniel Vetter
2017-10-12 12:05 Daniel Vetter
2017-10-13 14:08 ` Maarten Lankhorst
2017-10-13 14:24 ` Benjamin Gaignard
2017-10-05 5:36 Daniel Vetter
2017-09-20 17:33 Daniel Vetter
2017-09-20 18:42 ` Daniel Vetter
2017-08-18 17:00 Sean Paul
2017-08-16 20:42 Sean Paul
2017-08-08 19:50 Sean Paul
2017-07-18 18:42 Sean Paul
2017-07-18 18:49 ` Sean Paul
2017-06-15 20:52 Sean Paul
2017-06-02 20:55 Sean Paul
2017-05-26 20:58 Sean Paul
2017-05-29 6:57 ` Daniel Vetter
2017-05-16 14:55 Sean Paul
2017-03-31 15:23 Sean Paul
2017-03-21 9:06 Daniel Vetter
2017-03-20 15:30 Daniel Vetter
2017-03-21 7:23 ` Daniel Vetter
2017-03-12 12:57 Daniel Vetter
2017-03-06 9:54 Daniel Vetter
2017-01-30 8:58 Daniel Vetter
2017-01-23 7:35 Daniel Vetter
2017-01-09 19:15 Daniel Vetter
2016-12-30 10:35 Daniel Vetter
2016-12-08 10:16 Daniel Vetter
2016-11-29 10:13 Daniel Vetter
2016-11-29 11:17 ` Daniel Vetter
2016-11-29 21:01 ` Stephen Rothwell
2016-11-16 17:11 Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOw6vbJr6AiQvR_6uKaLiTt07JrXHp5j7zJr6V5Wc-NNCe=3Uw@mail.gmail.com' \
--to=seanpaul@chromium.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dcastagna@google.com \
--cc=dim-tools@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maxime.ripard@bootlin.com \
--cc=oleksandr_andrushchenko@epam.com \
--cc=rodrigo.vivi@intel.com \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).