From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 1/2] drm/i915: clear up wedged transitions Date: Wed, 5 Dec 2012 16:38:40 +0000 Message-ID: References: <1352909648-21514-1-git-send-email-daniel.vetter@ffwll.ch> <1352996243-15590-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from orsmga101.jf.intel.com (mga06.intel.com [134.134.136.21]) by gabe.freedesktop.org (Postfix) with ESMTP id B8D3EE65C2 for ; Wed, 5 Dec 2012 08:38:43 -0800 (PST) Received: by mail-oa0-f69.google.com with SMTP id j6so24517238oag.0 for ; Wed, 05 Dec 2012 08:38:41 -0800 (PST) In-Reply-To: <1352996243-15590-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Thu, Nov 15, 2012 at 4:17 PM, Daniel Vetter wrote: > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -1596,7 +1596,7 @@ i915_wedged_read(struct file *filp, > > len = snprintf(buf, sizeof(buf), > "wedged : %d\n", > - atomic_read(&dev_priv->gpu_error.wedged)); > + atomic_read(&dev_priv->gpu_error.reset_counter)); I was wondering if you might want to expose wedge as (gpu_error.reset_counter == I915_WEDGED) and have a separate reset_counter set to (gpu_error.reset_counter >> 1) -- Damien