From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lespiau, Damien" <damien.lespiau@intel.com>
Subject: Re: [PATCH 1/5] drm/i915: implement
	WaIssueDummyWriteToWakupFromRC6
Date: Thu, 18 Oct 2012 12:25:44 +0100
Message-ID: <CAPX-8+94KZZyVLq+mFnjaEX4Qbf+BFr3nNtbJ=rVVGjKmApwaA@mail.gmail.com>
References: <1350553794-5534-1-git-send-email-daniel.vetter@ffwll.ch>
	<1350553794-5534-2-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6DA439E860
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 18 Oct 2012 04:25:46 -0700 (PDT)
Received: by mail-qc0-f177.google.com with SMTP id u28so7055622qcs.36
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 18 Oct 2012 04:25:44 -0700 (PDT)
In-Reply-To: <1350553794-5534-2-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Oct 18, 2012 at 10:49 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> +static void
> +ilk_dummy_write(struct drm_i915_private *dev_priv)
> +{
> +       /* Ilk w/a: Issue a dummy write to wake up the chip from rc6 before
> +        * touching it for real. MI_MODE is masked, hence harmless to write 0
> +        * into. */

I'd document the wa implemented here.

The summary line is missing an 'e' in Wake, it makes it harder to look for it.

-- 
Damien