From: "Liu, Yi L" <yi.l.liu@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"Hao, Xudong" <xudong.hao@intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"Xu, Terrence" <terrence.xu@intel.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"lulu@redhat.com" <lulu@redhat.com>,
"Jiang, Yanting" <yanting.jiang@intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>
Subject: Re: [Intel-gfx] [PATCH v9 16/25] iommufd/device: Add iommufd_access_detach() API
Date: Wed, 5 Apr 2023 14:10:19 +0000 [thread overview]
Message-ID: <DS0PR11MB7529B223F9091E509DBF351DC3909@DS0PR11MB7529.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ZC1h7PyuhEg3ZMcj@nvidia.com>
> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Wednesday, April 5, 2023 7:56 PM
>
> On Tue, Apr 04, 2023 at 04:45:12PM -0600, Alex Williamson wrote:
> > On Sat, 1 Apr 2023 08:18:24 -0700
> > Yi Liu <yi.l.liu@intel.com> wrote:
> >
> > > From: Nicolin Chen <nicolinc@nvidia.com>
> > >
> > > Previously, the detach routine is only done by the destroy(). And it was
> > > called by vfio_iommufd_emulated_unbind() when the device runs close(), so
> > > all the mappings in iopt were cleaned in that setup, when the call trace
> > > reaches this detach() routine.
> > >
> > > Now, there's a need of a detach uAPI, meaning that it does not only need
> > > a new iommufd_access_detach() API, but also requires access->ops->unmap()
> > > call as a cleanup. So add one.
> > >
> > > However, leaving that unprotected can introduce some potential of a race
> > > condition during the pin_/unpin_pages() call, where access->ioas->iopt is
> > > getting referenced. So, add an ioas_lock to protect the context of iopt
> > > referencings.
> > >
> > > Also, to allow the iommufd_access_unpin_pages() callback to happen via
> > > this unmap() call, add an ioas_unpin pointer, so the unpin routine won't
> > > be affected by the "access->ioas = NULL" trick.
> > >
> > > Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> > > Tested-by: Terrence Xu <terrence.xu@intel.com>
> > > Tested-by: Yanting Jiang <yanting.jiang@intel.com>
> > > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> > > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > > ---
> > > drivers/iommu/iommufd/device.c | 76 +++++++++++++++++++++++--
> > > drivers/iommu/iommufd/iommufd_private.h | 2 +
> > > include/linux/iommufd.h | 1 +
> > > 3 files changed, 74 insertions(+), 5 deletions(-)
> >
> > Does this need to go in via iommufd first? There seems to be quite a
> > bit of churn in iommufd/device.c vs the vfio_mdev_ops branch (ie. it
> > doesn't apply). Thanks,
>
> I think it is best to stay with this series, Yi has to rebase it
The rebased version is here. Shall I resend a version which is rebased on
top of vfio_mdev_ops?
https://github.com/yiliu1765/iommufd/commit/d3d8f65c82fe2ca2a7b1a635f4b40b2a0971daa9
Regards,
Yi Liu
next prev parent reply other threads:[~2023-04-05 14:10 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 15:18 [Intel-gfx] [PATCH v9 00/25] Add vfio_device cdev for iommufd support Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 01/25] vfio: Allocate per device file structure Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 02/25] vfio: Refine vfio file kAPIs for KVM Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 03/25] vfio: Remove vfio_file_is_group() Yi Liu
2023-04-05 12:20 ` Eric Auger
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 04/25] vfio: Accept vfio device file in the KVM facing kAPI Yi Liu
2023-04-05 17:58 ` Eric Auger
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 05/25] kvm/vfio: Rename kvm_vfio_group to prepare for accepting vfio device fd Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace Yi Liu
2023-04-06 9:46 ` Eric Auger
2023-04-06 10:49 ` Liu, Yi L
2023-04-06 18:57 ` Alex Williamson
2023-04-07 3:42 ` Liu, Yi L
2023-04-07 8:56 ` Eric Auger
2023-04-07 10:23 ` Liu, Yi L
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 07/25] vfio: Pass struct vfio_device_file * to vfio_device_open/close() Yi Liu
2023-04-06 12:43 ` Eric Auger
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 08/25] vfio: Block device access via device fd until device is opened Yi Liu
2023-04-06 14:08 ` Eric Auger
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 09/25] vfio: Add cdev_device_open_cnt to vfio_group Yi Liu
2023-04-06 14:13 ` Eric Auger
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 10/25] vfio: Make vfio_device_open() single open for device cdev path Yi Liu
2023-04-06 16:44 ` Eric Auger
2023-04-07 9:48 ` Eric Auger
2023-04-07 10:18 ` Liu, Yi L
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 11/25] vfio: Make vfio_device_first_open() to accept NULL iommufd for noiommu Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 12/25] vfio-iommufd: Move noiommu support out of vfio_iommufd_bind() Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 13/25] vfio-iommufd: Split bind/attach into two steps Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 14/25] vfio: Record devid in vfio_device_file Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 15/25] vfio-iommufd: Add detach_ioas support for physical VFIO devices Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 16/25] iommufd/device: Add iommufd_access_detach() API Yi Liu
2023-04-04 22:45 ` Alex Williamson
2023-04-05 11:56 ` Jason Gunthorpe
2023-04-05 14:10 ` Liu, Yi L [this message]
2023-04-05 14:28 ` Jason Gunthorpe
2023-04-05 14:46 ` Liu, Yi L
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 17/25] vfio-iommufd: Add detach_ioas support for emulated VFIO devices Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 18/25] vfio: Determine noiommu in vfio_device registration Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 19/25] vfio: Name noiommu vfio_device with "noiommu-" prefix Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 20/25] vfio: Move vfio_device_group_unregister() to be the first operation in unregister Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 21/25] vfio: Add cdev for vfio_device Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 22/25] vfio: Add VFIO_DEVICE_BIND_IOMMUFD Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 23/25] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 24/25] vfio: Compile group optionally Yi Liu
2023-04-01 15:18 ` [Intel-gfx] [PATCH v9 25/25] docs: vfio: Add vfio device cdev description Yi Liu
2023-04-05 13:45 ` Eric Auger
2023-04-05 14:00 ` Liu, Yi L
2023-04-05 16:58 ` Alex Williamson
2023-04-07 8:44 ` Liu, Yi L
2023-04-01 15:23 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev11) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DS0PR11MB7529B223F9091E509DBF351DC3909@DS0PR11MB7529.namprd11.prod.outlook.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=terrence.xu@intel.com \
--cc=xudong.hao@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yanting.jiang@intel.com \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).