From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D5CC433E6 for ; Fri, 8 Jan 2021 15:42:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 966282368A for ; Fri, 8 Jan 2021 15:42:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 966282368A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=etezian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 319636E831; Fri, 8 Jan 2021 15:42:37 +0000 (UTC) X-Greylist: delayed 1839 seconds by postgrey-1.36 at gabe; Fri, 08 Jan 2021 15:42:35 UTC Received: from 9.mo177.mail-out.ovh.net (9.mo177.mail-out.ovh.net [46.105.72.238]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC5876E831 for ; Fri, 8 Jan 2021 15:42:35 +0000 (UTC) Received: from player762.ha.ovh.net (unknown [10.108.1.68]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id 3C61414E000 for ; Fri, 8 Jan 2021 16:27:27 +0100 (CET) Received: from etezian.org (213-243-141-64.bb.dnainternet.fi [213.243.141.64]) (Authenticated sender: andi@etezian.org) by player762.ha.ovh.net (Postfix) with ESMTPSA id 8051119D66E60; Fri, 8 Jan 2021 15:27:25 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-98R002d4a1aefd-6582-48a6-919f-f51ecee3da77, 83D1C09382E53F50CE2429AE6C9B6AA8FD9DCB87) smtp.auth=andi@etezian.org X-OVh-ClientIp: 213.243.141.64 Date: Fri, 8 Jan 2021 17:27:23 +0200 From: Andi Shyti To: Chris Wilson Message-ID: References: <20210107221724.10036-1-chris@chris-wilson.co.uk> <20210107221724.10036-5-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210107221724.10036-5-chris@chris-wilson.co.uk> X-Ovh-Tracer-Id: 8781737801361048073 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrvdeghedgtdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhguihcuufhhhihtihcuoegrnhguihesvghtvgiiihgrnhdrohhrgheqnecuggftrfgrthhtvghrnheptdfgudduhfefueeujeefieehtdeftefggeevhefgueellefhudetgeeikeduieefnecukfhppedtrddtrddtrddtpddvudefrddvgeefrddugedurdeigeenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejiedvrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheprghnughisegvthgviihirghnrdhorhhgpdhrtghpthhtohepihhnthgvlhdqghhfgieslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrgh Subject: Re: [Intel-gfx] [PATCH 5/5] drm/i915/gt: Disable arbitration on no-preempt requests X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Chris, On Thu, Jan 07, 2021 at 10:17:24PM +0000, Chris Wilson wrote: > If a request is submitted and known to require no preemption, disable > arbitration around the batch which prevents the HW from handling a > preemption request during the payload. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Matthew Brost > Cc: Lionel Landwerlin > --- > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 +++--- > drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 3 +++ > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > index cf9a6b4eb913..b91b32195dcf 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -2534,6 +2534,9 @@ static int eb_submit(struct i915_execbuffer *eb, struct i915_vma *batch) > { > int err; > > + if (intel_context_nopreempt(eb->context)) > + __set_bit(I915_FENCE_FLAG_NOPREEMPT, &eb->request->fence.flags); > + > err = eb_move_to_gpu(eb); > if (err) > return err; > @@ -2574,9 +2577,6 @@ static int eb_submit(struct i915_execbuffer *eb, struct i915_vma *batch) > return err; > } > > - if (intel_context_nopreempt(eb->context)) > - __set_bit(I915_FENCE_FLAG_NOPREEMPT, &eb->request->fence.flags); > - makes sense to me... Reviewed-by: Andi Shyti Thanks, Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx