From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBD53C433E0 for ; Fri, 8 Jan 2021 17:30:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 419E32333E for ; Fri, 8 Jan 2021 17:30:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 419E32333E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=etezian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A3EBC6E845; Fri, 8 Jan 2021 17:30:45 +0000 (UTC) X-Greylist: delayed 8398 seconds by postgrey-1.36 at gabe; Fri, 08 Jan 2021 17:30:44 UTC Received: from 8.mo6.mail-out.ovh.net (8.mo6.mail-out.ovh.net [178.33.42.204]) by gabe.freedesktop.org (Postfix) with ESMTPS id 804C06E845 for ; Fri, 8 Jan 2021 17:30:44 +0000 (UTC) Received: from player771.ha.ovh.net (unknown [10.108.54.172]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id 350C2232023 for ; Fri, 8 Jan 2021 14:52:02 +0100 (CET) Received: from etezian.org (213-243-141-64.bb.dnainternet.fi [213.243.141.64]) (Authenticated sender: andi@etezian.org) by player771.ha.ovh.net (Postfix) with ESMTPSA id EF01819EBC975; Fri, 8 Jan 2021 13:51:56 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-96R00153d4cb5b-cbce-45e8-aaab-6a879adda1e3, 83D1C09382E53F50CE2429AE6C9B6AA8FD9DCB87) smtp.auth=andi@etezian.org X-OVh-ClientIp: 213.243.141.64 Date: Fri, 8 Jan 2021 15:51:54 +0200 From: Andi Shyti To: Chris Wilson Message-ID: References: <20210107221724.10036-1-chris@chris-wilson.co.uk> <161011238272.28368.13711350036924329757@build.alporthouse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <161011238272.28368.13711350036924329757@build.alporthouse.com> X-Ovh-Tracer-Id: 7170012084842840585 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrvdeggedgheejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhguihcuufhhhihtihcuoegrnhguihesvghtvgiiihgrnhdrohhrgheqnecuggftrfgrthhtvghrnheptdfgudduhfefueeujeefieehtdeftefggeevhefgueellefhudetgeeikeduieefnecukfhppedtrddtrddtrddtpddvudefrddvgeefrddugedurdeigeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejjedurdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheprghnughisegvthgviihirghnrdhorhhgpdhrtghpthhtohepihhnthgvlhdqghhfgieslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrgh Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915/selftests: Skip unstable timing measurements X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Chris, > > > diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c > > > index 75839db63bea..59c58a276677 100644 > > > --- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c > > > +++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c > > > @@ -852,6 +852,9 @@ static int _perf_memcpy(struct intel_memory_region *src_mr, > > > } > > > > > > sort(t, ARRAY_SIZE(t), sizeof(*t), wrap_ktime_compare, NULL); > > > + if (!t[0]) > > > + continue; > > > + > > > > are you assuming here that if t[0] is '0', also the rest of 't' > > is '0'? > > It's sorted into ascending order with ktime_t... Hmm, s64 not u64 as I > presumed. So better to check <= 0. by division by 0 I guess you mean here: div64_u64(mul_u32_u32(4 * size, 1000 * 1000 * 1000), t[1] + 2 * t[2] + t[3]) >> 20); why are you testing t[0]? Did I miss anything else? Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx