From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A17AC4338F for ; Tue, 10 Aug 2021 06:38:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 423A860238 for ; Tue, 10 Aug 2021 06:38:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 423A860238 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BDDFC89E9E; Tue, 10 Aug 2021 06:38:47 +0000 (UTC) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3032589E9E for ; Tue, 10 Aug 2021 06:38:46 +0000 (UTC) Received: by mail-wm1-x332.google.com with SMTP id l34-20020a05600c1d22b02902573c214807so1147154wms.2 for ; Mon, 09 Aug 2021 23:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QcIJY41uAzBRDJL+tMwtpLREfeamN5syF4dVjhDGcqc=; b=MtdxtwU8X7QR3u3FOZYMAiX+/OFHUM/0Om7LftC8xXK590N9itpb4tOKvRZ4eSycb6 UsvLLOsInksukuzghUF1N5TEC2ojc3/TFg3Bc5GlTW/ezQUuj6kjqU2QYOYAXfZ0KzW5 zBeyA2e7tLG0ymDCj5mas8zANta4tNbVKLJ4A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QcIJY41uAzBRDJL+tMwtpLREfeamN5syF4dVjhDGcqc=; b=FsULZa/EYFAcnB0YDQjyX4AxY1RgSh9zQDnHf43YCiHd4BFwUH2dgjAT9mh1B/gNEC jmaq/5pYQBV8uQ6/qyWHvCgvI+jct5vBUDVPqcIWFS5ITHdHPjhjuStG0D5ocO+QQboU QGWL+6daEwG+8Bqq4blfoEz8C8vLMAC8+t0ZUf8rKMqrbhwhOMxIUSBMrwV3zKynIjz8 zuuF2GqksG5cec8o4j6B1gZ9tVk15XbLfdSHOHDGtDCs/RkHDbfoYizNaKWmN45qWrDn +zDHYAJrldOR0shC+N7VATaxxw+hQIG6Ip51FYAOIN4mkk65bVFlvDEVtgyE0va1alKK jKvQ== X-Gm-Message-State: AOAM531ZQ5uNEGZKGLhllX+HA6sfqmcNe9Z+h19IJ7fE0vwRfzzCnWgW DAi9/MNxz6ySQPe5nnIt8injvo/5Nyp42Q== X-Google-Smtp-Source: ABdhPJxEXkDz+yiuyVkrDVONeES5BBpLDREtOiLglCngRK/J1T2FyPYh/qFgH7MF2GqBluhiZHV9uw== X-Received: by 2002:a05:600c:1c86:: with SMTP id k6mr2857796wms.79.1628577524758; Mon, 09 Aug 2021 23:38:44 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id i5sm21690264wrw.13.2021.08.09.23.38.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 23:38:44 -0700 (PDT) Date: Tue, 10 Aug 2021 08:38:42 +0200 From: Daniel Vetter To: Matthew Brost Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Message-ID: References: <20210729003400.151864-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729003400.151864-1-matthew.brost@intel.com> X-Operating-System: Linux phenom 5.10.0-7-amd64 Subject: Re: [Intel-gfx] [PATCH 0/1] Fix gem_ctx_persistence failures with GuC submission X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jul 28, 2021 at 05:33:59PM -0700, Matthew Brost wrote: > Should fix below failures with GuC submission for the following tests: > gem_exec_balancer --r noheartbeat > gem_ctx_persistence --r heartbeat-close > > Not going to fix: > gem_ctx_persistence --r heartbeat-many > gem_ctx_persistence --r heartbeat-stop After looking at that big thread and being very confused: Are we fixing an actual use-case here, or is this another case of blindly following igts tests just because they exist? I'm leaning towards that we should stall on this, and first document what exactly is the actual intention behind all this, and then fix up the tests to match (if needed). And only then fix up GuC to match whatever we actually want to do. -Daniel > > As the above tests change the heartbeat value to 0 (off) after the > context is closed and we have no way to detect that with GuC submission > unless we keep a list of closed but running contexts which seems like > overkill for a non-real world use case. We likely should just skip these > tests with GuC submission. > > Signed-off-by: Matthew Brost > > Matthew Brost (1): > drm/i915: Check if engine has heartbeat when closing a context > > drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 +++-- > drivers/gpu/drm/i915/gt/intel_context_types.h | 2 ++ > drivers/gpu/drm/i915/gt/intel_engine.h | 21 ++----------------- > .../drm/i915/gt/intel_execlists_submission.c | 14 +++++++++++++ > .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 6 +++++- > .../gpu/drm/i915/gt/uc/intel_guc_submission.h | 2 -- > 6 files changed, 26 insertions(+), 24 deletions(-) > > -- > 2.28.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch