From: Imre Deak <imre.deak@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: Define cursor chicken reg
Date: Fri, 31 Mar 2023 13:51:29 +0300 [thread overview]
Message-ID: <ZCa7MZ0P8uOO3O4a@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20230329190445.13456-3-ville.syrjala@linux.intel.com>
On Wed, Mar 29, 2023 at 10:04:45PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Define CUR_CHICKEN so we don't have to remember the offset.
> Looks like it's getting introduced in mtl.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
On the patchset:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 275ec891468c..f6a6f3b6c603 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -3989,6 +3989,7 @@
> #define CUR_FBC_EN REG_BIT(31)
> #define CUR_FBC_HEIGHT_MASK REG_GENMASK(7, 0)
> #define CUR_FBC_HEIGHT(h) REG_FIELD_PREP(CUR_FBC_HEIGHT_MASK, (h))
> +#define _CUR_CHICKEN_A 0x700a4 /* mtl+ */
> #define _CURASURFLIVE 0x700ac /* g4x+ */
> #define _CURBCNTR 0x700c0
> #define _CURBBASE 0x700c4
> @@ -4003,6 +4004,7 @@
> #define CURPOS(pipe) _MMIO_CURSOR2(pipe, _CURAPOS)
> #define CURSIZE(pipe) _MMIO_CURSOR2(pipe, _CURASIZE)
> #define CUR_FBC_CTL(pipe) _MMIO_CURSOR2(pipe, _CUR_FBC_CTL_A)
> +#define CUR_CHICKEN(pipe) _MMIO_CURSOR2(pipe, _CUR_CHICKEN_A)
> #define CURSURFLIVE(pipe) _MMIO_CURSOR2(pipe, _CURASURFLIVE)
>
> #define CURSOR_A_OFFSET 0x70080
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-03-31 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 19:04 [Intel-gfx] [PATCH 1/3] drm/i915: Skip cursor when writing PLANE_CHICKEN Ville Syrjala
2023-03-29 19:04 ` [Intel-gfx] [PATCH 2/3] drm/i915: Document that PLANE_CHICKEN are for tgl+ Ville Syrjala
2023-03-29 19:04 ` [Intel-gfx] [PATCH 3/3] drm/i915: Define cursor chicken reg Ville Syrjala
2023-03-31 10:51 ` Imre Deak [this message]
2023-03-29 22:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Skip cursor when writing PLANE_CHICKEN Patchwork
2023-03-30 16:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCa7MZ0P8uOO3O4a@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).