From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69FF6C433F5 for ; Mon, 1 Nov 2021 10:49:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26A3160F56 for ; Mon, 1 Nov 2021 10:49:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 26A3160F56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A9CF289971; Mon, 1 Nov 2021 10:49:36 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4994D89971 for ; Mon, 1 Nov 2021 10:49:35 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="294448918" X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="294448918" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 03:49:34 -0700 X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="499987594" Received: from lellis-mobl.ger.corp.intel.com (HELO [10.213.243.87]) ([10.213.243.87]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 03:49:33 -0700 To: Joonas Lahtinen , Cooper Chiou , intel-gfx@lists.freedesktop.org References: <20200916180745.627-1-cooper.chiou@intel.com> <20211025042623.3876-1-cooper.chiou@intel.com> <42d4ab18-97b7-bb80-cef9-0d779007b9e2@linux.intel.com> <163576323499.3344.4388287606987057365@jlahtine-mobl.ger.corp.intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Mon, 1 Nov 2021 10:49:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <163576323499.3344.4388287606987057365@jlahtine-mobl.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v8] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , Chris Wilson , William Tseng , Pawel Wilma Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 01/11/2021 10:40, Joonas Lahtinen wrote: > Quoting Tvrtko Ursulin (2021-11-01 12:15:19) >> >> On 25/10/2021 05:26, Cooper Chiou wrote: >>> This implements WaProgramMgsrForCorrectSliceSpecificMmioReads which >>> was omitted by mistake from Gen9 documentation, while it is actually >>> applicable to fused off parts. >>> >>> Workaround consists of making sure MCR packet control register is >>> programmed to point to enabled slice/subslice pair before doing any >>> MMIO reads from the affected registers. >>> >>> Failure do to this can result in complete system hangs when running >>> certain workloads. Two known cases which can cause system hangs are: >>> >>> 1. "test_basic progvar_prog_scope_uninit" test which is part of >>> Khronos OpenCL conformance suite >>> (https://github.com/KhronosGroup/OpenCL-CTS) with the Intel >>> OpenCL driver (https://github.com/intel/compute-runtime). >>> >>> 2. VP8 media hardware encoding using the full-feature build of the >>> Intel media-driver (https://github.com/intel/media-driver) and >>> ffmpeg. >>> >>> For the former case patch was verified to fix the hard system hang >>> when executing the OCL test on Intel Pentium CPU 6405U which contains >>> fused off GT1 graphics. >>> >>> Reference: HSD#1508045018,1405586840, BSID#0575 >>> >>> Cc: Ville Syrjälä >>> Cc: Rodrigo Vivi >>> Cc: Jani Nikula >>> Cc: Chris Wilson >>> Cc: Tvrtko Ursulin >>> Cc: William Tseng >>> Cc: Shawn C Lee >>> Cc: Pawel Wilma >>> Signed-off-by: Cooper Chiou >> >> Reviewed-by: Tvrtko Ursulin > > Thanks for following through with all the testing and validation for the > patch! > > Acked-by: Joonas Lahtinen I've pushed it, thanks! Regards, Tvrtko