From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76281C433E0 for ; Mon, 18 Jan 2021 13:17:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32A6522B4E for ; Mon, 18 Jan 2021 13:17:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32A6522B4E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B00126E213; Mon, 18 Jan 2021 13:17:33 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53B6D6E213 for ; Mon, 18 Jan 2021 13:17:32 +0000 (UTC) IronPort-SDR: 1Xvhg5F83QojFac1dkx0emaRr1XErLpbVLT78Nj7jWIfQXd8QyKHHP/e5JtmyavfYrO4tflzjt R0s8BioYwYLg== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="158573964" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="158573964" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 05:17:29 -0800 IronPort-SDR: QVxQfnbppMfaezqqlqLZAU2bvxKKrSXj2HiqdrwRTgubnadt9aOD8ASqXSgyj+14YSwT5V5C9a TBZraZTutazw== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="355186885" Received: from lcrossx-mobl2.ger.corp.intel.com (HELO [10.252.44.240]) ([10.252.44.240]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 05:17:27 -0800 To: "Huang, Sean Z" , Intel-gfx@lists.freedesktop.org References: <20210118060730.15425-1-sean.z.huang@intel.com> From: Lionel Landwerlin Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ Message-ID: Date: Mon, 18 Jan 2021 15:17:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210118060730.15425-1-sean.z.huang@intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [RFC-v21 00/13] Introduce Intel PXP component - Mesa single session X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kumar.gaurav@intel.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Sean, FYI, I updated our Mesa drivers with the new I915_CONTEXT_PARAM_PROTECTED_CONTENT requirement to be only at creation time [1] [2] and gave a try to this series. It all works fine : Tested-by: Lionel Landwerlin Cheers, -Lionel [1] : https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8064 [2] : https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8092 On 18/01/2021 08:07, Huang, Sean Z wrote: > PXP (Protected Xe Path) is an i915 component, available on > GEN12+ that helps to establish the hardware protected session > and manage the status of the alive software session, as well > as its life cycle. > > This patch series is to allow the kernel space to create and > manage a single hardware session (a.k.a. default session or > arbitrary session). So user can allocate the protected buffer, > which is encrypted with the leverage of the arbitrary hardware > session. > > > rev21: > #01 > - Remove the term "Mesa" from the help description of Kconfig > - Remove unnecessary "select INTEL_MEI_TXE" from DRM_I915_PXP > in Kconfig > > #02 > - Remove "#define KCR_INIT_MASK_SHIFT (16)", but still keep the > macro in this .c file > - Write KCR_INIT reg inly for gen12 during boot, not required > for gen13+ > > #03 > - Remove debug print_hex_dump() from intel_pxp_tee_io_message() > - In struct i915_pxp_component_ops, change "receive" to "recv" > > #04: > - Rename SESSION_TYPE_TYPE0, SESSION_TYPE_TYPE1 as > SESSION_TYPE_HWDRM, > SESSION_TYPE_NONHWDRM to have better meaning. > - Remove enum pxp_session_types and enum pxp_protection_modes > from > single session patch series. > > #05 > In intel_pxp_cmd.c: > - Remove the debug print as well as print_hex_dump() > - Should call i915_gem_object_flush_map() before unpin map > - Using "goto label" instead of bool such as is_engine_pm_get > - We should always return the error if any, instead of skip > with i915_request_set_error_once() > > #06 > - Fix bug, access i915 pointer before assigning the value at > intel_pxp_irq_handler() > - Writing register GEN11_CRYPTO_RSVD_INTR_ENABLE to enable the > PXP irq > - Remove the unnecessary comment for GEN11_CRYPTO_RSVD_INTR_MASK > > #07 > - Bug fixing, we need to set the PXP_GLOBAL_TERMINATE 0x320f8 > register after arb session termination > - Remove enum pxp_session_types and enum pxp_protection_modes > from > single session patch series. > > #11 > - Fix "Fi.CI.CHECKPATCH" warnings > > #12 > - Only allow set I915_CONTEXT_PARAM_PROTECTED_CONTENT during > context > creation (i915_gem_context_create_ioctl), but not allow during > context set param (i915_gem_context_setparam_ioctl) > > > Anshuman Gupta (1): > drm/i915/pxp: Add plane decryption support > > Bommu Krishnaiah (2): > drm/i915/uapi: introduce drm_i915_gem_create_ext > drm/i915/pxp: User interface for Protected buffer > > Huang, Sean Z (9): > drm/i915/pxp: Introduce Intel PXP component > drm/i915/pxp: set KCR reg init during the boot time > drm/i915/pxp: Implement funcs to create the TEE channel > drm/i915/pxp: Create the arbitrary session after boot > drm/i915/pxp: Func to send hardware session termination > drm/i915/pxp: Enable PXP irq worker and callback stub > drm/i915/pxp: Destroy arb session upon teardown > drm/i915/pxp: Enable PXP power management > drm/i915/pxp: Expose session state for display protection flip > > Vitaly Lubart (1): > mei: pxp: export pavp client to me client bus > > drivers/gpu/drm/i915/Kconfig | 21 ++ > drivers/gpu/drm/i915/Makefile | 9 + > drivers/gpu/drm/i915/display/intel_sprite.c | 21 +- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 +- > drivers/gpu/drm/i915/gem/i915_gem_context.h | 5 + > .../gpu/drm/i915/gem/i915_gem_context_types.h | 1 + > drivers/gpu/drm/i915/gem/i915_gem_create.c | 68 +++++- > .../gpu/drm/i915/gem/i915_gem_object_types.h | 5 + > drivers/gpu/drm/i915/gt/intel_gt.c | 5 + > drivers/gpu/drm/i915/gt/intel_gt_irq.c | 14 ++ > drivers/gpu/drm/i915/gt/intel_gt_pm.c | 4 + > drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 + > drivers/gpu/drm/i915/i915_drv.c | 7 +- > drivers/gpu/drm/i915/i915_drv.h | 6 + > drivers/gpu/drm/i915/i915_reg.h | 2 + > drivers/gpu/drm/i915/pxp/intel_pxp.c | 185 ++++++++++++++ > drivers/gpu/drm/i915/pxp/intel_pxp.h | 64 +++++ > drivers/gpu/drm/i915/pxp/intel_pxp_arb.c | 208 ++++++++++++++++ > drivers/gpu/drm/i915/pxp/intel_pxp_arb.h | 17 ++ > drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c | 223 +++++++++++++++++ > drivers/gpu/drm/i915/pxp/intel_pxp_cmd.h | 19 ++ > drivers/gpu/drm/i915/pxp/intel_pxp_context.c | 28 +++ > drivers/gpu/drm/i915/pxp/intel_pxp_context.h | 15 ++ > drivers/gpu/drm/i915/pxp/intel_pxp_pm.c | 65 +++++ > drivers/gpu/drm/i915/pxp/intel_pxp_pm.h | 31 +++ > drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 202 +++++++++++++++ > drivers/gpu/drm/i915/pxp/intel_pxp_tee.h | 17 ++ > drivers/gpu/drm/i915/pxp/intel_pxp_types.h | 38 +++ > drivers/misc/mei/Kconfig | 2 + > drivers/misc/mei/Makefile | 1 + > drivers/misc/mei/pxp/Kconfig | 13 + > drivers/misc/mei/pxp/Makefile | 7 + > drivers/misc/mei/pxp/mei_pxp.c | 230 ++++++++++++++++++ > drivers/misc/mei/pxp/mei_pxp.h | 18 ++ > include/drm/i915_component.h | 1 + > include/drm/i915_pxp_tee_interface.h | 45 ++++ > include/uapi/drm/i915_drm.h | 66 +++++ > 37 files changed, 1671 insertions(+), 10 deletions(-) > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp.c > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp.h > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_arb.c > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_arb.h > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_cmd.h > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_context.c > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_context.h > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_pm.c > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_pm.h > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_tee.h > create mode 100644 drivers/gpu/drm/i915/pxp/intel_pxp_types.h > create mode 100644 drivers/misc/mei/pxp/Kconfig > create mode 100644 drivers/misc/mei/pxp/Makefile > create mode 100644 drivers/misc/mei/pxp/mei_pxp.c > create mode 100644 drivers/misc/mei/pxp/mei_pxp.h > create mode 100644 include/drm/i915_pxp_tee_interface.h > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx