From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Nikula, Jani" <jani.nikula@intel.com>
Cc: "Sarvela, Tomi P" <tomi.p.sarvela@intel.com>,
"Peres, Martin" <martin.peres@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/mst: fix pipe and vblank enable
Date: Mon, 10 Feb 2020 11:43:47 +0000 [thread overview]
Message-ID: <a8c9aee482db2d51630094ea07d7821b27a8d567.camel@intel.com> (raw)
In-Reply-To: <87imke1xvt.fsf@intel.com>
On Mon, 2020-02-10 at 13:32 +0200, Jani Nikula wrote:
> On Wed, 05 Feb 2020, Jani Nikula <jani.nikula@intel.com> wrote:
> > Commit 21fd23ac222f ("drm/i915: move pipe, pch and vblank enable to
> > encoders on DDI platforms") pushed pipe and vblank enable to
> > encoders on
> > DDI platforms, however it missed the DP MST encoder. Fix it.
> >
> > Fixes: 21fd23ac222f ("drm/i915: move pipe, pch and vblank enable to
> > encoders on DDI platforms")
> > Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Reported-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Thanks for the reviews and testing, pushed to dinq.
>
> I don't usually cut corners, but I've made an exception and pushed
> this
> without full IGT results.
>
> It's been 5 days since the patch was posted, the sharded run has
> fallen
> between the cracks, and the queue is currently about three days. IMHO
> it's intolerable for any patch, but especially so for a regression
> fix
> that was posted within hours of the bug report.
Absolutely agree, since we already had a regression, it's pointless
now to wait longer with such a trivial fix. We are anyway in a bad
situation now, checking also some other MST issues and having to apply
this patch manually first in order to get at least this issue ruled
out.
Stan
>
> BR,
> Jani.
>
>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_mst.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > index b8aee506d595..9cd59141953d 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > @@ -491,6 +491,12 @@ static void intel_mst_enable_dp(struct
> > intel_encoder *encoder,
> > struct intel_dp *intel_dp = &intel_dig_port->dp;
> > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> >
> > + drm_WARN_ON(&dev_priv->drm, pipe_config->has_pch_encoder);
> > +
> > + intel_enable_pipe(pipe_config);
> > +
> > + intel_crtc_vblank_on(pipe_config);
> > +
> > DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links);
> >
> > if (intel_de_wait_for_set(dev_priv, intel_dp-
> > >regs.dp_tp_status,
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-10 11:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 8:29 [Intel-gfx] [PATCH] drm/i915/mst: fix pipe and vblank enable Jani Nikula
2020-02-05 9:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-05 9:33 ` [Intel-gfx] [PATCH] " Kulkarni, Vandita
2020-02-05 9:38 ` Lisovskiy, Stanislav
2020-02-10 11:32 ` Jani Nikula
2020-02-10 11:43 ` Lisovskiy, Stanislav [this message]
2020-02-10 16:00 ` Arkadiusz Hiler
2020-02-14 7:36 ` Jani Nikula
2020-02-14 14:04 ` Sarvela, Tomi P
2020-02-14 14:25 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8c9aee482db2d51630094ea07d7821b27a8d567.camel@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=martin.peres@intel.com \
--cc=tomi.p.sarvela@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).