From: Chris Wilson <chris@chris-wilson.co.uk>
To: Keith Packard <keithp@keithp.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Prefault all pages for pread and pwrite
Date: Sat, 09 Jul 2011 21:31:17 +0100 [thread overview]
Message-ID: <aefc95$ohnhn@orsmga001.jf.intel.com> (raw)
In-Reply-To: <yuny607fbmr.fsf@aiko.keithp.com>
On Sat, 09 Jul 2011 13:21:48 -0700, Keith Packard <keithp@keithp.com> wrote:
> On Sat, 9 Jul 2011 09:38:50 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > +static int prefault_writeable(unsigned long uaddr, unsigned long len)
>
> > +static int prefault_readable(unsigned long uaddr, unsigned long len)
>
> These seems like a functions which belongs alongside (or in place of) the
> existing fault_in_pages_writable and fault_in_pages_readable functions.
>
> I think, in fact, that one could convincingly argue that the existing
> functions are misleadingly named (or just broken).
I agree that I was indeed misled by the description of those two functions!
However, I don't like why this appears to fix the issue of get_user_pages()
failing on the non-prefaulted address.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-07-09 20:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 8:38 [PATCH 1/2] drm/i915: Prefault all pages for pread and pwrite Chris Wilson
2011-07-09 8:38 ` [PATCH 2/2] drm/i915: Disable page-faults around the fast pwrite/pread paths Chris Wilson
2011-07-09 14:41 ` Eric Anholt
2011-07-09 17:40 ` Chris Wilson
2011-07-09 20:24 ` Keith Packard
2011-07-09 20:50 ` Chris Wilson
2011-07-09 21:06 ` Keith Packard
2011-07-09 21:23 ` Chris Wilson
2011-07-09 22:07 ` Keith Packard
2011-07-11 16:51 ` Chris Wilson
2011-07-11 19:55 ` Keith Packard
2011-07-10 18:45 ` Eric Anholt
2011-07-10 20:29 ` Keith Packard
2011-07-09 20:21 ` [PATCH 1/2] drm/i915: Prefault all pages for pread and pwrite Keith Packard
2011-07-09 20:31 ` Chris Wilson [this message]
2011-07-10 1:40 ` Ben Widawsky
2011-07-10 8:08 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aefc95$ohnhn@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).