Intel-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: Mike Isely <isely@isely.net>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Dave Airlied <airlied@linux.ie>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/lvds: Use i915.lvds_fixed_mode= as a last resort
Date: Thu, 21 Apr 2011 17:30:21 -0500 (CDT)
Message-ID: <alpine.DEB.1.10.1104211657160.18161@cnc.isely.net> (raw)
In-Reply-To: <alpine.DEB.1.10.1104201458440.31843@cnc.isely.net>

On Wed, 20 Apr 2011, Mike Isely wrote:

> On Wed, 20 Apr 2011, Chris Wilson wrote:
> 
> > On Wed, 20 Apr 2011 14:48:36 -0500 (CDT), Mike Isely <isely@isely.net> wrote:
> > > 
> > > Chris:
> > > 
> > > I've tested this patch and it doesn't help us here.  Even if I add 
> > > lvds_fixed_mode=<whatever>, the display still comes up with the messed 
> > > up configuration from the motherboard's completely ignorant BIOS.  It 
> > > appears that lvds_fixed_mode is being ignored by the driver.
> > 
> > You can test the functionality of the patch by parsing
> > i915.lvds_fixed_mode first rather than last.
> 
> I will test for that - it was the next thing I was going to dig into.

Just tested this.  However the results were not conclusive.

It looks like the driver did notice the specified mode and used it - 
because the display's refresh rate did get adjusted and the overall 
resolution is correct.  However the display timings are slightly "off", 
the image is stretched a few pixels off the right edge and a few lines 
off the bottom edge.  Yet the same modeline given to "video=" in 
combination with my controversial disable-fixed-mode patch however 
produces a perfectly aligned image.

There might some other affect here.  I'm not testing in the same git 
repo in the two cases and there are other differences.  So this problem 
might be unrelated to the patch.  I will sort that out.

  -Mike

-- 

Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-17  6:43 [PATCH 1/2] drm: Export the command-line mode parser Chris Wilson
2011-04-17  6:43 ` [PATCH 2/2] drm/i915/lvds: Use i915.lvds_fixed_mode= as a last resort Chris Wilson
2011-04-18 16:46   ` Mike Isely
2011-04-18 17:46     ` Mike Isely
2011-04-20 19:48   ` Mike Isely
2011-04-20 19:56     ` Chris Wilson
2011-04-20 20:09       ` Mike Isely
2011-04-21 22:30         ` Mike Isely [this message]
2011-04-21 22:37           ` Chris Wilson
2011-04-21 22:46             ` Mike Isely
2011-05-04 22:14               ` Mike Isely
2011-05-04 22:18                 ` [PATCH] drm/i915: Fix unset margins flag in drm_mode_parse_command_line_for_connector Mike Isely
2011-05-05  2:40                   ` Robert Lowery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.1104211657160.18161@cnc.isely.net \
    --to=isely@isely.net \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Intel-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/intel-gfx/0 intel-gfx/git/0.git
	git clone --mirror https://lore.kernel.org/intel-gfx/1 intel-gfx/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 intel-gfx intel-gfx/ https://lore.kernel.org/intel-gfx \
		intel-gfx@lists.freedesktop.org
	public-inbox-index intel-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.intel-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git