From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Isely Subject: [PATCH] drm/i915: Fix unset margins flag in drm_mode_parse_command_line_for_connector Date: Wed, 4 May 2011 17:18:13 -0500 (CDT) Message-ID: References: <1303022613-18414-1-git-send-email-chris@chris-wilson.co.uk> <1303022613-18414-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cnc.isely.net (cnc.isely.net [75.149.91.89]) by gabe.freedesktop.org (Postfix) with ESMTP id 302A89F64B for ; Wed, 4 May 2011 15:18:13 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Dave Airlied , intel-gfx@lists.freedesktop.org, Mike Isely at pobox List-Id: intel-gfx@lists.freedesktop.org The drm function which parses a mode into a standard mode line is computing the "margins" flag but then failing to copy that parameter into the parsed structure output. This seems to leave the field in a random state, which unfortunately influences the results when the parsed results are then subsequently used to calculate a mode line. The fix here is obvious: ensure the the margins flag is properly initialized in the result structure at the end of the parse operation. Signed-off-by: Mike Isely --- drivers/gpu/drm/drm_modes.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 207b7eb..3697c56 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -1094,6 +1094,7 @@ done: mode->bpp_specified = true; mode->bpp = bpp; } + mode->margins = margins ? true : false; mode->rb = rb ? true : false; mode->cvt = cvt ? true : false; mode->interlace = interlace ? true : false; -- 1.7.2.5 -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8