From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code Date: Sat, 29 Dec 2012 23:44:31 +0000 Message-ID: References: <1356755249-19810-1-git-send-email-ben@bwidawsk.net> <1356755249-19810-3-git-send-email-ben@bwidawsk.net> <84c8a8$74vpth@orsmga001.jf.intel.com> <20121229114509.0000701b@unknown> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E92B1E5CC6 for ; Sat, 29 Dec 2012 15:44:34 -0800 (PST) In-Reply-To: <20121229114509.0000701b@unknown> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, 29 Dec 2012 11:45:09 -0800, Ben Widawsky wrote: > On Sat, 29 Dec 2012 11:49:01 +0000 > Chris Wilson wrote: > > > On Fri, 28 Dec 2012 20:27:27 -0800, Ben Widawsky > > wrote: > > > This refactor clearly identifies the GEN specific portion of the > > > aliased ppgtt code. Aside from some of the gen specific parts being > > > extracted, it also preps us for an upcoming patch that pulls out > > > the size, which has some nice benefits. > > > > Error handling looks a little wonky. > > I've not looked in much detail yet, but I'll assume you're right since > I did this pretty quickly. So given that assumption, what do you think > of the patches, useful, or waste of code complexity? The mention of transitioning ppgtt to use objects sounds intriguing, and without digging into the details, does seem a worthwhile design. This series looks fine as a mean of cutting the code up into manageable chunks. -Chris -- Chris Wilson, Intel Open Source Technology Centre