From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 08/13] drm/i915: Pin after setting to the display plane Date: Thu, 14 Apr 2011 22:31:33 +0100 Message-ID: References: <1302771827-26112-1-git-send-email-chris@chris-wilson.co.uk> <1302771827-26112-9-git-send-email-chris@chris-wilson.co.uk> <20110414173416.GE3408@viiv.ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id AB60F9E90A for ; Thu, 14 Apr 2011 14:31:36 -0700 (PDT) In-Reply-To: <20110414173416.GE3408@viiv.ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 14 Apr 2011 19:34:17 +0200, Daniel Vetter wrote: > After the movement all three code-paths suffer from > if (ret) > goto foo_unpin; > before anything is actually pinned. With that fixed, it's My only defense was that was about the third or fifth variation that I tried in a couple of hours with lots of painful rebasing to get the patch flow right... I know for one iteration I had remembered to update the error paths. Oh well, -Chris -- Chris Wilson, Intel Open Source Technology Centre