From: "Christian König" <christian.koenig@amd.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm/ttm, drm/i915: Update ttm_move_memcpy for async use
Date: Mon, 23 Aug 2021 11:09:22 +0200 [thread overview]
Message-ID: <ba3c7bbc-7fb5-396e-4495-a5b2f437431b@amd.com> (raw)
In-Reply-To: <20210813144331.372957-3-thomas.hellstrom@linux.intel.com>
Am 13.08.21 um 16:43 schrieb Thomas Hellström:
> The buffer object argument to ttm_move_memcpy was only used to
> determine whether the destination memory should be cleared only
> or whether we should copy data. Replace it with a "clear" bool, and
> update the callers.
>
> The intention here is to be able to use ttm_move_memcpy() async under
> a dma-fence as a fallback if an accelerated blit fails in a security-
> critical path where data might leak if the blit is not properly
> performed. For that purpose the bo is an unsuitable argument since
> its relevant members might already have changed at call time.
>
> Finally, update the ttm_move_memcpy kerneldoc that seems to have
> ended up with a stale version.
>
> Cc: Christian König <christian.koenig@amd.com>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
> drivers/gpu/drm/ttm/ttm_bo_util.c | 20 ++++++++++----------
> include/drm/ttm/ttm_bo_driver.h | 2 +-
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index d07de18529ab..6995c66cbe21 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -518,7 +518,7 @@ static void __i915_ttm_move(struct ttm_buffer_object *bo, bool clear,
> obj->ttm.cached_io_st,
> src_reg->region.start);
>
> - ttm_move_memcpy(bo, dst_mem->num_pages, dst_iter, src_iter);
> + ttm_move_memcpy(clear, dst_mem->num_pages, dst_iter, src_iter);
> }
> }
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index 763fa6f4e07d..5c20d0541cc3 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -78,22 +78,21 @@ void ttm_mem_io_free(struct ttm_device *bdev,
>
> /**
> * ttm_move_memcpy - Helper to perform a memcpy ttm move operation.
> - * @bo: The struct ttm_buffer_object.
> - * @new_mem: The struct ttm_resource we're moving to (copy destination).
> - * @new_iter: A struct ttm_kmap_iter representing the destination resource.
> + * @clear: Whether to clear rather than copy.
> + * @num_pages: Number of pages of the operation.
> + * @dst_iter: A struct ttm_kmap_iter representing the destination resource.
> * @src_iter: A struct ttm_kmap_iter representing the source resource.
> *
> * This function is intended to be able to move out async under a
> * dma-fence if desired.
> */
> -void ttm_move_memcpy(struct ttm_buffer_object *bo,
> +void ttm_move_memcpy(bool clear,
> u32 num_pages,
> struct ttm_kmap_iter *dst_iter,
> struct ttm_kmap_iter *src_iter)
> {
> const struct ttm_kmap_iter_ops *dst_ops = dst_iter->ops;
> const struct ttm_kmap_iter_ops *src_ops = src_iter->ops;
> - struct ttm_tt *ttm = bo->ttm;
> struct dma_buf_map src_map, dst_map;
> pgoff_t i;
>
> @@ -102,10 +101,7 @@ void ttm_move_memcpy(struct ttm_buffer_object *bo,
> return;
>
> /* Don't move nonexistent data. Clear destination instead. */
> - if (src_ops->maps_tt && (!ttm || !ttm_tt_is_populated(ttm))) {
> - if (ttm && !(ttm->page_flags & TTM_PAGE_FLAG_ZERO_ALLOC))
> - return;
> -
> + if (clear) {
> for (i = 0; i < num_pages; ++i) {
> dst_ops->map_local(dst_iter, &dst_map, i);
> if (dst_map.is_iomem)
> @@ -149,6 +145,7 @@ int ttm_bo_move_memcpy(struct ttm_buffer_object *bo,
> struct ttm_kmap_iter_linear_io io;
> } _dst_iter, _src_iter;
> struct ttm_kmap_iter *dst_iter, *src_iter;
> + bool clear;
> int ret = 0;
>
> if (ttm && ((ttm->page_flags & TTM_PAGE_FLAG_SWAPPED) ||
> @@ -172,7 +169,10 @@ int ttm_bo_move_memcpy(struct ttm_buffer_object *bo,
> goto out_src_iter;
> }
>
> - ttm_move_memcpy(bo, dst_mem->num_pages, dst_iter, src_iter);
> + clear = src_iter->ops->maps_tt && (!ttm || !ttm_tt_is_populated(ttm));
> + if (!(clear && ttm && !(ttm->page_flags & TTM_PAGE_FLAG_ZERO_ALLOC)))
> + ttm_move_memcpy(clear, dst_mem->num_pages, dst_iter, src_iter);
> +
> src_copy = *src_mem;
> ttm_bo_move_sync_cleanup(bo, dst_mem);
>
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 68d6069572aa..5f087575194b 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -322,7 +322,7 @@ int ttm_bo_tt_bind(struct ttm_buffer_object *bo, struct ttm_resource *mem);
> */
> void ttm_bo_tt_destroy(struct ttm_buffer_object *bo);
>
> -void ttm_move_memcpy(struct ttm_buffer_object *bo,
> +void ttm_move_memcpy(bool clear,
> u32 num_pages,
> struct ttm_kmap_iter *dst_iter,
> struct ttm_kmap_iter *src_iter);
next prev parent reply other threads:[~2021-08-23 9:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 14:43 [Intel-gfx] [PATCH v2 0/2] drm/i915, drm/ttm: Update the ttm_move_memcpy() interface Thomas Hellström
2021-08-13 14:43 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/ttm: Reorganize the ttm move code somewhat Thomas Hellström
2021-08-13 14:43 ` [Intel-gfx] [PATCH v2 2/2] drm/ttm, drm/i915: Update ttm_move_memcpy for async use Thomas Hellström
2021-08-23 9:09 ` Christian König [this message]
2021-08-13 16:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915, drm/ttm: Update the ttm_move_memcpy() interface (rev3) Patchwork
2021-08-13 20:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-08-23 7:07 ` Thomas Hellström
2021-08-23 15:38 ` Vudum, Lakshminarayana
2021-08-23 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba3c7bbc-7fb5-396e-4495-a5b2f437431b@amd.com \
--to=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).