From: <Lucien_Kao@compal.com>
To: <tiwai@suse.de>, <nathan.d.ciobanu@linux.intel.com>
Cc: AJ_Cheng@compal.com, alsa-devel@alsa-project.org,
CindyXT_Wang@compal.com, intel-gfx@lists.freedesktop.org,
Nelson_Ye@compal.com, Shane_Yap@compal.com,
Evan_Tseng@compal.com
Subject: Re: [Intel-gfx] [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor
Date: Wed, 8 Jan 2020 03:07:17 +0000 [thread overview]
Message-ID: <bbbfbfa04bd046c78bba621974c9186f@TPEMBX03.compal.com> (raw)
In-Reply-To: <s5h7e23p01c.wl-tiwai@suse.de>
[-- Attachment #1.1: Type: text/html, Size: 7213 bytes --]
[-- Attachment #1.2: Type: text/plain, Size: 3713 bytes --]
Hi Takashi
Is the attachment what you suspect? That merged to our kernel v4.19 already, have any suggestions? Thanks.
-----Original Message-----
From: Takashi Iwai <tiwai@suse.de>
Sent: Wednesday, January 8, 2020 2:57 AM
To: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>
Cc: Kao. Lucien (TPE) <Lucien_Kao@compal.com>; Cheng. AJ (TPE) <AJ_Cheng@compal.com>; intel-gfx@lists.freedesktop.org; alsa-devel@alsa-project.org; Wang. CindyXT (TPE) <CindyXT_Wang@compal.com>; Ye. Nelson (TPE) <Nelson_Ye@compal.com>; Yap. Shane (TPE) <Shane_Yap@compal.com>; Tseng. Evan (TPE) <Evan_Tseng@compal.com>
Subject: Re: [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor
On Tue, 07 Jan 2020 18:24:57 +0100,
Nathan Ciobanu wrote:
>
> On Mon, Jan 06, 2020 at 08:08:04AM +0000, Lucien_Kao@compal.com wrote:
> > Hi Takashi
> >
> > We verified on Ubuntu 19.10 with kernel 5.4.0.0-050400-generic (please refer to attachment), the result is positive which symptom doesn't happen anymore once I played music or video sound output through Dell S2718D Type-C monitor. It seems had some fix in latest kernel.
>
> Takashi, can you point to the patch series you suspect may have fixed this issue?
The first suspect would be
2756d9143aa517b97961e85412882b8ce31371a6
ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips
Takashi
>
> Thanks,
> Nathan
> >
> > Thanks.
> >
> >
> > -----Original Message-----
> > From: Takashi Iwai <tiwai@suse.de>
> > Sent: Friday, January 3, 2020 5:16 PM
> > To: Cheng. AJ (TPE) <AJ_Cheng@compal.com>
> > Cc: intel-gfx@lists.freedesktop.org; alsa-devel@alsa-project.org;
> > nathan.d.ciobanu@linux.intel.com; Wang. CindyXT (TPE)
> > <CindyXT_Wang@compal.com>; Ye. Nelson (TPE) <Nelson_Ye@compal.com>;
> > Yap. Shane (TPE) <Shane_Yap@compal.com>; Kao. Lucien (TPE)
> > <Lucien_Kao@compal.com>; Tseng. Evan (TPE) <Evan_Tseng@compal.com>
> > Subject: Re: [alsa-devel] USB Type-C monitor flashes once when play
> > a video file after unplug and re-plug the monitor
> >
> > On Fri, 03 Jan 2020 02:57:03 +0100,
> > <AJ_Cheng@compal.com> wrote:
> > >
> > > Hi Sirs,
> > > Here is chromebook SW team from Compal.
> > > As the mail title, we hit issue that the external monitor will flash once when play video after hot pluging.
> > > We can reproduce not only on chromebook but also ubuntu 16.04.
> > > There has higher failure rate with Dell Solomon dock and Dell S2718D monitor.
> > >
> > > We found adding the delay in "sound/pci/hda/patch_hdmi.c " can fix
> > > this issue.(as the attachment) May need your help to review and advice. Thanks.
> > >
> > > Here is the issue number in gitlab for more detail.
> > > https://gitlab.freedesktop.org/drm/intel/issues/318
> >
> > Could you check whether it still happens with the latest upstream kernel, at least 5.4.y, if it wasn't tested yet?
> >
> > I don't want to put a long delay just because of random reason unless it's really mandatory. I'm wondering whether the recent write-sync change improves the situation, so let's check the recent code.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > >
> > >
> > >
> > > AJ Cheng
> > > NID/NID1
> > > e-mail: AJ_Cheng@compal.com<mailto:AJ_Cheng@compal.com>
> > > Tel: +886-2-8797-8599 ext. 17561
> > > Mobile : +886-932827829
> > > COMPAL Electronics, Inc.
> > >
> > > [2 flash_once.diff <application/octet-stream (base64)>]
> > >
> > > _______________________________________________
> > > Alsa-devel mailing list
> > > Alsa-devel@alsa-project.org
> > > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
>
[-- Attachment #2: 0001-UPSTREAM-ALSA-hda-Fix-intermittent-CORB-RIRB-stall-o.patch --]
[-- Type: application/octet-stream, Size: 2623 bytes --]
From da6e9a5dbb81f0ce039a2079aa79366a5889d516 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Fri, 19 Jul 2019 10:27:54 +0200
Subject: [PATCH] UPSTREAM: ALSA: hda - Fix intermittent CORB/RIRB stall on
Intel chips
It turned out that the recent Intel HD-audio controller chips show a
significant stall during the system PM resume intermittently. It
doesn't happen so often and usually it may read back successfully
after one or more seconds, but in some rare worst cases the driver
went into fallback mode.
After trial-and-error, we found out that the communication stall seems
covered by issuing the sync after each verb write, as already done for
AMD and other chipsets. So this patch enables the write-sync flag for
the recent Intel chips, Skylake and onward, as a workaround.
Also, since Broxton and co have the very same driver flags as Skylake,
refer to the Skylake driver flags instead of defining the same
contents again for simplification.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201901
Reported-and-tested-by: Todd Brandt <todd.e.brandt@linux.intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit 2756d9143aa517b97961e85412882b8ce31371a6
Link: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
BUG=b:140610533
TEST="run suspend_stress_test for 1000 cycles and only saw one cycle
audio codec suspend time > 1sec"
Change-Id: Ie5173a873e91bcb4fd95d5a1411a4a5fdefb6a56
Signed-off-by: Joyce Toh <joyce.toh@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1827072
Reviewed-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
Reviewed-by: Mathew King <mathewk@chromium.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Tested-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
---
sound/pci/hda/hda_intel.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 18d8018..7c41e63 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -328,11 +328,10 @@ enum {
#define AZX_DCAPS_INTEL_SKYLAKE \
(AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_PM_RUNTIME |\
+ AZX_DCAPS_SYNC_WRITE |\
AZX_DCAPS_SEPARATE_STREAM_TAG | AZX_DCAPS_I915_COMPONENT)
-#define AZX_DCAPS_INTEL_BROXTON \
- (AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_PM_RUNTIME |\
- AZX_DCAPS_SEPARATE_STREAM_TAG | AZX_DCAPS_I915_COMPONENT)
+#define AZX_DCAPS_INTEL_BROXTON AZX_DCAPS_INTEL_SKYLAKE
/* quirks for ATI SB / AMD Hudson */
#define AZX_DCAPS_PRESET_ATI_SB \
--
2.7.4
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-09 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 1:57 [Intel-gfx] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor AJ_Cheng
2020-01-03 9:16 ` [Intel-gfx] [alsa-devel] " Takashi Iwai
2020-01-06 8:08 ` Lucien_Kao
2020-01-07 17:24 ` Nathan Ciobanu
2020-01-07 18:57 ` Takashi Iwai
2020-01-08 3:07 ` Lucien_Kao [this message]
2020-01-08 6:17 ` Takashi Iwai
2020-02-12 9:37 ` Lucien_Kao
2020-02-12 10:03 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbbfbfa04bd046c78bba621974c9186f@TPEMBX03.compal.com \
--to=lucien_kao@compal.com \
--cc=AJ_Cheng@compal.com \
--cc=CindyXT_Wang@compal.com \
--cc=Evan_Tseng@compal.com \
--cc=Nelson_Ye@compal.com \
--cc=Shane_Yap@compal.com \
--cc=alsa-devel@alsa-project.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nathan.d.ciobanu@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).