From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, Inki Dae <inki.dae@samsung.com>,
intel-gfx@lists.freedesktop.org,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: [Intel-gfx] [PATCH 07/12] drm/exynos: fix is_hdmi usage
Date: Thu, 30 Mar 2023 18:39:44 +0300 [thread overview]
Message-ID: <c56e228b8867434554d2fdd3995bfe7f4d8cbb9a.1680190534.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1680190534.git.jani.nikula@intel.com>
drm_connector_update_edid_property() must have been called before to
ensure is_hdmi has been populated.
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index b7c11bdce2c8..d53d511bcc63 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -893,12 +893,13 @@ static int hdmi_get_modes(struct drm_connector *connector)
if (!edid)
return -ENODEV;
+ drm_connector_update_edid_property(connector, edid);
+
hdata->dvi_mode = !connector->display_info.is_hdmi;
DRM_DEV_DEBUG_KMS(hdata->dev, "%s : width[%d] x height[%d]\n",
(hdata->dvi_mode ? "dvi monitor" : "hdmi monitor"),
edid->width_cm, edid->height_cm);
- drm_connector_update_edid_property(connector, edid);
cec_notifier_set_phys_addr_from_edid(hdata->notifier, edid);
ret = drm_add_edid_modes(connector, edid);
--
2.39.2
next prev parent reply other threads:[~2023-03-30 15:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 15:39 [Intel-gfx] [PATCH 00/12] drm: reduce drm_detect_monitor_audio/drm_detect_hdmi_monitor/edid_blob_ptr usage Jani Nikula
2023-03-30 15:39 ` [Intel-gfx] [PATCH 01/12] drm/edid: parse display info has_audio similar to is_hdmi Jani Nikula
2023-03-30 15:39 ` [Intel-gfx] [PATCH 02/12] drm/nouveau: convert to using is_hdmi and has_audio from display info Jani Nikula
2023-03-30 15:39 ` [Intel-gfx] [PATCH 03/12] drm/radeon: " Jani Nikula
2023-03-30 15:39 ` [Intel-gfx] [PATCH 04/12] drm/radeon: remove radeon_connector_edid() and stop using edid_blob_ptr Jani Nikula
2023-03-30 20:13 ` kernel test robot
2023-03-30 20:13 ` kernel test robot
2023-03-31 8:50 ` Jani Nikula
2023-03-30 15:39 ` [Intel-gfx] [PATCH 05/12] drm/amdgpu: remove amdgpu_connector_edid() " Jani Nikula
2023-03-30 15:39 ` [Intel-gfx] [PATCH 06/12] drm/i915/debugfs: " Jani Nikula
2023-03-30 15:39 ` Jani Nikula [this message]
2023-03-30 15:39 ` [Intel-gfx] [PATCH 08/12] drm/i2c/tda998x: convert to using has_audio from display_info Jani Nikula
2023-03-30 15:39 ` [Intel-gfx] [PATCH 09/12] drm/sti/sti_hdmi: convert to using is_hdmi from display info Jani Nikula
2023-03-30 15:39 ` [Intel-gfx] [PATCH 10/12] drm/rockchip: cdn-dp: call drm_connector_update_edid_property() unconditionally Jani Nikula
2023-03-30 16:38 ` Heiko Stübner
2023-03-30 15:39 ` [Intel-gfx] [PATCH 11/12] drm/rockchip: convert to using has_audio from display_info Jani Nikula
2023-03-30 16:39 ` Heiko Stübner
2023-03-30 15:39 ` [Intel-gfx] [PATCH 12/12] drm/connector: update edid_blob_ptr documentation Jani Nikula
2023-03-30 20:12 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: reduce drm_detect_monitor_audio/drm_detect_hdmi_monitor/edid_blob_ptr usage Patchwork
2023-03-30 20:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-31 18:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c56e228b8867434554d2fdd3995bfe7f4d8cbb9a.1680190534.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kyungmin.park@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).