From: Tvrtko Ursulin <firstname.lastname@example.org> To: Daniel Vetter <email@example.com> Cc: intel-gfx <Intelfirstname.lastname@example.org>, dri-devel <email@example.com>, Tvrtko Ursulin <firstname.lastname@example.org>, Chris Wilson <email@example.com>, Joonas Lahtinen <firstname.lastname@example.org>, Matthew Auld <email@example.com>, Eero Tamminen <firstname.lastname@example.org>, Rodrigo Vivi <email@example.com> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled Date: Tue, 7 Sep 2021 10:34:17 +0100 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <YTcmCSr5HJZDeRNH@phenom.ffwll.local> On 07/09/2021 09:42, Daniel Vetter wrote: > On Fri, Sep 03, 2021 at 01:47:52PM +0100, Tvrtko Ursulin wrote: >> >> On 29/07/2021 15:06, Daniel Vetter wrote: >>> On Thu, Jul 29, 2021 at 3:34 PM Tvrtko Ursulin >>> <email@example.com> wrote: >>>> >>>> From: Tvrtko Ursulin <firstname.lastname@example.org> >>>> >>>> Usage of Transparent Hugepages was disabled in 9987da4b5dcf >>>> ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it >>>> appears majority of performance regressions reported with an enabled IOMMU >>>> can be almost eliminated by turning them on, lets just do that. >>>> >>>> To err on the side of safety we keep the current default in cases where >>>> IOMMU is not active, and only when it is default to the "huge=within_size" >>>> mode. Although there probably would be wins to enable them throughout, >>>> more extensive testing across benchmarks and platforms would need to be >>>> done. >>>> >>>> With the patch and IOMMU enabled my local testing on a small Skylake part >>>> shows OglVSTangent regression being reduced from ~14% (IOMMU on versus >>>> IOMMU off) to ~2% (same comparison but with THP on). >>>> >>>> v2: >>>> * Add Kconfig dependency to transparent hugepages and some help text. >>>> * Move to helper for easier handling of kernel build options. >>>> >>>> v3: >>>> * Drop Kconfig. (Daniel) >>>> >>>> References: b901bb89324a ("drm/i915/gemfs: enable THP") >>>> References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") >>>> References: https://gitlab.freedesktop.org/drm/intel/-/issues/430 >>>> Co-developed-by: Chris Wilson <email@example.com> >>>> Signed-off-by: Chris Wilson <firstname.lastname@example.org> >>>> Cc: Joonas Lahtinen <email@example.com> >>>> Cc: Matthew Auld <firstname.lastname@example.org> >>>> Cc: Eero Tamminen <email@example.com> >>>> Cc: Tvrtko Ursulin <firstname.lastname@example.org> >>>> Cc: Rodrigo Vivi <email@example.com> >>>> Cc: Daniel Vetter <firstname.lastname@example.org> >>>> Signed-off-by: Tvrtko Ursulin <email@example.com> >>>> Reviewed-by: Rodrigo Vivi <firstname.lastname@example.org> # v1 >>> >>> On both patches: Acked-by: Daniel Vetter <email@example.com> >> >> Eero's testing results at >> https://gitlab.freedesktop.org/drm/intel/-/issues/430 are looking good - >> seem to show this to be a net win for at least Gen9 and Gen12 platforms. >> >> Is the ack enough to merge in this case or I should look for an r-b as well? > > Since your back to defacto v1 with the 2nd patch I think you have full r-b > already. So more than enough I think. Just in case you missed it, v1 had Kconfig. But it's the same spirit so probably indeed fine as you say. > Please do record the relative perf numbers from Eero in that issue in the > commit message so that we have that on the git log record too. It's easier > to find there than following the link and finding the right comment in the > issue. Will do. Regards, Tvrtko
next prev parent reply other threads:[~2021-09-07 9:34 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-29 13:34 [Intel-gfx] [PATCH 1/2] drm/i915/selftests: fixup igt_shrink_thp Tvrtko Ursulin 2021-07-29 13:34 ` [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled Tvrtko Ursulin 2021-07-29 14:06 ` Daniel Vetter 2021-09-03 12:47 ` Tvrtko Ursulin 2021-09-07 8:42 ` Daniel Vetter 2021-09-07 9:34 ` Tvrtko Ursulin [this message] 2021-07-29 14:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp Patchwork 2021-07-29 14:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-07-29 23:16 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2021-07-29 11:18 [Intel-gfx] [PATCH 1/2] " Tvrtko Ursulin 2021-07-29 11:18 ` [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled Tvrtko Ursulin 2021-07-29 12:07 ` Daniel Vetter 2021-07-29 12:21 ` Tvrtko Ursulin 2021-07-29 12:28 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Intelfirstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).