From: Matthew Auld <matthew.auld@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/7] drm/i915: reserve stolen for LMEM region
Date: Tue, 26 Jan 2021 10:38:50 +0000 [thread overview]
Message-ID: <d211416f-bb7c-b147-5c38-83972f9c40d1@intel.com> (raw)
In-Reply-To: <161165682293.29150.8098339484779184026@build.alporthouse.com>
On 26/01/2021 10:27, Chris Wilson wrote:
> Quoting Matthew Auld (2021-01-26 09:46:07)
>> @@ -162,7 +165,8 @@ setup_lmem(struct drm_i915_private *i915)
>> drm_dbg(&i915->drm, "Intel graphics LMEM: %pR\n", &mem->region);
>> drm_dbg(&i915->drm, "Intel graphics LMEM IO start: %pa\n",
>> &mem->io_start);
>> - drm_info(&i915->drm, "Intel graphics LMEM size: %pa\n", &size);
>> + drm_info(&i915->drm, "Intel graphics LMEM size: %pa\n",
>> + &lmem_size);
>
> LMEM is Intel jargon. Intel is more or less redundant here as we have
> the device and driver already in the message.
>
> drm_info(&i915->drm, "Local memory available: %pa\n", &lmem_size);
Ok, makes sense.
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-26 10:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 9:46 [Intel-gfx] [PATCH 1/7] drm/i915: setup the LMEM region Matthew Auld
2021-01-26 9:46 ` [Intel-gfx] [PATCH 2/7] drm/i915: reserve stolen for " Matthew Auld
2021-01-26 10:27 ` Chris Wilson
2021-01-26 10:38 ` Matthew Auld [this message]
2021-01-26 9:46 ` [Intel-gfx] [PATCH 3/7] drm/i915: introduce mem->reserved Matthew Auld
2021-01-26 9:46 ` [Intel-gfx] [PATCH 4/7] drm/i915/dg1: Reserve first 1MB of local memory Matthew Auld
2021-01-26 9:46 ` [Intel-gfx] [PATCH 5/7] drm/i915: allocate context from LMEM Matthew Auld
2021-01-26 9:46 ` [Intel-gfx] [PATCH 6/7] drm/i915: move engine scratch to LMEM Matthew Auld
2021-01-26 9:46 ` [Intel-gfx] [PATCH 7/7] drm/i915: allocate cmd ring in lmem Matthew Auld
2021-01-26 10:09 ` [Intel-gfx] [PATCH 1/7] drm/i915: setup the LMEM region Tvrtko Ursulin
2021-01-26 10:38 ` Matthew Auld
2021-01-26 10:46 ` Chris Wilson
2021-01-26 10:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] " Patchwork
2021-01-26 10:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-26 10:51 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d211416f-bb7c-b147-5c38-83972f9c40d1@intel.com \
--to=matthew.auld@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).