From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: small semaphore fix Date: Fri, 02 Sep 2011 09:56:31 +0100 Message-ID: References: <1314820042-6169-1-git-send-email-ben@bwidawsk.net> <87wrdsb0o4.fsf@eliezer.anholt.net> <20110901195111.0b338102@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 757739E7B2 for ; Fri, 2 Sep 2011 01:56:38 -0700 (PDT) In-Reply-To: <20110901195111.0b338102@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 1 Sep 2011 19:51:11 -0700, Ben Widawsky wrote: > On Thu, 01 Sep 2011 11:03:07 -0700 > Eric Anholt wrote: > > > On Wed, 31 Aug 2011 12:47:22 -0700, Ben Widawsky > > wrote: > > > Assertion + unsigned helps catch potential issues. > > > > > > From the docs it is hard to tell if the global GTT flag is actually > > > needed, but it shouldn't hurt. > > > > We're updating a register, not the GTT, so I don't see why the flag > > would be relevant. > > The patch is as (ir)relevant as without it which implies PPGTT. The > reason it was there is in another branch I was planning to implement > memory based semaphores. Memory based semaphores required working ppgtt, afaict. -Chris -- Chris Wilson, Intel Open Source Technology Centre