* [Intel-gfx] [PATCH v2] drm/i915: Fix includes and local vars order
@ 2020-05-22 13:18 Stanislav Lisovskiy
2020-05-22 14:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix includes and local vars order (rev2) Patchwork
2020-05-23 3:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Stanislav Lisovskiy @ 2020-05-22 13:18 UTC (permalink / raw)
To: intel-gfx; +Cc: chris
Removed duplicate include and fixed comment > 80 chars.
v2: Added newline after system include and between functions
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
drivers/gpu/drm/i915/display/intel_bw.c | 44 ++++++++++++----------
drivers/gpu/drm/i915/display/intel_bw.h | 2 +-
drivers/gpu/drm/i915/display/intel_cdclk.c | 3 +-
drivers/gpu/drm/i915/display/intel_cdclk.h | 1 +
drivers/gpu/drm/i915/intel_pm.c | 3 +-
drivers/gpu/drm/i915/intel_pm.h | 2 +-
6 files changed, 31 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 8d2f58e39595..a79bd7aeb03b 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -5,13 +5,12 @@
#include <drm/drm_atomic_state_helper.h>
+#include "intel_atomic.h"
#include "intel_bw.h"
-#include "intel_pm.h"
+#include "intel_cdclk.h"
#include "intel_display_types.h"
-#include "intel_sideband.h"
-#include "intel_atomic.h"
#include "intel_pm.h"
-#include "intel_cdclk.h"
+#include "intel_sideband.h"
/* Parameters for Qclk Geyserville (QGV) */
struct intel_qgv_point {
@@ -352,6 +351,7 @@ static unsigned int intel_bw_crtc_data_rate(const struct intel_crtc_state *crtc_
return data_rate;
}
+
void intel_bw_crtc_update(struct intel_bw_state *bw_state,
const struct intel_crtc_state *crtc_state)
{
@@ -431,13 +431,13 @@ intel_atomic_get_bw_state(struct intel_atomic_state *state)
int skl_bw_calc_min_cdclk(struct intel_atomic_state *state)
{
struct drm_i915_private *dev_priv = to_i915(state->base.dev);
- int i;
+ struct intel_bw_state *new_bw_state = NULL;
+ struct intel_bw_state *old_bw_state = NULL;
const struct intel_crtc_state *crtc_state;
struct intel_crtc *crtc;
int max_bw = 0;
int slice_id;
- struct intel_bw_state *new_bw_state = NULL;
- struct intel_bw_state *old_bw_state = NULL;
+ int i;
for_each_new_intel_crtc_in_state(state, crtc, crtc_state, i) {
enum plane_id plane_id;
@@ -463,14 +463,17 @@ int skl_bw_calc_min_cdclk(struct intel_atomic_state *state)
dbuf_mask |= skl_ddb_dbuf_slice_mask(dev_priv, uv_plane_alloc);
/*
- * FIXME: To calculate that more properly we probably need to
- * to split per plane data_rate into data_rate_y and data_rate_uv
- * for multiplanar formats in order not to get accounted those twice
- * if they happen to reside on different slices.
- * However for pre-icl this would work anyway because we have only single
- * slice and for icl+ uv plane has non-zero data rate.
- * So in worst case those calculation are a bit pessimistic, which
- * shouldn't pose any significant problem anyway.
+ * FIXME: To calculate that more properly we probably
+ * need to to split per plane data_rate into data_rate_y
+ * and data_rate_uv for multiplanar formats in order not
+ * to get accounted those twice if they happen to reside
+ * on different slices.
+ * However for pre-icl this would work anyway because
+ * we have only single slice and for icl+ uv plane has
+ * non-zero data rate.
+ * So in worst case those calculation are a bit
+ * pessimistic, which shouldn't pose any significant
+ * problem anyway.
*/
for_each_dbuf_slice_in_mask(slice_id, dbuf_mask)
crtc_bw->used_bw[slice_id] += data_rate;
@@ -478,11 +481,12 @@ int skl_bw_calc_min_cdclk(struct intel_atomic_state *state)
for_each_dbuf_slice(slice_id) {
/*
- * Current experimental observations show that contrary to BSpec
- * we get underruns once we exceed 64 * CDCLK for slices in total.
- * As a temporary measure in order not to keep CDCLK bumped up all the
- * time we calculate CDCLK according to this formula for overall bw
- * consumed by slices.
+ * Current experimental observations show that contrary
+ * to BSpec we get underruns once we exceed 64 * CDCLK
+ * for slices in total.
+ * As a temporary measure in order not to keep CDCLK
+ * bumped up all the time we calculate CDCLK according
+ * to this formula for overall bw consumed by slices.
*/
max_bw += crtc_bw->used_bw[slice_id];
}
diff --git a/drivers/gpu/drm/i915/display/intel_bw.h b/drivers/gpu/drm/i915/display/intel_bw.h
index af1a981dec84..46c6eecbd917 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.h
+++ b/drivers/gpu/drm/i915/display/intel_bw.h
@@ -9,8 +9,8 @@
#include <drm/drm_atomic.h>
#include "intel_display.h"
-#include "intel_global_state.h"
#include "intel_display_power.h"
+#include "intel_global_state.h"
struct drm_i915_private;
struct intel_atomic_state;
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index dda9bae02a86..f9b0fc7317de 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -22,11 +22,12 @@
*/
#include <linux/time.h>
+
#include "intel_atomic.h"
+#include "intel_bw.h"
#include "intel_cdclk.h"
#include "intel_display_types.h"
#include "intel_sideband.h"
-#include "intel_bw.h"
/**
* DOC: CDCLK / RAWCLK
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.h b/drivers/gpu/drm/i915/display/intel_cdclk.h
index d62e11d620c0..5731806e4cee 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.h
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.h
@@ -7,6 +7,7 @@
#define __INTEL_CDCLK_H__
#include <linux/types.h>
+
#include "i915_drv.h"
#include "intel_display.h"
#include "intel_global_state.h"
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 937d91c28de9..79b673e6051e 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -33,6 +33,7 @@
#include <drm/drm_plane_helper.h>
#include "display/intel_atomic.h"
+#include "display/intel_bw.h"
#include "display/intel_display_types.h"
#include "display/intel_fbc.h"
#include "display/intel_sprite.h"
@@ -43,7 +44,7 @@
#include "i915_fixed.h"
#include "i915_irq.h"
#include "i915_trace.h"
-#include "display/intel_bw.h"
+
#include "intel_pm.h"
#include "intel_sideband.h"
#include "../../../platform/x86/intel_ips.h"
diff --git a/drivers/gpu/drm/i915/intel_pm.h b/drivers/gpu/drm/i915/intel_pm.h
index d665bf77ae80..a2473594c2db 100644
--- a/drivers/gpu/drm/i915/intel_pm.h
+++ b/drivers/gpu/drm/i915/intel_pm.h
@@ -8,10 +8,10 @@
#include <linux/types.h>
+#include "display/intel_bw.h"
#include "display/intel_global_state.h"
#include "i915_reg.h"
-#include "display/intel_bw.h"
struct drm_device;
struct drm_i915_private;
--
2.24.1.485.gad05a3d8e5
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix includes and local vars order (rev2)
2020-05-22 13:18 [Intel-gfx] [PATCH v2] drm/i915: Fix includes and local vars order Stanislav Lisovskiy
@ 2020-05-22 14:04 ` Patchwork
2020-05-23 3:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-05-22 14:04 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix includes and local vars order (rev2)
URL : https://patchwork.freedesktop.org/series/77555/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8525 -> Patchwork_17759
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/index.html
Changes
-------
No changes found
Participating hosts (46 -> 41)
------------------------------
Missing (5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8525 -> Patchwork_17759
CI-20190529: 20190529
CI_DRM_8525: 56110c7afae3bbeb681960494b92b745c6802e1f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5675: 74f7488fe4f8acf901b18fc9c6c4d45a972dcad5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17759: cf01279ccf923a066f5fc2cab3bf2a0fab76c497 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
cf01279ccf92 drm/i915: Fix includes and local vars order
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix includes and local vars order (rev2)
2020-05-22 13:18 [Intel-gfx] [PATCH v2] drm/i915: Fix includes and local vars order Stanislav Lisovskiy
2020-05-22 14:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix includes and local vars order (rev2) Patchwork
@ 2020-05-23 3:47 ` Patchwork
2020-05-25 7:14 ` Lisovskiy, Stanislav
1 sibling, 1 reply; 4+ messages in thread
From: Patchwork @ 2020-05-23 3:47 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix includes and local vars order (rev2)
URL : https://patchwork.freedesktop.org/series/77555/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8525_full -> Patchwork_17759_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17759_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17759_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17759_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_plane_cursor@pipe-c-viewport-size-128:
- shard-iclb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb7/igt@kms_plane_cursor@pipe-c-viewport-size-128.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb4/igt@kms_plane_cursor@pipe-c-viewport-size-128.html
#### Warnings ####
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-glk: [DMESG-FAIL][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-glk1/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-glk2/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-toggle:
- shard-glk: [DMESG-FAIL][5] ([i915#1186]) -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-glk5/igt@kms_cursor_legacy@cursorb-vs-flipa-toggle.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-glk8/igt@kms_cursor_legacy@cursorb-vs-flipa-toggle.html
Known issues
------------
Here are the changes found in Patchwork_17759_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_suspend@forcewake:
- shard-skl: [PASS][7] -> [INCOMPLETE][8] ([i915#69])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl10/igt@i915_suspend@forcewake.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl8/igt@i915_suspend@forcewake.html
* igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#52] / [i915#54])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb7/igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb4/igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [PASS][13] -> [INCOMPLETE][14] ([i915#155])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145] / [i915#265])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
#### Possible fixes ####
* {igt@gem_ctx_isolation@preservation-s3@rcs0}:
- shard-apl: [DMESG-WARN][21] ([i915#180]) -> [PASS][22] +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl6/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl3/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@i915_suspend@sysfs-reader:
- shard-skl: [INCOMPLETE][23] ([i915#69]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl2/igt@i915_suspend@sysfs-reader.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl3/igt@i915_suspend@sysfs-reader.html
* {igt@kms_flip@flip-vs-suspend-interruptible@a-dp1}:
- shard-kbl: [DMESG-WARN][25] ([i915#180]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* {igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1}:
- shard-skl: [FAIL][27] -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][29] ([fdo#108145] / [i915#265]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][31] ([fdo#109441]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
#### Warnings ####
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [FAIL][33] ([i915#454]) -> [SKIP][34] ([i915#468])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-tglb7/igt@i915_pm_dc@dc6-dpms.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_content_protection@atomic:
- shard-apl: [FAIL][35] ([fdo#110321] / [fdo#110336]) -> [FAIL][36] ([fdo#110321] / [fdo#110336] / [i915#95])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl7/igt@kms_content_protection@atomic.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl6/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@srm:
- shard-apl: [FAIL][37] ([fdo#110321]) -> [TIMEOUT][38] ([i915#1319])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl6/igt@kms_content_protection@srm.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl8/igt@kms_content_protection@srm.html
* igt@kms_sysfs_edid_timing:
- shard-apl: [FAIL][39] ([IGT#2]) -> [FAIL][40] ([IGT#2] / [i915#95])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl8/igt@kms_sysfs_edid_timing.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl7/igt@kms_sysfs_edid_timing.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[i915#1186]: https://gitlab.freedesktop.org/drm/intel/issues/1186
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8525 -> Patchwork_17759
CI-20190529: 20190529
CI_DRM_8525: 56110c7afae3bbeb681960494b92b745c6802e1f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5675: 74f7488fe4f8acf901b18fc9c6c4d45a972dcad5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17759: cf01279ccf923a066f5fc2cab3bf2a0fab76c497 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix includes and local vars order (rev2)
2020-05-23 3:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-05-25 7:14 ` Lisovskiy, Stanislav
0 siblings, 0 replies; 4+ messages in thread
From: Lisovskiy, Stanislav @ 2020-05-25 7:14 UTC (permalink / raw)
To: intel-gfx, Vudum, Lakshminarayana
Hi,
This patch is just changing the order of includes and couple of vars moved.
That is the case when it is pure 100% that it is false positive.
Best Regards,
Lisovskiy Stanislav
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
________________________________________
From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Saturday, May 23, 2020 6:47:42 AM
To: Lisovskiy, Stanislav
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.IGT: failure for drm/i915: Fix includes and local vars order (rev2)
== Series Details ==
Series: drm/i915: Fix includes and local vars order (rev2)
URL : https://patchwork.freedesktop.org/series/77555/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8525_full -> Patchwork_17759_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17759_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17759_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17759_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_plane_cursor@pipe-c-viewport-size-128:
- shard-iclb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb7/igt@kms_plane_cursor@pipe-c-viewport-size-128.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb4/igt@kms_plane_cursor@pipe-c-viewport-size-128.html
#### Warnings ####
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-glk: [DMESG-FAIL][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-glk1/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-glk2/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-toggle:
- shard-glk: [DMESG-FAIL][5] ([i915#1186]) -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-glk5/igt@kms_cursor_legacy@cursorb-vs-flipa-toggle.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-glk8/igt@kms_cursor_legacy@cursorb-vs-flipa-toggle.html
Known issues
------------
Here are the changes found in Patchwork_17759_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_suspend@forcewake:
- shard-skl: [PASS][7] -> [INCOMPLETE][8] ([i915#69])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl10/igt@i915_suspend@forcewake.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl8/igt@i915_suspend@forcewake.html
* igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#52] / [i915#54])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb7/igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb4/igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [PASS][13] -> [INCOMPLETE][14] ([i915#155])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145] / [i915#265])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
#### Possible fixes ####
* {igt@gem_ctx_isolation@preservation-s3@rcs0}:
- shard-apl: [DMESG-WARN][21] ([i915#180]) -> [PASS][22] +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl6/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl3/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@i915_suspend@sysfs-reader:
- shard-skl: [INCOMPLETE][23] ([i915#69]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl2/igt@i915_suspend@sysfs-reader.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl3/igt@i915_suspend@sysfs-reader.html
* {igt@kms_flip@flip-vs-suspend-interruptible@a-dp1}:
- shard-kbl: [DMESG-WARN][25] ([i915#180]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* {igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1}:
- shard-skl: [FAIL][27] -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][29] ([fdo#108145] / [i915#265]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][31] ([fdo#109441]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
#### Warnings ####
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [FAIL][33] ([i915#454]) -> [SKIP][34] ([i915#468])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-tglb7/igt@i915_pm_dc@dc6-dpms.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_content_protection@atomic:
- shard-apl: [FAIL][35] ([fdo#110321] / [fdo#110336]) -> [FAIL][36] ([fdo#110321] / [fdo#110336] / [i915#95])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl7/igt@kms_content_protection@atomic.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl6/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@srm:
- shard-apl: [FAIL][37] ([fdo#110321]) -> [TIMEOUT][38] ([i915#1319])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl6/igt@kms_content_protection@srm.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl8/igt@kms_content_protection@srm.html
* igt@kms_sysfs_edid_timing:
- shard-apl: [FAIL][39] ([IGT#2]) -> [FAIL][40] ([IGT#2] / [i915#95])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl8/igt@kms_sysfs_edid_timing.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl7/igt@kms_sysfs_edid_timing.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[i915#1186]: https://gitlab.freedesktop.org/drm/intel/issues/1186
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8525 -> Patchwork_17759
CI-20190529: 20190529
CI_DRM_8525: 56110c7afae3bbeb681960494b92b745c6802e1f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5675: 74f7488fe4f8acf901b18fc9c6c4d45a972dcad5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17759: cf01279ccf923a066f5fc2cab3bf2a0fab76c497 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-25 7:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 13:18 [Intel-gfx] [PATCH v2] drm/i915: Fix includes and local vars order Stanislav Lisovskiy
2020-05-22 14:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix includes and local vars order (rev2) Patchwork
2020-05-23 3:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-05-25 7:14 ` Lisovskiy, Stanislav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).