From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B96C433E2 for ; Fri, 17 Jul 2020 13:07:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4494F2070A for ; Fri, 17 Jul 2020 13:07:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4494F2070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0119B6E459; Fri, 17 Jul 2020 13:07:05 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AB2A6E459 for ; Fri, 17 Jul 2020 13:07:03 +0000 (UTC) IronPort-SDR: 0O+eG7NvHF2qJTbW1AnFPnHP7mGsmWWMW2xXawwunnO2/sgM2DHiSS2HQr+s0bQU5URtQ8DuTc 8M/bxr8CD+Pg== X-IronPort-AV: E=McAfee;i="6000,8403,9684"; a="147566736" X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="147566736" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2020 06:07:02 -0700 IronPort-SDR: v3OJV/ebEZo7r/6jbLq3dRPjKQSmwjiEx488KCyc/2nQa+6xn0bkwQnYNfYztxEr1bED8GLCOE WVZU81bNTSaA== X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="460842098" Received: from gpanagop-mobl.ger.corp.intel.com (HELO [10.249.33.238]) ([10.249.33.238]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2020 06:07:01 -0700 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20200715115147.11866-1-chris@chris-wilson.co.uk> <20200715115147.11866-6-chris@chris-wilson.co.uk> <173d852e-045a-86aa-a030-4bf564bcd6b3@linux.intel.com> <159498993456.13677.10695414817035509543@build.alporthouse.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Fri, 17 Jul 2020 14:06:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <159498993456.13677.10695414817035509543@build.alporthouse.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 06/66] drm/i915: Export a preallocate variant of i915_active_acquire() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 17/07/2020 13:45, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2020-07-17 13:21:54) >> >> On 15/07/2020 12:50, Chris Wilson wrote: >>> Sometimes we have to be very careful not to allocate underneath a mutex >>> (or spinlock) and yet still want to track activity. Enter >>> i915_active_acquire_for_context(). This raises the activity counter on >>> i915_active prior to use and ensures that the fence-tree contains a slot >>> for the context. >> >> Changelog? > > "Time spent with perf trying to reduce holdtime of certain mutexes we > will introduce, in particular focusing on reducing the number of atomics > required for typical i915_active lookups" Why not, then I would had at least known nothing from my previous round feedback so easier review. Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx