From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915: optimize the shmem_pwrite slowpath handling
Date: Thu, 15 Nov 2012 15:02:05 +0000 [thread overview]
Message-ID: <eeac1e$50u8m3@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1352990406-3039-2-git-send-email-daniel.vetter@ffwll.ch>
On Thu, 15 Nov 2012 15:40:06 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Since we drop dev->struct_mutex when going through the slowpath, the
> object might have been moved out of the cpu domain. Hence we need to
> clflush the entire object to ensure that after the ioctl returns,
> everything is coherent again (interwoven writes are ill-defined
> anyway).
>
> But we only need to do this if we start in the cpu domain and the
> object requires flushing for coherency. So don't do the flushing if
> the object is coherent anyway or if we've done in-line clfushing
> already.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Technically true, but we do we care enough to add the extra line of
confusion? Not sold on this one yet, maybe it will be neater in future?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-15 15:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 14:40 [PATCH 1/2] drm/i915: simplify shmem pwrite/pread slowpath handling Daniel Vetter
2012-11-15 14:40 ` [PATCH 2/2] drm/i915: optimize the shmem_pwrite " Daniel Vetter
2012-11-15 15:00 ` Chris Wilson
2012-11-15 15:02 ` Chris Wilson [this message]
2012-11-15 15:20 ` [PATCH] " Daniel Vetter
2012-11-15 15:37 ` Chris Wilson
2012-11-15 15:53 ` Daniel Vetter
2012-11-15 16:07 ` Chris Wilson
2012-11-29 12:49 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eeac1e$50u8m3@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).