Intel-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: Andy Lutomirski <luto@MIT.EDU>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Dave Airlie <airlied@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915: Revert i915.semaphore=1 default from 47ae63e0
Date: Fri, 13 May 2011 12:14:54 -0400
Message-ID: <efc5a05bb650e18fb9fb6976d0f8a999536e38f0.1305303009.git.luto@mit.edu> (raw)
In-Reply-To: <BANLkTikjUQWgveWjoR=uPO5UQXkTTysxng@mail.gmail.com>

My Q67 / i7-2600 box has rev09 Sandy Bridge graphics.  It hangs
instantly when GNOME loads and it hangs so hard the reset button
doesn't work.  Setting i915.semaphore=0 fixes it.

Semaphores were disabled in a1656b9090f7008d2941c314f5a64724bea2ae37
in 2.6.38 and were re-enabled by

commit 47ae63e0c2e5fdb582d471dc906eb29be94c732f
Merge: c59a333 467cffb
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Mar 7 12:32:44 2011 +0000

    Merge branch 'drm-intel-fixes' into drm-intel-next

    Apply the trivial conflicting regression fixes, but keep GPU semaphores
    enabled.

    Conflicts:
        drivers/gpu/drm/i915/i915_drv.h
        drivers/gpu/drm/i915/i915_gem_execbuffer.c

(It's worth noting that the offending change is i915_drv.c,
 which is not a conflict.)

Signed-off-by: Andy Lutomirski <luto@mit.edu>
---

This fixes a 2.6.39 regression that affects my Q67 box but not
my SNB laptop.

Send to Linus and airlied because 2.6.39 is apparently about to
be released.

 drivers/gpu/drm/i915/i915_drv.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index c34a8dd..32d1b3e 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -49,7 +49,7 @@ module_param_named(panel_ignore_lid, i915_panel_ignore_lid, int, 0600);
 unsigned int i915_powersave = 1;
 module_param_named(powersave, i915_powersave, int, 0600);
 
-unsigned int i915_semaphores = 1;
+unsigned int i915_semaphores = 0;
 module_param_named(semaphores, i915_semaphores, int, 0600);
 
 unsigned int i915_enable_rc6 = 0;
-- 
1.7.5.1

  reply index

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13  5:38 [2.6.39 regression] hard lock when GNOME starts Andrew Lutomirski
2011-05-13 16:07 ` Andrew Lutomirski
2011-05-13 16:14   ` Andy Lutomirski [this message]
2011-05-15 23:09     ` [PATCH] drm/i915: Revert i915.semaphore=1 default from 47ae63e0 Keith Packard
2011-05-19 19:56     ` Keith Packard
2011-05-19 20:50       ` Andrew Lutomirski
2011-05-24 17:10         ` Andrew Lutomirski
2011-05-24 17:46           ` Keith Packard
2011-05-24 20:05           ` Ivan Bulatovic
2011-06-07  7:12         ` Eric Anholt
2011-06-10 14:06           ` Andrew Lutomirski
2011-08-22 16:53             ` Jesse Barnes
2011-08-31 18:24               ` Ben Widawsky
2011-08-31 18:30               ` Andrew Lutomirski
2011-08-31 19:07                 ` Keith Packard
2011-08-31 19:37                   ` Andrew Lutomirski
2011-09-26 17:59                     ` [PATCH] drm/i915: kicking rings considered harmful Daniel Vetter
2011-09-26 19:07                       ` Andrew Lutomirski
2011-09-27  9:57                         ` Daniel Vetter
2011-09-27  5:22                       ` Ben Widawsky
2011-09-27 10:03                         ` Daniel Vetter
2011-09-27 16:46                           ` Ben Widawsky
2011-09-27 17:31                             ` Chris Wilson
2011-09-27 18:03                               ` Daniel Vetter
2011-09-27 19:38                                 ` Ben Widawsky
2011-09-27 21:54                                   ` Chris Wilson
2011-09-28  1:34                                     ` Ben Widawsky
2011-09-28  8:47                                       ` Chris Wilson
2011-09-28  8:53                                         ` Daniel Vetter
2011-10-03 20:21                                           ` Andrew Lutomirski
2011-10-03 21:02                                             ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efc5a05bb650e18fb9fb6976d0f8a999536e38f0.1305303009.git.luto@mit.edu \
    --to=luto@mit.edu \
    --cc=airlied@redhat.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Intel-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/intel-gfx/0 intel-gfx/git/0.git
	git clone --mirror https://lore.kernel.org/intel-gfx/1 intel-gfx/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 intel-gfx intel-gfx/ https://lore.kernel.org/intel-gfx \
		intel-gfx@lists.freedesktop.org
	public-inbox-index intel-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.intel-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git