From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/3] drm/i915: Fix MI_DISPLAY_FLIP plane select offset on Ivybridge. Date: Wed, 08 Jun 2011 10:36:57 +0100 Message-ID: References: <1307487281-3015-1-git-send-email-kenneth@whitecape.org> <4DEEC869.7020707@whitecape.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C5459E935 for ; Wed, 8 Jun 2011 02:37:00 -0700 (PDT) In-Reply-To: <4DEEC869.7020707@whitecape.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Kenneth Graunke , Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 07 Jun 2011 17:55:05 -0700, Kenneth Graunke wrote: > On 06/07/2011 04:14 PM, Keith Packard wrote: > > What's this last DWORD supposed to be for? The IVB spec says length > > should be '1' and there should be only 3 DWORDS in this command. > > Good question. My reading of the docs say that it should be 3 DWORDs on > SNB as well; this code was directly lifted from "case 6" above (save the > first line). In my ancient copy of the specs, MI_DISPLAY_FLIP is 4 dwords, with this last dword for programming the panel-fitter and pipesrc. And it also says that command is applicable to IVB, but as I said it is an ancient copy. -Chris -- Chris Wilson, Intel Open Source Technology Centre