From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>, Carl Worth <cworth@cworth.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/10] intel: shared header for shader debugging
Date: Wed, 13 Jul 2011 21:56:40 +0100 [thread overview]
Message-ID: <f80fcd$sjkr2@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1310590312-21669-2-git-send-email-ben@bwidawsk.net>
[-- Attachment #1: Type: text/plain, Size: 2926 bytes --]
On Wed, 13 Jul 2011 13:51:43 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
> intel/Makefile.am | 3 ++-
> intel/intel_debug.h | 44 ++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 46 insertions(+), 1 deletions(-)
>
> diff --git a/intel/Makefile.am b/intel/Makefile.am
> index b6a9014..7a44aaf 100644
> --- a/intel/Makefile.am
> +++ b/intel/Makefile.am
> @@ -45,6 +45,7 @@ libdrm_intel_la_SOURCES = \
> mm.h
>
> libdrm_intelincludedir = ${includedir}/libdrm
> -libdrm_intelinclude_HEADERS = intel_bufmgr.h
> +libdrm_intelinclude_HEADERS = intel_bufmgr.h \
> + intel_debug.h
>
> pkgconfig_DATA = libdrm_intel.pc
> diff --git a/intel/intel_debug.h b/intel/intel_debug.h
> new file mode 100644
> index 0000000..42ea1d8
> --- /dev/null
> +++ b/intel/intel_debug.h
> @@ -0,0 +1,44 @@
> +/*
> + * Copyright © 2011 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + * Ben Widawsky <ben@bwidawsk.net>
> + *
> + */
> +
> +#ifndef INTEL_DEBUG_H
> +#define INTEL_DEBUG_H
> +
> +#include <stdint.h>
> +
> +#define SHADER_DEBUG_SOCKET "/tmp/gen_debug"
> +#define DEBUG_HANDSHAKE_VERSION 0x2
> +#define DEBUG_HANDSHAKE_ACK "okay"
> +
> +/* First byte must always be the 1 byte version */
> +struct debug_handshake {
> + uint8_t version;
> + int flink_handle;
> + uint32_t per_thread_scratch;
> +} __attribute__((packed));
Let's use an intel_ namespace to avoid any potential confusion. Do you
want to reserve the first uint32_t for your protocol header? Then it at
least looks like the hole will be useful in future...
I'm not overly thrilled by intel_debug.h, it's so generic but I can't
think of anything better.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2011-07-13 20:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 20:51 [PATCH 0/10] fs shader debugging Ben Widawsky
2011-07-13 20:51 ` [PATCH 01/10] intel: shared header for " Ben Widawsky
2011-07-13 20:56 ` Chris Wilson [this message]
2011-07-19 21:06 ` [Intel-gfx] " Julien Cristau
2011-07-21 13:54 ` Ben Widawsky
2011-07-21 21:22 ` [Intel-gfx] " Julien Cristau
2011-07-27 15:08 ` Ben Widawsky
2011-07-27 15:16 ` Julien Cristau
2011-07-27 15:28 ` Alan Cox
2011-07-27 15:40 ` Ben Widawsky
2011-07-13 20:51 ` [PATCH 02/10] i965: copy in system routine, reserve extra scratch Ben Widawsky
2011-07-18 18:13 ` Eric Anholt
2011-07-13 20:51 ` [PATCH 03/10] i965: Reserve scratch space for debugger communication Ben Widawsky
2011-07-13 20:51 ` [PATCH 04/10] i965: setup system routine Ben Widawsky
2011-07-13 21:04 ` [Mesa-dev] " Chris Wilson
2011-07-13 20:51 ` [PATCH 05/10] i965: emit breakpoints Ben Widawsky
2011-07-13 20:51 ` [PATCH 06/10] i965: attach to a listening debugger Ben Widawsky
2011-07-13 20:51 ` [PATCH 07/10] intel-gpu-tools: register range handling for forcewake hooks Ben Widawsky
2011-07-13 21:15 ` Chris Wilson
2011-07-13 20:51 ` [PATCH 08/10] intel-gpu-tools/forcewaked: simple forcewake app Ben Widawsky
2011-07-13 21:18 ` Chris Wilson
2011-07-13 20:51 ` [PATCH 09/10] debugging: add important debug regs Ben Widawsky
2011-07-13 21:20 ` Chris Wilson
2011-07-13 20:51 ` [PATCH 10/10] debugging: shader debugging Ben Widawsky
2011-07-13 22:06 ` [PATCH 0/10] fs " Ben Widawsky
2011-07-17 23:25 [PATCH 00/10] fs debugging: incorporated Chris' feedback Ben Widawsky
2011-07-17 23:25 ` [PATCH 01/10] intel: shared header for shader debugging Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f80fcd$sjkr2@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=cworth@cworth.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).