From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 1/7] drm: Fill in more of the DisplayPort DPCD registers Date: Tue, 12 Jul 2011 15:42:11 -0700 Message-ID: References: <1310506685-855-1-git-send-email-ajax@redhat.com> <1310506685-855-2-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1954192539==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 274DC9EB4C for ; Tue, 12 Jul 2011 15:42:18 -0700 (PDT) In-Reply-To: <1310506685-855-2-git-send-email-ajax@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1954192539== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 12 Jul 2011 17:37:59 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson > +# define DP_DWN_STRM_PORT_TYPE_TMDS (2 << 1) This could be labeled TYPE_DVI_OR_HDMI according to the DP 1.1a spec. > - I find the blank lines useful in this file; they separate lists of values for different fields. > -#define DP_INTERLANE_ALIGN_DONE (1 << 0) > -#define DP_DOWNSTREAM_PORT_STATUS_CHANGED (1 << 6) > -#define DP_LINK_STATUS_UPDATED (1 << 7) > +# define DP_INTERLANE_ALIGN_DONE (1 << 0) > +# define DP_DOWNSTREAM_PORT_STATUS_CHANGED (1 << 6) > +# define DP_LINK_STATUS_UPDATED (1 << 7) >=20=20 > #define DP_SINK_STATUS 0x205 > - > -#define DP_RECEIVE_PORT_0_STATUS (1 << 0) > -#define DP_RECEIVE_PORT_1_STATUS (1 << 1) > +# define DP_RECEIVE_PORT_0_STATUS (1 << 0) > +# define DP_RECEIVE_PORT_1_STATUS (1 << 1) >=20=20 > #define DP_ADJUST_REQUEST_LANE0_1 0x206 > #define DP_ADJUST_REQUEST_LANE2_3 0x207 Please make a separate patch for whitespace cleanups... Otherwise, these changes all match the DP 1.1a spec that I compared them with. Reviewed-by: Keith Packard =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOHM3DQp8BWwlsTdMRAu/OAKDXvnBn70rdmozc2ME1tcqrG6+GjQCdEDMT YGfoyzJFKib33nExOG1IfwI= =nbD2 -----END PGP SIGNATURE----- --=-=-=-- --===============1954192539== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1954192539==--