From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/i915: Initialise g4x watermarks for disabled pipes
Date: Tue, 05 Apr 2011 13:56:37 -0700 [thread overview]
Message-ID: <yunmxk4fmd6.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1301995458-2699-2-git-send-email-chris@chris-wilson.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 584 bytes --]
On Tue, 5 Apr 2011 10:24:14 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> crtc = intel_get_crtc_for_plane(dev, plane);
> - if (crtc->fb == NULL || !crtc->enabled)
> + if (crtc->fb == NULL || !crtc->enabled) {
> + *cursor_wm = *plane_wm = display->guard_size;
> return false;
> + }
Would it be clearer to have g4x_update_wm set these instead?
I'm also a bit concerned about the default value; it would be lovely to
have the docs say what the value should be for disabled pipes, but I
couldn't find any mention of them.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-04-05 20:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 9:24 i915 fixes for review Chris Wilson
2011-04-05 9:24 ` [PATCH 1/5] drm/i915: Initialise g4x watermarks for disabled pipes Chris Wilson
2011-04-05 20:56 ` Keith Packard [this message]
2011-04-05 21:12 ` Chris Wilson
2011-04-06 1:02 ` Keith Packard
2011-04-06 6:59 ` Chris Wilson
2011-04-06 7:36 ` Keith Packard
2011-04-06 8:02 ` Chris Wilson
2011-04-06 15:12 ` Keith Packard
2011-04-05 9:24 ` [PATCH 2/5] drm/i915/crt: Explicitly return false if connected to a digital monitor Chris Wilson
2011-04-05 20:57 ` Keith Packard
2011-04-05 9:24 ` [PATCH 3/5] drm/i915/crt: Remove 0xa0 probe for VGA Chris Wilson
2011-04-05 9:24 ` [PATCH 4/5] drm/i915/lvds: Remove 0xA0 DDC probe for LVDS Chris Wilson
2011-04-05 9:24 ` [PATCH 5/5] drm/i915/gmbus: Reset the controller on initialisation Chris Wilson
2011-04-05 16:18 ` Ben Widawsky
2011-04-05 16:27 ` Ben Widawsky
2011-04-05 20:59 ` Keith Packard
2011-04-05 21:26 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunmxk4fmd6.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).