From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 1/3] drm/i915: Fix MI_DISPLAY_FLIP plane select offset on Ivybridge. Date: Tue, 07 Jun 2011 16:14:38 -0700 Message-ID: References: <1307487281-3015-1-git-send-email-kenneth@whitecape.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2141177869==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id DD88F9E75B for ; Tue, 7 Jun 2011 16:14:41 -0700 (PDT) In-Reply-To: <1307487281-3015-1-git-send-email-kenneth@whitecape.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Kenneth Graunke , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2141177869== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 7 Jun 2011 15:54:39 -0700, Kenneth Graunke = wrote: > According to BSpec volume 1c.4 section 3.2.9, Display (Plane) Select is > now at bits 21:19 instead of 21:20. >=20 > Signed-off-by: Kenneth Graunke I will note that the docs have an obvious bug -- 21:8 are 'reserved' on IVB while 21:19 are 'Display (Plane) Select'. I trust you've actually tried this on hardware and noticed that it works better now? > + > + case 7: > + OUT_RING(MI_DISPLAY_FLIP | (intel_crtc->plane << 19)); > + OUT_RING(fb->pitch | obj->tiling_mode); > + OUT_RING(obj->gtt_offset); > + > + pf =3D I915_READ(PF_CTL(pipe)) & PF_ENABLE; > + pipesrc =3D I915_READ(PIPESRC(pipe)) & 0x0fff0fff; > + OUT_RING(pf | pipesrc); What's this last DWORD supposed to be for? The IVB spec says length should be '1' and there should be only 3 DWORDS in this command. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFN7rDeQp8BWwlsTdMRAiTEAJsHjodZq3hbr6WOM5O1viGIooypSACfZ02s Ek2kZPrvoDDwTt0IpYyZmrQ= =P8aT -----END PGP SIGNATURE----- --=-=-=-- --===============2141177869== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2141177869==--