From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 1/2] drm/i915: Prefault all pages for pread and pwrite Date: Sat, 09 Jul 2011 13:21:48 -0700 Message-ID: References: <1310200731-18086-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1158660090==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A5969F4BD for ; Sat, 9 Jul 2011 13:21:59 -0700 (PDT) In-Reply-To: <1310200731-18086-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1158660090== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Sat, 9 Jul 2011 09:38:50 +0100, Chris Wilson = wrote: > +static int prefault_writeable(unsigned long uaddr, unsigned long len) > +static int prefault_readable(unsigned long uaddr, unsigned long len) These seems like a functions which belongs alongside (or in place of) the existing fault_in_pages_writable and fault_in_pages_readable functions. I think, in fact, that one could convincingly argue that the existing functions are misleadingly named (or just broken). =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOGLhcQp8BWwlsTdMRAh08AKDd9jvaCcPK4uIB3uCCPn71rS6QPwCgoot1 P/qvMQQGMCgwuqPpRDDjFn0= =t0et -----END PGP SIGNATURE----- --=-=-=-- --===============1158660090== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1158660090==--