intel-wired-lan.lists.osuosl.org archive mirror
 help / color / mirror / Atom feed
From: Grzegorz Siwik <grzegorz.siwik@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: Grzegorz Siwik <grzegorz.siwik@intel.com>
Subject: [Intel-wired-lan] [PATCH net v5 0/4] ice: Fixes for double vlan promiscuous mode
Date: Fri, 12 Aug 2022 15:25:46 +0200	[thread overview]
Message-ID: <1660310750-290943-1-git-send-email-grzegorz.siwik@intel.com> (raw)

This series fixes known issues related to double vlan promiscuous mode.
When at least two interfaces are bonded and a bridge is enabled on the
bond, an error can occur when the bridge is removed and re-added. The
reason for the error is because promiscuous mode was not fully cleared from
the VLAN VSI in the hardware.
Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode.
This fix is needed because the driver could set promiscuous mode
when it still has not cleared properly.
If the requested promiscuous mode setting already exists,
an -EEXIST error message would be printed.
This is incorrect because promiscuous mode is
either on/off and shouldn't print an error when the requested
configuration is already set.
Avoid enabling or disabling vlan 0 when trying to set promiscuous
vlan mode if double vlan mode is enabled. This fix is needed
because the driver tries to add the vlan 0 filter twice (once for
inner and once for outer) when double VLAN mode is enabled.

---
 v2: Fixed error message when setting same promiscuous mode
---
 v3: Fixed style issues, changed to return directly.
---
 v4: Fixed problem with patch applying
---
 v5: Fixed incorrect title patch issue
---
Benjamin Mikailenko (1):
  ice: Ignore error message when setting same promiscuous mode

Grzegorz Siwik (3):
  ice: Fix double VLAN error when entering promisc mode
  ice: Ignore ERR_ALREADY_EXISTS when setting promisc mode
  ice: Fix clearing of promisc mode with bridge over bond

 drivers/net/ethernet/intel/ice/ice_fltr.c   |  8 ++++----
 drivers/net/ethernet/intel/ice/ice_lib.c    |  6 +++++-
 drivers/net/ethernet/intel/ice/ice_main.c   | 13 ++++++++++++-
 drivers/net/ethernet/intel/ice/ice_switch.c |  9 ++++++++-
 4 files changed, 29 insertions(+), 7 deletions(-)

-- 
1.8.3.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

             reply	other threads:[~2022-08-12 13:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 13:25 Grzegorz Siwik [this message]
2022-08-12 13:25 ` [Intel-wired-lan] [PATCH net v5 1/4] ice: Fix double VLAN error when entering promisc mode Grzegorz Siwik
2022-08-16 13:05   ` G, GurucharanX
2022-08-12 13:25 ` [Intel-wired-lan] [PATCH net v5 2/4] ice: Ignore EEXIST when setting " Grzegorz Siwik
2022-08-16 13:06   ` G, GurucharanX
2022-08-12 13:25 ` [Intel-wired-lan] [PATCH net v5 3/4] ice: Fix clearing of promisc mode with bridge over bond Grzegorz Siwik
2022-08-16 13:07   ` G, GurucharanX
2022-08-12 13:25 ` [Intel-wired-lan] [PATCH net v5 4/4] ice: Ignore error message when setting same promiscuous mode Grzegorz Siwik
2022-08-16 13:08   ` G, GurucharanX
2022-08-12 22:46 ` [Intel-wired-lan] [PATCH net v5 0/4] ice: Fixes for double vlan " Petr Oros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1660310750-290943-1-git-send-email-grzegorz.siwik@intel.com \
    --to=grzegorz.siwik@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).