From: "G, GurucharanX" <gurucharanx.g@intel.com>
To: "Gerasymenko, Anatolii" <anatolii.gerasymenko@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "Gerasymenko, Anatolii" <anatolii.gerasymenko@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net v1] ice: ethtool: advertise 1000M speeds properly
Date: Fri, 17 Jun 2022 06:09:34 +0000 [thread overview]
Message-ID: <BYAPR11MB3367BD9B6D07550FE5A0F3A0FCAF9@BYAPR11MB3367.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220607065556.3192203-1-anatolii.gerasymenko@intel.com>
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Anatolii Gerasymenko
> Sent: Tuesday, June 7, 2022 12:26 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Gerasymenko, Anatolii <anatolii.gerasymenko@intel.com>
> Subject: [Intel-wired-lan] [PATCH net v1] ice: ethtool: advertise 1000M
> speeds properly
>
> In current implementation ice_update_phy_type enables all link modes for
> selected speed. This approach doesn't work for 1000M speeds, because both
> copper (1000baseT) and optical (1000baseX) standards cannot be enabled at
> once.
>
> Add a special treatment for 1000M speeds.
>
> Fixes: 48cb27f2fd18 ("ice: Implement handlers for ethtool PHY/link
> operations")
> Signed-off-by: Anatolii Gerasymenko <anatolii.gerasymenko@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 39 +++++++++++++++++++-
> 1 file changed, 38 insertions(+), 1 deletion(-)
>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-06-17 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 6:55 [Intel-wired-lan] [PATCH net v1] ice: ethtool: advertise 1000M speeds properly Anatolii Gerasymenko
2022-06-17 6:09 ` G, GurucharanX [this message]
2022-06-17 8:03 ` Paul Menzel
2022-06-20 7:46 ` Anatolii Gerasymenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3367BD9B6D07550FE5A0F3A0FCAF9@BYAPR11MB3367.namprd11.prod.outlook.com \
--to=gurucharanx.g@intel.com \
--cc=anatolii.gerasymenko@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).