From: "G, GurucharanX" <gurucharanx.g@intel.com>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "Cieplicki, LukaszX" <lukaszx.cieplicki@intel.com>,
"Jagielski, Jedrzej" <jedrzej.jagielski@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net v2] i40e: Fix dropped jumbo frames statistics
Date: Tue, 14 Jun 2022 14:09:55 +0000 [thread overview]
Message-ID: <BYAPR11MB3367D31CA072126EC24501B6FCAA9@BYAPR11MB3367.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220531105420.2567792-1-jedrzej.jagielski@intel.com>
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jedrzej Jagielski
> Sent: Tuesday, May 31, 2022 4:24 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Jagielski, Jedrzej <jedrzej.jagielski@intel.com>; Cieplicki, LukaszX
> <lukaszx.cieplicki@intel.com>
> Subject: [Intel-wired-lan] [PATCH net v2] i40e: Fix dropped jumbo frames
> statistics
>
> From: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
>
> Dropped packets caused by too large frames were not included in dropped
> RX packets statistics.
> Issue was caused by not reading the GL_RXERR1 register. That register stores
> count of packet which was have been dropped due to too large size.
>
> Fix it by reading GL_RXERR1 register for each interface.
>
> Repro steps:
> Send a packet larger than the set MTU to SUT Observe rx statists: ethtool -S
> <interface> | grep rx | grep -v ": 0"
>
> Fixes: 41a9e55c89be ("i40e: add missing VSI statistics")
> Signed-off-by: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
> v2: amend commit msg, change returning types and provide little tweaks
> ---
> drivers/net/ethernet/intel/i40e/i40e.h | 16 ++++
> drivers/net/ethernet/intel/i40e/i40e_main.c | 73 +++++++++++++++++++
> .../net/ethernet/intel/i40e/i40e_register.h | 13 ++++
> drivers/net/ethernet/intel/i40e/i40e_type.h | 1 +
> 4 files changed, 103 insertions(+)
>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-06-14 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 10:54 [Intel-wired-lan] [PATCH net v2] i40e: Fix dropped jumbo frames statistics Jedrzej Jagielski
2022-06-14 14:09 ` G, GurucharanX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3367D31CA072126EC24501B6FCAA9@BYAPR11MB3367.namprd11.prod.outlook.com \
--to=gurucharanx.g@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jedrzej.jagielski@intel.com \
--cc=lukaszx.cieplicki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).