From: Zvi Effron <zeffron@riotgames.com>
To: Anatolii Gerasymenko <anatolii.gerasymenko@intel.com>
Cc: intel-wired-lan@lists.osuosl.org,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control
Date: Tue, 28 Jun 2022 13:36:50 -0700 [thread overview]
Message-ID: <CAC1LvL2vO-A2nV7H8-eMabiAf4_PQbsFMwVDpJbW3BLwe_vFOw@mail.gmail.com> (raw)
In-Reply-To: <20220628104354.4195-1-anatolii.gerasymenko@intel.com>
On Tue, Jun 28, 2022 at 3:45 AM Anatolii Gerasymenko
<anatolii.gerasymenko@intel.com> wrote:
>
> Implement possibility to change FCS/CRC stripping feature using
> ethtool command.
>
> Having FCS/CRC could be useful for:
> - network sniffers to inspect FCS/CRC correctness
> - for benchmarking use cases
> - XDP programs
>
Have you thought of exposing this through the XDP hints paradigm that Jesper
is working on? That could make it available to XDP programs that want it
without breaking those that assume they won't have it, allowing both programs
to coexist on the same machine?
> Anatolii Gerasymenko (1):
> ice: Implement FCS/CRC and VLAN stripping co-existence policy
>
> Jesse Brandeburg (1):
> ice: Implement control of FCS/CRC stripping
>
> drivers/net/ethernet/intel/ice/ice.h | 1 +
> drivers/net/ethernet/intel/ice/ice_base.c | 2 +-
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 5 +-
> drivers/net/ethernet/intel/ice/ice_lib.c | 21 ++++++
> drivers/net/ethernet/intel/ice/ice_lib.h | 2 +
> drivers/net/ethernet/intel/ice/ice_main.c | 73 ++++++++++++++++++--
> drivers/net/ethernet/intel/ice/ice_txrx.h | 3 +-
> 7 files changed, 96 insertions(+), 11 deletions(-)
>
> --
> 2.25.1
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-06-28 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 10:43 [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control Anatolii Gerasymenko
2022-06-28 10:49 ` [Intel-wired-lan] Patches not threaded below the cover letter (was: [PATCH net-next 0/2] ice: FCS/CRC stripping control) Paul Menzel
2022-06-30 6:22 ` Anatolii Gerasymenko
2022-06-28 20:36 ` Zvi Effron [this message]
2022-06-30 6:26 ` [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control Anatolii Gerasymenko
2022-07-20 5:23 ` Mekala, SunithaX D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC1LvL2vO-A2nV7H8-eMabiAf4_PQbsFMwVDpJbW3BLwe_vFOw@mail.gmail.com \
--to=zeffron@riotgames.com \
--cc=anatolii.gerasymenko@intel.com \
--cc=brouer@redhat.com \
--cc=intel-wired-lan@lists.osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).